refactor(plugin-form): retire the form-view section className/gridClassName reads#7198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-support-ai merged 3 commits into from
Sep 1, 2026
Merged

refactor(plugin-form): retire the form-view section className/gridClassName reads #7198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e3e7ff2
refactor(plugin-form): retire the form-view section className/gridCla…
claude Sep 1, 2026
e3f2dc5
docs(plugin-form): record that section styling is not authorable, + c…
claude Sep 1, 2026
4174960
Merge origin/main into claude/issue-13626-formview-classname-reads
claude Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions .changeset/13626-formview-section-style-keys-retired.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
---
'@object-ui/plugin-form': minor
---

Retire the form-view section `className` / `gridClassName` reads (objectstack#13626,
maintainer ruling 2026-09-01, director decision batch C).

**Breaking, deliberately.** A `className` or `gridClassName` authored on a form-view
section no longer has any effect. Before this change an authored `gridClassName`
reached the section's field-grid `<div>` and an authored `className` reached the
section wrapper / divider header; both are now dropped at the renderer.

The two keys sit on the SDUI-only side of the authorable boundary: `@objectstack/spec`
deliberately does not declare either on the form-view/section surface (its
`component.zod.ts` says so in as many words) and the authorable-surface ledger carries
no entry for them. The renderer nevertheless reached them off the parsed view through
`as any` at seven sites — the boundary declared on one side and crossed on the other,
with the two repos each deliberate and in opposite directions.

Declaring the keys instead was weighed and **not** adopted: it would formally invite
free Tailwind strings into authored metadata, the exact class the boundary exists to
keep out — and per ADR-0065 / ADR-0080 (rev. 2026-06-30) utility classNames in runtime
metadata are never scanned by the build-time Tailwind, so they silently produce no CSS
anyway. Declaring them would have published a styling surface whose most obvious use
does nothing. If per-view styling becomes a real product need it gets an explicit
controlled token surface, not two leaked keys.

**Migration.** Nothing in the measured corpora has to change. A census across the
objectstack corpus, this repo's corpus, and the hotcrm application found **zero**
authored uses of either key on a form-view section (201 authored section nodes reached,
0 carrying either key). If you author them in your own metadata, move the styling to
the host application's own CSS, or to the form ROOT `className` — which is a different
key on a different node and is **unaffected** by this change.

Six sites in `ObjectForm` (the tabbed / wizard / split / drawer / modal section maps and
the stacked section-divider) and one in `DrawerForm` (its own divider) stop copying the
keys. The omission is pinned behaviourally across all seven arms rather than by a source
grep, because `ObjectFormSection` still declares both keys — so a later uncast
`className: s.className` would type-check and silently restore consumption.
32 changes: 31 additions & 1 deletion packages/plugin-form/README.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -229,7 +229,7 @@ here too. Two that a reader might expect, and that are **not** declared:
| Not a `FormField` key | Write this instead |
|---|---|
| `defaultValue` | `FormSchema.defaultValues` at form level. An object-bound form seeds from the object field's own declared `defaultValue` — see [What a create form opens with](#what-a-create-form-opens-with) |
| `className` | `span` / `colSpan` for width, `FormSchema.fieldContainerClass` for the grid. (An undeclared key still rides the props spread down to whichever component the field resolves to, so a field-level `className` can visibly land on a built-in control — but nothing in the contract promises that, and a registered widget honours it only if it happens to spread its leftover props. The renderer reads it *explicitly* on exactly one pseudo-field, `type: 'section-divider'`, where it styles the inline section header.) |
| `className` | `span` / `colSpan` for width, `FormSchema.fieldContainerClass` for the grid. (An undeclared key still rides the props spread down to whichever component the field resolves to, so a field-level `className` can visibly land on a built-in control — but nothing in the contract promises that, and a registered widget honours it only if it happens to spread its leftover props. The renderer reads it *explicitly* nowhere: it used to stamp the `type: 'section-divider'` pseudo-field from an authored section's `className`, and that read was **retired** in objectstack#13626 — see [Section styling is not authorable](#section-styling-is-not-authorable).) |

There is no `ValidationRule` type in this repo, under any spelling.

Expand DownExpand Up@@ -376,6 +376,36 @@ The grid is applied to the field container **inside** the form, never wrapped
around the `<form>` (which would put the whole form in cell 1 and leave the other
columns empty — #2128).

### Section styling is not authorable

`className` and `gridClassName` on a form-view **section** do nothing. Authoring
them is not an error and not a compile failure — the renderer simply does not
read them.

This is deliberate. Both keys sit on the SDUI-only side of the authorable
boundary: `@objectstack/spec` does not declare either on the form-view/section
surface, and the authorable-surface ledger carries no entry for them. The
renderer nevertheless reached them through `as any` at seven sites until
objectstack#13626 (maintainer ruling 2026-09-01) retired those reads — the
boundary had been declared on one side and crossed on the other.

Declaring the keys instead was weighed and rejected: it would invite free
Tailwind strings into authored metadata, which is the class the boundary exists
to keep out, and per ADR-0065 / ADR-0080 utility classNames in runtime metadata
are never scanned by the build-time Tailwind — so they silently produce no CSS
even when they are read. If per-view styling becomes a real product need it will
get an explicit controlled token surface rather than two leaked keys.

**What still works:** the form ROOT `className` (`FormSchema.className`) is a
different key on a different node and is unaffected; section *layout* stays
authorable through `columns` (above); and a host application styles sections
through its own CSS.

> Note for contributors: `ObjectFormSection` in `@object-ui/types` still declares
> both keys, so a plain `className: s.className` would type-check and silently
> restore consumption. The non-consumption is therefore pinned behaviourally, in
> `src/__tests__/sectionStyleKeysRetired-13626.test.tsx`, across all seven arms.

### Tabbed field layout (`fieldTabs`)

A sectioned form is **one** form. Instead of rendering a form per section — which
Expand Down
7 changes: 6 additions & 1 deletion packages/plugin-form/src/DrawerForm.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -595,7 +595,12 @@ export const DrawerForm: React.FC<DrawerFormProps> = ({
onToggle: section.collapsible
? () => setCollapsedSections(prev => ({ ...prev, [sectionKey]: !isCollapsed }))
: undefined,
className: (section as any).className,
// ⛔ `className` deliberately not read — objectstack#13626, maintainer
// ruling 2026-09-01 (batch C) "retire the reads". The key is on the
// SDUI-only side of the authorable boundary; `ObjectForm`'s drawer map
// stops copying it in the same pass. Full rationale at the tabbed arm
// in `ObjectForm.tsx`; pinned by
// `__tests__/sectionStyleKeysRetired-13626.test.tsx`.
} as any);

if (isCollapsed) {
Expand Down
48 changes: 38 additions & 10 deletions packages/plugin-form/src/ObjectForm.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -290,8 +290,33 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
// compiling and silently copy `undefined` — the exact silent-drop
// failure this line exists to fix.
visibleWhen: s.visibleWhen,
className: (s as any).className,
gridClassName: (s as any).gridClassName,
// ⛔ `className` / `gridClassName` are DELIBERATELY not copied here
// or at any of the six sibling sites below — objectstack#13626,
// maintainer ruling 2026-09-01 (director decision batch C):
// "retire the reads".
//
// The two keys sit on the SDUI-only side of the authorable
// boundary: `@objectstack/spec` deliberately does NOT declare them
// on the form-view/section surface (see the "Deliberately NOT
// declared" note in its `component.zod.ts`), and the
// authorable-surface ledger carries no entry for them. They were
// nevertheless reached off the parsed view through `as any` — the
// boundary declared on one side and crossed on the other.
//
// Declaring them instead was weighed and NOT adopted: it would
// formally invite free Tailwind strings into authored metadata,
// the exact class the boundary exists to keep out — and per
// ADR-0065 / ADR-0080 (rev. 2026-06-30) utility classNames in
// runtime metadata are never scanned by the build-time Tailwind,
// so they silently produce no CSS. If per-view styling becomes a
// real product need it gets an explicit controlled token surface,
// not two leaked keys.
//
// ⚠️ Re-adding the read does NOT require a cast to compile:
// `ObjectFormSection` (this repo's own `@object-ui/types`) still
// declares both keys, so a plain `className: s.className` type
// -checks. The omission is therefore pinned behaviourally, not by
// a source grep — `__tests__/sectionStyleKeysRetired-13626.test.tsx`.
})),
defaultTab: schema.defaultTab,
tabPosition: schema.tabPosition,
Expand DownExpand Up@@ -322,8 +347,8 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
description: s.description,
columns: s.columns,
fields: s.fields,
className: (s as any).className,
gridClassName: (s as any).gridClassName,
// `className` / `gridClassName`: deliberately not copied — see the
// tabbed arm above (objectstack#13626, ruled 2026-09-01).
})),
allowSkip: schema.allowSkip,
showStepIndicator: schema.showStepIndicator,
Expand DownExpand Up@@ -356,8 +381,8 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
// ADR-0089 section predicate (#6111) — same reason as `pane` above:
// a key this map does not copy never reaches the layout at all.
visibleWhen: (s as any).visibleWhen,
className: (s as any).className,
gridClassName: (s as any).gridClassName,
// `className` / `gridClassName`: deliberately not copied — see the
// tabbed arm above (objectstack#13626, ruled 2026-09-01).
})),
splitDirection: schema.splitDirection,
splitSize: schema.splitSize,
Expand DownExpand Up@@ -389,7 +414,9 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
// ADR-0089 section predicate (#6111) — key-by-key rebuild, so an
// uncopied key is silently dropped before DrawerForm ever sees it.
visibleWhen: (s as any).visibleWhen,
className: (s as any).className,
// `className`: deliberately not copied — see the tabbed arm above
// (objectstack#13626, ruled 2026-09-01). DrawerForm's own divider
// site stops reading it in the same pass.
})),
open: schema.open,
onOpenChange: schema.onOpenChange,
Expand DownExpand Up@@ -420,8 +447,8 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
// ADR-0089 section predicate (#6111) — key-by-key rebuild, so an
// uncopied key is silently dropped before ModalForm ever sees it.
visibleWhen: (s as any).visibleWhen,
className: (s as any).className,
gridClassName: (s as any).gridClassName,
// `className` / `gridClassName`: deliberately not copied — see the
// tabbed arm above (objectstack#13626, ruled 2026-09-01).
})),
open: schema.open,
onOpenChange: schema.onOpenChange,
Expand DownExpand Up@@ -1290,7 +1317,8 @@ const SimpleObjectForm: React.FC<ObjectFormComponentProps> = ({
onToggle: section.collapsible
? () => setCollapsedSections(prev => ({ ...prev, [sectionKey]: !isCollapsed }))
: undefined,
className: (section as any).className,
// `className`: deliberately not read — see the tabbed arm above
// (objectstack#13626, ruled 2026-09-01 "retire the reads").
} as FormField);
}

Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
refactor(plugin-form): retire the form-view section className/gridClassName reads#7198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-support-ai
merged 3 commits into

from

Sep 1, 2026
 Merged


refactor(plugin-form): retire the form-view section className/gridClassName reads
#7198
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
e3e7ff2

refactor(plugin-form): retire the form-view section className/gridCla…


claude Sep 1, 2026
e3f2dc5

docs(plugin-form): record that section styling is not authorable, + c…


claude Sep 1, 2026
4174960

Merge origin/main into claude/issue-13626-formview-classname-reads


claude Sep 1, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


39 changes: 39 additions & 0 deletions
.changeset/13626-formview-section-style-keys-retired.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
---
'@object-ui/plugin-form': minor
---

Retire the form-view section `className` / `gridClassName` reads (objectstack#13626,
maintainer ruling 2026-09-01, director decision batch C).

**Breaking, deliberately.** A `className` or `gridClassName` authored on a form-view
section no longer has any effect. Before this change an authored `gridClassName`
reached the section's field-grid `<div>` and an authored `className` reached the
section wrapper / divider header; both are now dropped at the renderer.

The two keys sit on the SDUI-only side of the authorable boundary: `@objectstack/spec`
deliberately does not declare either on the form-view/section surface (its
`component.zod.ts` says so in as many words) and the authorable-surface ledger carries
no entry for them. The renderer nevertheless reached them off the parsed view through
`as any` at seven sites — the boundary declared on one side and crossed on the other,
with the two repos each deliberate and in opposite directions.

Declaring the keys instead was weighed and **not** adopted: it would formally invite
free Tailwind strings into authored metadata, the exact class the boundary exists to
keep out — and per ADR-0065 / ADR-0080 (rev. 2026-06-30) utility classNames in runtime
metadata are never scanned by the build-time Tailwind, so they silently produce no CSS
anyway. Declaring them would have published a styling surface whose most obvious use
does nothing. If per-view styling becomes a real product need it gets an explicit
controlled token surface, not two leaked keys.

**Migration.** Nothing in the measured corpora has to change. A census across the
objectstack corpus, this repo's corpus, and the hotcrm application found **zero**
authored uses of either key on a form-view section (201 authored section nodes reached,
0 carrying either key). If you author them in your own metadata, move the styling to
the host application's own CSS, or to the form ROOT `className` — which is a different
key on a different node and is **unaffected** by this change.

Six sites in `ObjectForm` (the tabbed / wizard / split / drawer / modal section maps and
the stacked section-divider) and one in `DrawerForm` (its own divider) stop copying the
keys. The omission is pinned behaviourally across all seven arms rather than by a source
grep, because `ObjectFormSection` still declares both keys — so a later uncast
`className: s.className` would type-check and silently restore consumption.

32 changes: 31 additions & 1 deletion
packages/plugin-form/README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -229,7 +229,7 @@ here too. Two that a reader might expect, and that are **not** declared:
| Not a `FormField` key | Write this instead |
|---|---|
| `defaultValue` | `FormSchema.defaultValues` at form level. An object-bound form seeds from the object field's own declared `defaultValue` — see [What a create form opens with](#what-a-create-form-opens-with) |
| `className` | `span` / `colSpan` for width, `FormSchema.fieldContainerClass` for the grid. (An undeclared key still rides the props spread down to whichever component the field resolves to, so a field-level `className` can visibly land on a built-in control — but nothing in the contract promises that, and a registered widget honours it only if it happens to spread its leftover props. The renderer reads it *explicitly* on exactly one pseudo-field, `type: 'section-divider'`, where it styles the inline section header.) |
| `className` | `span` / `colSpan` for width, `FormSchema.fieldContainerClass` for the grid. (An undeclared key still rides the props spread down to whichever component the field resolves to, so a field-level `className` can visibly land on a built-in control — but nothing in the contract promises that, and a registered widget honours it only if it happens to spread its leftover props. The renderer reads it *explicitly* nowhere: it used to stamp the `type: 'section-divider'` pseudo-field from an authored section's `className`, and that read was **retired** in objectstack#13626 — see [Section styling is not authorable](#section-styling-is-not-authorable).) |

There is no `ValidationRule` type in this repo, under any spelling.

Expand DownExpand Up@@ -376,6 +376,36 @@ The grid is applied to the field container **inside** the form, never wrapped
around the `<form>` (which would put the whole form in cell 1 and leave the other
columns empty — #2128).

### Section styling is not authorable

`className` and `gridClassName` on a form-view **section** do nothing. Authoring
them is not an error and not a compile failure — the renderer simply does not
read them.

This is deliberate. Both keys sit on the SDUI-only side of the authorable
boundary: `@objectstack/spec` does not declare either on the form-view/section
surface, and the authorable-surface ledger carries no entry for them. The
renderer nevertheless reached them through `as any` at seven sites until
objectstack#13626 (maintainer ruling 2026-09-01) retired those reads — the
boundary had been declared on one side and crossed on the other.

Declaring the keys instead was weighed and rejected: it would invite free
Tailwind strings into authored metadata, which is the class the boundary exists
to keep out, and per ADR-0065 / ADR-0080 utility classNames in runtime metadata
are never scanned by the build-time Tailwind — so they silently produce no CSS
even when they are read. If per-view styling becomes a real product need it will
get an explicit controlled token surface rather than two leaked keys.

**What still works:** the form ROOT `className` (`FormSchema.className`) is a
different key on a different node and is unaffected; section *layout* stays
authorable through `columns` (above); and a host application styles sections
through its own CSS.

> Note for contributors: `ObjectFormSection` in `@object-ui/types` still declares
> both keys, so a plain `className: s.className` would type-check and silently
> restore consumption. The non-consumption is therefore pinned behaviourally, in
> `src/__tests__/sectionStyleKeysRetired-13626.test.tsx`, across all seven arms.

### Tabbed field layout (`fieldTabs`)

A sectioned form is **one** form. Instead of rendering a form per section — which
Expand Down

7 changes: 6 additions & 1 deletion
packages/plugin-form/src/DrawerForm.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -595,7 +595,12 @@ export const DrawerForm: React.FC<DrawerFormProps> = ({
 onToggle: section.collapsible
 ? () => setCollapsedSections(prev => ({ ...prev, [sectionKey]: !isCollapsed }))
 : undefined,
 className: (section as any).className,
 // ⛔ `className` deliberately not read — objectstack#13626, maintainer
 // ruling 2026-09-01 (batch C) "retire the reads". The key is on the
 // SDUI-only side of the authorable boundary; `ObjectForm`'s drawer map
 // stops copying it in the same pass. Full rationale at the tabbed arm
 // in `ObjectForm.tsx`; pinned by
 // `__tests__/sectionStyleKeysRetired-13626.test.tsx`.
 } as any);

 if (isCollapsed) {
Expand Down

48 changes: 38 additions & 10 deletions
packages/plugin-form/src/ObjectForm.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -290,8 +290,33 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 // compiling and silently copy `undefined` — the exact silent-drop
 // failure this line exists to fix.
 visibleWhen: s.visibleWhen,
 className: (s as any).className,
 gridClassName: (s as any).gridClassName,
 // ⛔ `className` / `gridClassName` are DELIBERATELY not copied here
 // or at any of the six sibling sites below — objectstack#13626,
 // maintainer ruling 2026-09-01 (director decision batch C):
 // "retire the reads".
 //
 // The two keys sit on the SDUI-only side of the authorable
 // boundary: `@objectstack/spec` deliberately does NOT declare them
 // on the form-view/section surface (see the "Deliberately NOT
 // declared" note in its `component.zod.ts`), and the
 // authorable-surface ledger carries no entry for them. They were
 // nevertheless reached off the parsed view through `as any` — the
 // boundary declared on one side and crossed on the other.
 //
 // Declaring them instead was weighed and NOT adopted: it would
 // formally invite free Tailwind strings into authored metadata,
 // the exact class the boundary exists to keep out — and per
 // ADR-0065 / ADR-0080 (rev. 2026-06-30) utility classNames in
 // runtime metadata are never scanned by the build-time Tailwind,
 // so they silently produce no CSS. If per-view styling becomes a
 // real product need it gets an explicit controlled token surface,
 // not two leaked keys.
 //
 // ⚠️ Re-adding the read does NOT require a cast to compile:
 // `ObjectFormSection` (this repo's own `@object-ui/types`) still
 // declares both keys, so a plain `className: s.className` type
 // -checks. The omission is therefore pinned behaviourally, not by
 // a source grep — `__tests__/sectionStyleKeysRetired-13626.test.tsx`.
 })),
 defaultTab: schema.defaultTab,
 tabPosition: schema.tabPosition,
Expand DownExpand Up@@ -322,8 +347,8 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 description: s.description,
 columns: s.columns,
 fields: s.fields,
 className: (s as any).className,
gridClassName: (s as any).gridClassName,
// `className` / `gridClassName`: deliberately not copied — see the
// tabbed arm above (objectstack#13626, ruled 2026-09-01).
 })),
 allowSkip: schema.allowSkip,
 showStepIndicator: schema.showStepIndicator,
Expand DownExpand Up@@ -356,8 +381,8 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 // ADR-0089 section predicate (#6111) — same reason as `pane` above:
 // a key this map does not copy never reaches the layout at all.
 visibleWhen: (s as any).visibleWhen,
 className: (s as any).className,
gridClassName: (s as any).gridClassName,
// `className` / `gridClassName`: deliberately not copied — see the
// tabbed arm above (objectstack#13626, ruled 2026-09-01).
 })),
 splitDirection: schema.splitDirection,
 splitSize: schema.splitSize,
Expand DownExpand Up@@ -389,7 +414,9 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 // ADR-0089 section predicate (#6111) — key-by-key rebuild, so an
 // uncopied key is silently dropped before DrawerForm ever sees it.
 visibleWhen: (s as any).visibleWhen,
 className: (s as any).className,
 // `className`: deliberately not copied — see the tabbed arm above
 // (objectstack#13626, ruled 2026-09-01). DrawerForm's own divider
 // site stops reading it in the same pass.
 })),
 open: schema.open,
 onOpenChange: schema.onOpenChange,
Expand DownExpand Up@@ -420,8 +447,8 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 // ADR-0089 section predicate (#6111) — key-by-key rebuild, so an
 // uncopied key is silently dropped before ModalForm ever sees it.
 visibleWhen: (s as any).visibleWhen,
 className: (s as any).className,
gridClassName: (s as any).gridClassName,
// `className` / `gridClassName`: deliberately not copied — see the
// tabbed arm above (objectstack#13626, ruled 2026-09-01).
 })),
 open: schema.open,
 onOpenChange: schema.onOpenChange,
Expand DownExpand Up@@ -1290,7 +1317,8 @@ const SimpleObjectForm: React.FC<ObjectFormComponentProps> = ({
 onToggle: section.collapsible
 ? () => setCollapsedSections(prev => ({ ...prev, [sectionKey]: !isCollapsed }))
 : undefined,
 className: (section as any).className,
 // `className`: deliberately not read — see the tabbed arm above
 // (objectstack#13626, ruled 2026-09-01 "retire the reads").
 } as FormField);
 }

Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
refactor(plugin-form): retire the form-view section className/gridClassName reads#7198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-support-ai
merged 3 commits into

from

Sep 1, 2026
 Merged


refactor(plugin-form): retire the form-view section className/gridClassName reads
#7198
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
e3e7ff2

refactor(plugin-form): retire the form-view section className/gridCla…


claude Sep 1, 2026
e3f2dc5

docs(plugin-form): record that section styling is not authorable, + c…


claude Sep 1, 2026
4174960

Merge origin/main into claude/issue-13626-formview-classname-reads


claude Sep 1, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


39 changes: 39 additions & 0 deletions
.changeset/13626-formview-section-style-keys-retired.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
---
'@object-ui/plugin-form': minor
---

Retire the form-view section `className` / `gridClassName` reads (objectstack#13626,
maintainer ruling 2026-09-01, director decision batch C).

**Breaking, deliberately.** A `className` or `gridClassName` authored on a form-view
section no longer has any effect. Before this change an authored `gridClassName`
reached the section's field-grid `<div>` and an authored `className` reached the
section wrapper / divider header; both are now dropped at the renderer.

The two keys sit on the SDUI-only side of the authorable boundary: `@objectstack/spec`
deliberately does not declare either on the form-view/section surface (its
`component.zod.ts` says so in as many words) and the authorable-surface ledger carries
no entry for them. The renderer nevertheless reached them off the parsed view through
`as any` at seven sites — the boundary declared on one side and crossed on the other,
with the two repos each deliberate and in opposite directions.

Declaring the keys instead was weighed and **not** adopted: it would formally invite
free Tailwind strings into authored metadata, the exact class the boundary exists to
keep out — and per ADR-0065 / ADR-0080 (rev. 2026-06-30) utility classNames in runtime
metadata are never scanned by the build-time Tailwind, so they silently produce no CSS
anyway. Declaring them would have published a styling surface whose most obvious use
does nothing. If per-view styling becomes a real product need it gets an explicit
controlled token surface, not two leaked keys.

**Migration.** Nothing in the measured corpora has to change. A census across the
objectstack corpus, this repo's corpus, and the hotcrm application found **zero**
authored uses of either key on a form-view section (201 authored section nodes reached,
0 carrying either key). If you author them in your own metadata, move the styling to
the host application's own CSS, or to the form ROOT `className` — which is a different
key on a different node and is **unaffected** by this change.

Six sites in `ObjectForm` (the tabbed / wizard / split / drawer / modal section maps and
the stacked section-divider) and one in `DrawerForm` (its own divider) stop copying the
keys. The omission is pinned behaviourally across all seven arms rather than by a source
grep, because `ObjectFormSection` still declares both keys — so a later uncast
`className: s.className` would type-check and silently restore consumption.

32 changes: 31 additions & 1 deletion
packages/plugin-form/README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -229,7 +229,7 @@ here too. Two that a reader might expect, and that are **not** declared:
| Not a `FormField` key | Write this instead |
|---|---|
| `defaultValue` | `FormSchema.defaultValues` at form level. An object-bound form seeds from the object field's own declared `defaultValue` — see [What a create form opens with](#what-a-create-form-opens-with) |
| `className` | `span` / `colSpan` for width, `FormSchema.fieldContainerClass` for the grid. (An undeclared key still rides the props spread down to whichever component the field resolves to, so a field-level `className` can visibly land on a built-in control — but nothing in the contract promises that, and a registered widget honours it only if it happens to spread its leftover props. The renderer reads it *explicitly* on exactly one pseudo-field, `type: 'section-divider'`, where it styles the inline section header.) |
| `className` | `span` / `colSpan` for width, `FormSchema.fieldContainerClass` for the grid. (An undeclared key still rides the props spread down to whichever component the field resolves to, so a field-level `className` can visibly land on a built-in control — but nothing in the contract promises that, and a registered widget honours it only if it happens to spread its leftover props. The renderer reads it *explicitly* nowhere: it used to stamp the `type: 'section-divider'` pseudo-field from an authored section's `className`, and that read was **retired** in objectstack#13626 — see [Section styling is not authorable](#section-styling-is-not-authorable).) |

There is no `ValidationRule` type in this repo, under any spelling.

Expand DownExpand Up@@ -376,6 +376,36 @@ The grid is applied to the field container **inside** the form, never wrapped
around the `<form>` (which would put the whole form in cell 1 and leave the other
columns empty — #2128).

### Section styling is not authorable

`className` and `gridClassName` on a form-view **section** do nothing. Authoring
them is not an error and not a compile failure — the renderer simply does not
read them.

This is deliberate. Both keys sit on the SDUI-only side of the authorable
boundary: `@objectstack/spec` does not declare either on the form-view/section
surface, and the authorable-surface ledger carries no entry for them. The
renderer nevertheless reached them through `as any` at seven sites until
objectstack#13626 (maintainer ruling 2026-09-01) retired those reads — the
boundary had been declared on one side and crossed on the other.

Declaring the keys instead was weighed and rejected: it would invite free
Tailwind strings into authored metadata, which is the class the boundary exists
to keep out, and per ADR-0065 / ADR-0080 utility classNames in runtime metadata
are never scanned by the build-time Tailwind — so they silently produce no CSS
even when they are read. If per-view styling becomes a real product need it will
get an explicit controlled token surface rather than two leaked keys.

**What still works:** the form ROOT `className` (`FormSchema.className`) is a
different key on a different node and is unaffected; section *layout* stays
authorable through `columns` (above); and a host application styles sections
through its own CSS.

> Note for contributors: `ObjectFormSection` in `@object-ui/types` still declares
> both keys, so a plain `className: s.className` would type-check and silently
> restore consumption. The non-consumption is therefore pinned behaviourally, in
> `src/__tests__/sectionStyleKeysRetired-13626.test.tsx`, across all seven arms.

### Tabbed field layout (`fieldTabs`)

A sectioned form is **one** form. Instead of rendering a form per section — which
Expand Down

7 changes: 6 additions & 1 deletion
packages/plugin-form/src/DrawerForm.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -595,7 +595,12 @@ export const DrawerForm: React.FC<DrawerFormProps> = ({
 onToggle: section.collapsible
 ? () => setCollapsedSections(prev => ({ ...prev, [sectionKey]: !isCollapsed }))
 : undefined,
 className: (section as any).className,
 // ⛔ `className` deliberately not read — objectstack#13626, maintainer
 // ruling 2026-09-01 (batch C) "retire the reads". The key is on the
 // SDUI-only side of the authorable boundary; `ObjectForm`'s drawer map
 // stops copying it in the same pass. Full rationale at the tabbed arm
 // in `ObjectForm.tsx`; pinned by
 // `__tests__/sectionStyleKeysRetired-13626.test.tsx`.
 } as any);

 if (isCollapsed) {
Expand Down

48 changes: 38 additions & 10 deletions
packages/plugin-form/src/ObjectForm.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -290,8 +290,33 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 // compiling and silently copy `undefined` — the exact silent-drop
 // failure this line exists to fix.
 visibleWhen: s.visibleWhen,
 className: (s as any).className,
 gridClassName: (s as any).gridClassName,
 // ⛔ `className` / `gridClassName` are DELIBERATELY not copied here
 // or at any of the six sibling sites below — objectstack#13626,
 // maintainer ruling 2026-09-01 (director decision batch C):
 // "retire the reads".
 //
 // The two keys sit on the SDUI-only side of the authorable
 // boundary: `@objectstack/spec` deliberately does NOT declare them
 // on the form-view/section surface (see the "Deliberately NOT
 // declared" note in its `component.zod.ts`), and the
 // authorable-surface ledger carries no entry for them. They were
 // nevertheless reached off the parsed view through `as any` — the
 // boundary declared on one side and crossed on the other.
 //
 // Declaring them instead was weighed and NOT adopted: it would
 // formally invite free Tailwind strings into authored metadata,
 // the exact class the boundary exists to keep out — and per
 // ADR-0065 / ADR-0080 (rev. 2026-06-30) utility classNames in
 // runtime metadata are never scanned by the build-time Tailwind,
 // so they silently produce no CSS. If per-view styling becomes a
 // real product need it gets an explicit controlled token surface,
 // not two leaked keys.
 //
 // ⚠️ Re-adding the read does NOT require a cast to compile:
 // `ObjectFormSection` (this repo's own `@object-ui/types`) still
 // declares both keys, so a plain `className: s.className` type
 // -checks. The omission is therefore pinned behaviourally, not by
 // a source grep — `__tests__/sectionStyleKeysRetired-13626.test.tsx`.
 })),
 defaultTab: schema.defaultTab,
 tabPosition: schema.tabPosition,
Expand DownExpand Up@@ -322,8 +347,8 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 description: s.description,
 columns: s.columns,
 fields: s.fields,
 className: (s as any).className,
gridClassName: (s as any).gridClassName,
// `className` / `gridClassName`: deliberately not copied — see the
// tabbed arm above (objectstack#13626, ruled 2026-09-01).
 })),
 allowSkip: schema.allowSkip,
 showStepIndicator: schema.showStepIndicator,
Expand DownExpand Up@@ -356,8 +381,8 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 // ADR-0089 section predicate (#6111) — same reason as `pane` above:
 // a key this map does not copy never reaches the layout at all.
 visibleWhen: (s as any).visibleWhen,
 className: (s as any).className,
gridClassName: (s as any).gridClassName,
// `className` / `gridClassName`: deliberately not copied — see the
// tabbed arm above (objectstack#13626, ruled 2026-09-01).
 })),
 splitDirection: schema.splitDirection,
 splitSize: schema.splitSize,
Expand DownExpand Up@@ -389,7 +414,9 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 // ADR-0089 section predicate (#6111) — key-by-key rebuild, so an
 // uncopied key is silently dropped before DrawerForm ever sees it.
 visibleWhen: (s as any).visibleWhen,
 className: (s as any).className,
 // `className`: deliberately not copied — see the tabbed arm above
 // (objectstack#13626, ruled 2026-09-01). DrawerForm's own divider
 // site stops reading it in the same pass.
 })),
 open: schema.open,
 onOpenChange: schema.onOpenChange,
Expand DownExpand Up@@ -420,8 +447,8 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 // ADR-0089 section predicate (#6111) — key-by-key rebuild, so an
 // uncopied key is silently dropped before ModalForm ever sees it.
 visibleWhen: (s as any).visibleWhen,
 className: (s as any).className,
gridClassName: (s as any).gridClassName,
// `className` / `gridClassName`: deliberately not copied — see the
// tabbed arm above (objectstack#13626, ruled 2026-09-01).
 })),
 open: schema.open,
 onOpenChange: schema.onOpenChange,
Expand DownExpand Up@@ -1290,7 +1317,8 @@ const SimpleObjectForm: React.FC<ObjectFormComponentProps> = ({
 onToggle: section.collapsible
 ? () => setCollapsedSections(prev => ({ ...prev, [sectionKey]: !isCollapsed }))
 : undefined,
 className: (section as any).className,
 // `className`: deliberately not read — see the tabbed arm above
 // (objectstack#13626, ruled 2026-09-01 "retire the reads").
 } as FormField);
 }

Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
refactor(plugin-form): retire the form-view section className/gridClassName reads#7198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-support-ai
merged 3 commits into

from

Sep 1, 2026
 Merged


refactor(plugin-form): retire the form-view section className/gridClassName reads
#7198
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
e3e7ff2

refactor(plugin-form): retire the form-view section className/gridCla…


claude Sep 1, 2026
e3f2dc5

docs(plugin-form): record that section styling is not authorable, + c…


claude Sep 1, 2026
4174960

Merge origin/main into claude/issue-13626-formview-classname-reads


claude Sep 1, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


39 changes: 39 additions & 0 deletions
.changeset/13626-formview-section-style-keys-retired.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
---
'@object-ui/plugin-form': minor
---

Retire the form-view section `className` / `gridClassName` reads (objectstack#13626,
maintainer ruling 2026-09-01, director decision batch C).

**Breaking, deliberately.** A `className` or `gridClassName` authored on a form-view
section no longer has any effect. Before this change an authored `gridClassName`
reached the section's field-grid `<div>` and an authored `className` reached the
section wrapper / divider header; both are now dropped at the renderer.

The two keys sit on the SDUI-only side of the authorable boundary: `@objectstack/spec`
deliberately does not declare either on the form-view/section surface (its
`component.zod.ts` says so in as many words) and the authorable-surface ledger carries
no entry for them. The renderer nevertheless reached them off the parsed view through
`as any` at seven sites — the boundary declared on one side and crossed on the other,
with the two repos each deliberate and in opposite directions.

Declaring the keys instead was weighed and **not** adopted: it would formally invite
free Tailwind strings into authored metadata, the exact class the boundary exists to
keep out — and per ADR-0065 / ADR-0080 (rev. 2026-06-30) utility classNames in runtime
metadata are never scanned by the build-time Tailwind, so they silently produce no CSS
anyway. Declaring them would have published a styling surface whose most obvious use
does nothing. If per-view styling becomes a real product need it gets an explicit
controlled token surface, not two leaked keys.

**Migration.** Nothing in the measured corpora has to change. A census across the
objectstack corpus, this repo's corpus, and the hotcrm application found **zero**
authored uses of either key on a form-view section (201 authored section nodes reached,
0 carrying either key). If you author them in your own metadata, move the styling to
the host application's own CSS, or to the form ROOT `className` — which is a different
key on a different node and is **unaffected** by this change.

Six sites in `ObjectForm` (the tabbed / wizard / split / drawer / modal section maps and
the stacked section-divider) and one in `DrawerForm` (its own divider) stop copying the
keys. The omission is pinned behaviourally across all seven arms rather than by a source
grep, because `ObjectFormSection` still declares both keys — so a later uncast
`className: s.className` would type-check and silently restore consumption.

32 changes: 31 additions & 1 deletion
packages/plugin-form/README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -229,7 +229,7 @@ here too. Two that a reader might expect, and that are **not** declared:
| Not a `FormField` key | Write this instead |
|---|---|
| `defaultValue` | `FormSchema.defaultValues` at form level. An object-bound form seeds from the object field's own declared `defaultValue` — see [What a create form opens with](#what-a-create-form-opens-with) |
| `className` | `span` / `colSpan` for width, `FormSchema.fieldContainerClass` for the grid. (An undeclared key still rides the props spread down to whichever component the field resolves to, so a field-level `className` can visibly land on a built-in control — but nothing in the contract promises that, and a registered widget honours it only if it happens to spread its leftover props. The renderer reads it *explicitly* on exactly one pseudo-field, `type: 'section-divider'`, where it styles the inline section header.) |
| `className` | `span` / `colSpan` for width, `FormSchema.fieldContainerClass` for the grid. (An undeclared key still rides the props spread down to whichever component the field resolves to, so a field-level `className` can visibly land on a built-in control — but nothing in the contract promises that, and a registered widget honours it only if it happens to spread its leftover props. The renderer reads it *explicitly* nowhere: it used to stamp the `type: 'section-divider'` pseudo-field from an authored section's `className`, and that read was **retired** in objectstack#13626 — see [Section styling is not authorable](#section-styling-is-not-authorable).) |

There is no `ValidationRule` type in this repo, under any spelling.

Expand DownExpand Up@@ -376,6 +376,36 @@ The grid is applied to the field container **inside** the form, never wrapped
around the `<form>` (which would put the whole form in cell 1 and leave the other
columns empty — #2128).

### Section styling is not authorable

`className` and `gridClassName` on a form-view **section** do nothing. Authoring
them is not an error and not a compile failure — the renderer simply does not
read them.

This is deliberate. Both keys sit on the SDUI-only side of the authorable
boundary: `@objectstack/spec` does not declare either on the form-view/section
surface, and the authorable-surface ledger carries no entry for them. The
renderer nevertheless reached them through `as any` at seven sites until
objectstack#13626 (maintainer ruling 2026-09-01) retired those reads — the
boundary had been declared on one side and crossed on the other.

Declaring the keys instead was weighed and rejected: it would invite free
Tailwind strings into authored metadata, which is the class the boundary exists
to keep out, and per ADR-0065 / ADR-0080 utility classNames in runtime metadata
are never scanned by the build-time Tailwind — so they silently produce no CSS
even when they are read. If per-view styling becomes a real product need it will
get an explicit controlled token surface rather than two leaked keys.

**What still works:** the form ROOT `className` (`FormSchema.className`) is a
different key on a different node and is unaffected; section *layout* stays
authorable through `columns` (above); and a host application styles sections
through its own CSS.

> Note for contributors: `ObjectFormSection` in `@object-ui/types` still declares
> both keys, so a plain `className: s.className` would type-check and silently
> restore consumption. The non-consumption is therefore pinned behaviourally, in
> `src/__tests__/sectionStyleKeysRetired-13626.test.tsx`, across all seven arms.

### Tabbed field layout (`fieldTabs`)

A sectioned form is **one** form. Instead of rendering a form per section — which
Expand Down

7 changes: 6 additions & 1 deletion
packages/plugin-form/src/DrawerForm.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -595,7 +595,12 @@ export const DrawerForm: React.FC<DrawerFormProps> = ({
 onToggle: section.collapsible
 ? () => setCollapsedSections(prev => ({ ...prev, [sectionKey]: !isCollapsed }))
 : undefined,
 className: (section as any).className,
 // ⛔ `className` deliberately not read — objectstack#13626, maintainer
 // ruling 2026-09-01 (batch C) "retire the reads". The key is on the
 // SDUI-only side of the authorable boundary; `ObjectForm`'s drawer map
 // stops copying it in the same pass. Full rationale at the tabbed arm
 // in `ObjectForm.tsx`; pinned by
 // `__tests__/sectionStyleKeysRetired-13626.test.tsx`.
 } as any);

 if (isCollapsed) {
Expand Down

48 changes: 38 additions & 10 deletions
packages/plugin-form/src/ObjectForm.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -290,8 +290,33 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 // compiling and silently copy `undefined` — the exact silent-drop
 // failure this line exists to fix.
 visibleWhen: s.visibleWhen,
 className: (s as any).className,
 gridClassName: (s as any).gridClassName,
 // ⛔ `className` / `gridClassName` are DELIBERATELY not copied here
 // or at any of the six sibling sites below — objectstack#13626,
 // maintainer ruling 2026-09-01 (director decision batch C):
 // "retire the reads".
 //
 // The two keys sit on the SDUI-only side of the authorable
 // boundary: `@objectstack/spec` deliberately does NOT declare them
 // on the form-view/section surface (see the "Deliberately NOT
 // declared" note in its `component.zod.ts`), and the
 // authorable-surface ledger carries no entry for them. They were
 // nevertheless reached off the parsed view through `as any` — the
 // boundary declared on one side and crossed on the other.
 //
 // Declaring them instead was weighed and NOT adopted: it would
 // formally invite free Tailwind strings into authored metadata,
 // the exact class the boundary exists to keep out — and per
 // ADR-0065 / ADR-0080 (rev. 2026-06-30) utility classNames in
 // runtime metadata are never scanned by the build-time Tailwind,
 // so they silently produce no CSS. If per-view styling becomes a
 // real product need it gets an explicit controlled token surface,
 // not two leaked keys.
 //
 // ⚠️ Re-adding the read does NOT require a cast to compile:
 // `ObjectFormSection` (this repo's own `@object-ui/types`) still
 // declares both keys, so a plain `className: s.className` type
 // -checks. The omission is therefore pinned behaviourally, not by
 // a source grep — `__tests__/sectionStyleKeysRetired-13626.test.tsx`.
 })),
 defaultTab: schema.defaultTab,
 tabPosition: schema.tabPosition,
Expand DownExpand Up@@ -322,8 +347,8 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 description: s.description,
 columns: s.columns,
 fields: s.fields,
 className: (s as any).className,
gridClassName: (s as any).gridClassName,
// `className` / `gridClassName`: deliberately not copied — see the
// tabbed arm above (objectstack#13626, ruled 2026-09-01).
 })),
 allowSkip: schema.allowSkip,
 showStepIndicator: schema.showStepIndicator,
Expand DownExpand Up@@ -356,8 +381,8 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 // ADR-0089 section predicate (#6111) — same reason as `pane` above:
 // a key this map does not copy never reaches the layout at all.
 visibleWhen: (s as any).visibleWhen,
 className: (s as any).className,
gridClassName: (s as any).gridClassName,
// `className` / `gridClassName`: deliberately not copied — see the
// tabbed arm above (objectstack#13626, ruled 2026-09-01).
 })),
 splitDirection: schema.splitDirection,
 splitSize: schema.splitSize,
Expand DownExpand Up@@ -389,7 +414,9 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 // ADR-0089 section predicate (#6111) — key-by-key rebuild, so an
 // uncopied key is silently dropped before DrawerForm ever sees it.
 visibleWhen: (s as any).visibleWhen,
 className: (s as any).className,
 // `className`: deliberately not copied — see the tabbed arm above
 // (objectstack#13626, ruled 2026-09-01). DrawerForm's own divider
 // site stops reading it in the same pass.
 })),
 open: schema.open,
 onOpenChange: schema.onOpenChange,
Expand DownExpand Up@@ -420,8 +447,8 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 // ADR-0089 section predicate (#6111) — key-by-key rebuild, so an
 // uncopied key is silently dropped before ModalForm ever sees it.
 visibleWhen: (s as any).visibleWhen,
 className: (s as any).className,
gridClassName: (s as any).gridClassName,
// `className` / `gridClassName`: deliberately not copied — see the
// tabbed arm above (objectstack#13626, ruled 2026-09-01).
 })),
 open: schema.open,
 onOpenChange: schema.onOpenChange,
Expand DownExpand Up@@ -1290,7 +1317,8 @@ const SimpleObjectForm: React.FC<ObjectFormComponentProps> = ({
 onToggle: section.collapsible
 ? () => setCollapsedSections(prev => ({ ...prev, [sectionKey]: !isCollapsed }))
 : undefined,
 className: (section as any).className,
 // `className`: deliberately not read — see the tabbed arm above
 // (objectstack#13626, ruled 2026-09-01 "retire the reads").
 } as FormField);
 }

Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
refactor(plugin-form): retire the form-view section className/gridClassName reads#7198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-support-ai
merged 3 commits into

from

Sep 1, 2026
 Merged


refactor(plugin-form): retire the form-view section className/gridClassName reads
#7198
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
e3e7ff2

refactor(plugin-form): retire the form-view section className/gridCla…


claude Sep 1, 2026
e3f2dc5

docs(plugin-form): record that section styling is not authorable, + c…


claude Sep 1, 2026
4174960

Merge origin/main into claude/issue-13626-formview-classname-reads


claude Sep 1, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


39 changes: 39 additions & 0 deletions
.changeset/13626-formview-section-style-keys-retired.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
---
'@object-ui/plugin-form': minor
---

Retire the form-view section `className` / `gridClassName` reads (objectstack#13626,
maintainer ruling 2026-09-01, director decision batch C).

**Breaking, deliberately.** A `className` or `gridClassName` authored on a form-view
section no longer has any effect. Before this change an authored `gridClassName`
reached the section's field-grid `<div>` and an authored `className` reached the
section wrapper / divider header; both are now dropped at the renderer.

The two keys sit on the SDUI-only side of the authorable boundary: `@objectstack/spec`
deliberately does not declare either on the form-view/section surface (its
`component.zod.ts` says so in as many words) and the authorable-surface ledger carries
no entry for them. The renderer nevertheless reached them off the parsed view through
`as any` at seven sites — the boundary declared on one side and crossed on the other,
with the two repos each deliberate and in opposite directions.

Declaring the keys instead was weighed and **not** adopted: it would formally invite
free Tailwind strings into authored metadata, the exact class the boundary exists to
keep out — and per ADR-0065 / ADR-0080 (rev. 2026-06-30) utility classNames in runtime
metadata are never scanned by the build-time Tailwind, so they silently produce no CSS
anyway. Declaring them would have published a styling surface whose most obvious use
does nothing. If per-view styling becomes a real product need it gets an explicit
controlled token surface, not two leaked keys.

**Migration.** Nothing in the measured corpora has to change. A census across the
objectstack corpus, this repo's corpus, and the hotcrm application found **zero**
authored uses of either key on a form-view section (201 authored section nodes reached,
0 carrying either key). If you author them in your own metadata, move the styling to
the host application's own CSS, or to the form ROOT `className` — which is a different
key on a different node and is **unaffected** by this change.

Six sites in `ObjectForm` (the tabbed / wizard / split / drawer / modal section maps and
the stacked section-divider) and one in `DrawerForm` (its own divider) stop copying the
keys. The omission is pinned behaviourally across all seven arms rather than by a source
grep, because `ObjectFormSection` still declares both keys — so a later uncast
`className: s.className` would type-check and silently restore consumption.

32 changes: 31 additions & 1 deletion
packages/plugin-form/README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -229,7 +229,7 @@ here too. Two that a reader might expect, and that are **not** declared:
| Not a `FormField` key | Write this instead |
|---|---|
| `defaultValue` | `FormSchema.defaultValues` at form level. An object-bound form seeds from the object field's own declared `defaultValue` — see [What a create form opens with](#what-a-create-form-opens-with) |
| `className` | `span` / `colSpan` for width, `FormSchema.fieldContainerClass` for the grid. (An undeclared key still rides the props spread down to whichever component the field resolves to, so a field-level `className` can visibly land on a built-in control — but nothing in the contract promises that, and a registered widget honours it only if it happens to spread its leftover props. The renderer reads it *explicitly* on exactly one pseudo-field, `type: 'section-divider'`, where it styles the inline section header.) |
| `className` | `span` / `colSpan` for width, `FormSchema.fieldContainerClass` for the grid. (An undeclared key still rides the props spread down to whichever component the field resolves to, so a field-level `className` can visibly land on a built-in control — but nothing in the contract promises that, and a registered widget honours it only if it happens to spread its leftover props. The renderer reads it *explicitly* nowhere: it used to stamp the `type: 'section-divider'` pseudo-field from an authored section's `className`, and that read was **retired** in objectstack#13626 — see [Section styling is not authorable](#section-styling-is-not-authorable).) |

There is no `ValidationRule` type in this repo, under any spelling.

Expand DownExpand Up@@ -376,6 +376,36 @@ The grid is applied to the field container **inside** the form, never wrapped
around the `<form>` (which would put the whole form in cell 1 and leave the other
columns empty — #2128).

### Section styling is not authorable

`className` and `gridClassName` on a form-view **section** do nothing. Authoring
them is not an error and not a compile failure — the renderer simply does not
read them.

This is deliberate. Both keys sit on the SDUI-only side of the authorable
boundary: `@objectstack/spec` does not declare either on the form-view/section
surface, and the authorable-surface ledger carries no entry for them. The
renderer nevertheless reached them through `as any` at seven sites until
objectstack#13626 (maintainer ruling 2026-09-01) retired those reads — the
boundary had been declared on one side and crossed on the other.

Declaring the keys instead was weighed and rejected: it would invite free
Tailwind strings into authored metadata, which is the class the boundary exists
to keep out, and per ADR-0065 / ADR-0080 utility classNames in runtime metadata
are never scanned by the build-time Tailwind — so they silently produce no CSS
even when they are read. If per-view styling becomes a real product need it will
get an explicit controlled token surface rather than two leaked keys.

**What still works:** the form ROOT `className` (`FormSchema.className`) is a
different key on a different node and is unaffected; section *layout* stays
authorable through `columns` (above); and a host application styles sections
through its own CSS.

> Note for contributors: `ObjectFormSection` in `@object-ui/types` still declares
> both keys, so a plain `className: s.className` would type-check and silently
> restore consumption. The non-consumption is therefore pinned behaviourally, in
> `src/__tests__/sectionStyleKeysRetired-13626.test.tsx`, across all seven arms.

### Tabbed field layout (`fieldTabs`)

A sectioned form is **one** form. Instead of rendering a form per section — which
Expand Down

7 changes: 6 additions & 1 deletion
packages/plugin-form/src/DrawerForm.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -595,7 +595,12 @@ export const DrawerForm: React.FC<DrawerFormProps> = ({
 onToggle: section.collapsible
 ? () => setCollapsedSections(prev => ({ ...prev, [sectionKey]: !isCollapsed }))
 : undefined,
 className: (section as any).className,
 // ⛔ `className` deliberately not read — objectstack#13626, maintainer
 // ruling 2026-09-01 (batch C) "retire the reads". The key is on the
 // SDUI-only side of the authorable boundary; `ObjectForm`'s drawer map
 // stops copying it in the same pass. Full rationale at the tabbed arm
 // in `ObjectForm.tsx`; pinned by
 // `__tests__/sectionStyleKeysRetired-13626.test.tsx`.
 } as any);

 if (isCollapsed) {
Expand Down

48 changes: 38 additions & 10 deletions
packages/plugin-form/src/ObjectForm.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -290,8 +290,33 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 // compiling and silently copy `undefined` — the exact silent-drop
 // failure this line exists to fix.
 visibleWhen: s.visibleWhen,
 className: (s as any).className,
 gridClassName: (s as any).gridClassName,
 // ⛔ `className` / `gridClassName` are DELIBERATELY not copied here
 // or at any of the six sibling sites below — objectstack#13626,
 // maintainer ruling 2026-09-01 (director decision batch C):
 // "retire the reads".
 //
 // The two keys sit on the SDUI-only side of the authorable
 // boundary: `@objectstack/spec` deliberately does NOT declare them
 // on the form-view/section surface (see the "Deliberately NOT
 // declared" note in its `component.zod.ts`), and the
 // authorable-surface ledger carries no entry for them. They were
 // nevertheless reached off the parsed view through `as any` — the
 // boundary declared on one side and crossed on the other.
 //
 // Declaring them instead was weighed and NOT adopted: it would
 // formally invite free Tailwind strings into authored metadata,
 // the exact class the boundary exists to keep out — and per
 // ADR-0065 / ADR-0080 (rev. 2026-06-30) utility classNames in
 // runtime metadata are never scanned by the build-time Tailwind,
 // so they silently produce no CSS. If per-view styling becomes a
 // real product need it gets an explicit controlled token surface,
 // not two leaked keys.
 //
 // ⚠️ Re-adding the read does NOT require a cast to compile:
 // `ObjectFormSection` (this repo's own `@object-ui/types`) still
 // declares both keys, so a plain `className: s.className` type
 // -checks. The omission is therefore pinned behaviourally, not by
 // a source grep — `__tests__/sectionStyleKeysRetired-13626.test.tsx`.
 })),
 defaultTab: schema.defaultTab,
 tabPosition: schema.tabPosition,
Expand DownExpand Up@@ -322,8 +347,8 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 description: s.description,
 columns: s.columns,
 fields: s.fields,
 className: (s as any).className,
gridClassName: (s as any).gridClassName,
// `className` / `gridClassName`: deliberately not copied — see the
// tabbed arm above (objectstack#13626, ruled 2026-09-01).
 })),
 allowSkip: schema.allowSkip,
 showStepIndicator: schema.showStepIndicator,
Expand DownExpand Up@@ -356,8 +381,8 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 // ADR-0089 section predicate (#6111) — same reason as `pane` above:
 // a key this map does not copy never reaches the layout at all.
 visibleWhen: (s as any).visibleWhen,
 className: (s as any).className,
gridClassName: (s as any).gridClassName,
// `className` / `gridClassName`: deliberately not copied — see the
// tabbed arm above (objectstack#13626, ruled 2026-09-01).
 })),
 splitDirection: schema.splitDirection,
 splitSize: schema.splitSize,
Expand DownExpand Up@@ -389,7 +414,9 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 // ADR-0089 section predicate (#6111) — key-by-key rebuild, so an
 // uncopied key is silently dropped before DrawerForm ever sees it.
 visibleWhen: (s as any).visibleWhen,
 className: (s as any).className,
 // `className`: deliberately not copied — see the tabbed arm above
 // (objectstack#13626, ruled 2026-09-01). DrawerForm's own divider
 // site stops reading it in the same pass.
 })),
 open: schema.open,
 onOpenChange: schema.onOpenChange,
Expand DownExpand Up@@ -420,8 +447,8 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 // ADR-0089 section predicate (#6111) — key-by-key rebuild, so an
 // uncopied key is silently dropped before ModalForm ever sees it.
 visibleWhen: (s as any).visibleWhen,
 className: (s as any).className,
gridClassName: (s as any).gridClassName,
// `className` / `gridClassName`: deliberately not copied — see the
// tabbed arm above (objectstack#13626, ruled 2026-09-01).
 })),
 open: schema.open,
 onOpenChange: schema.onOpenChange,
Expand DownExpand Up@@ -1290,7 +1317,8 @@ const SimpleObjectForm: React.FC<ObjectFormComponentProps> = ({
 onToggle: section.collapsible
 ? () => setCollapsedSections(prev => ({ ...prev, [sectionKey]: !isCollapsed }))
 : undefined,
 className: (section as any).className,
 // `className`: deliberately not read — see the tabbed arm above
 // (objectstack#13626, ruled 2026-09-01 "retire the reads").
 } as FormField);
 }

Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
refactor(plugin-form): retire the form-view section className/gridClassName reads#7198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-support-ai
merged 3 commits into

from

Sep 1, 2026
 Merged


refactor(plugin-form): retire the form-view section className/gridClassName reads
#7198
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
e3e7ff2

refactor(plugin-form): retire the form-view section className/gridCla…


claude Sep 1, 2026
e3f2dc5

docs(plugin-form): record that section styling is not authorable, + c…


claude Sep 1, 2026
4174960

Merge origin/main into claude/issue-13626-formview-classname-reads


claude Sep 1, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


39 changes: 39 additions & 0 deletions
.changeset/13626-formview-section-style-keys-retired.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
---
'@object-ui/plugin-form': minor
---

Retire the form-view section `className` / `gridClassName` reads (objectstack#13626,
maintainer ruling 2026-09-01, director decision batch C).

**Breaking, deliberately.** A `className` or `gridClassName` authored on a form-view
section no longer has any effect. Before this change an authored `gridClassName`
reached the section's field-grid `<div>` and an authored `className` reached the
section wrapper / divider header; both are now dropped at the renderer.

The two keys sit on the SDUI-only side of the authorable boundary: `@objectstack/spec`
deliberately does not declare either on the form-view/section surface (its
`component.zod.ts` says so in as many words) and the authorable-surface ledger carries
no entry for them. The renderer nevertheless reached them off the parsed view through
`as any` at seven sites — the boundary declared on one side and crossed on the other,
with the two repos each deliberate and in opposite directions.

Declaring the keys instead was weighed and **not** adopted: it would formally invite
free Tailwind strings into authored metadata, the exact class the boundary exists to
keep out — and per ADR-0065 / ADR-0080 (rev. 2026-06-30) utility classNames in runtime
metadata are never scanned by the build-time Tailwind, so they silently produce no CSS
anyway. Declaring them would have published a styling surface whose most obvious use
does nothing. If per-view styling becomes a real product need it gets an explicit
controlled token surface, not two leaked keys.

**Migration.** Nothing in the measured corpora has to change. A census across the
objectstack corpus, this repo's corpus, and the hotcrm application found **zero**
authored uses of either key on a form-view section (201 authored section nodes reached,
0 carrying either key). If you author them in your own metadata, move the styling to
the host application's own CSS, or to the form ROOT `className` — which is a different
key on a different node and is **unaffected** by this change.

Six sites in `ObjectForm` (the tabbed / wizard / split / drawer / modal section maps and
the stacked section-divider) and one in `DrawerForm` (its own divider) stop copying the
keys. The omission is pinned behaviourally across all seven arms rather than by a source
grep, because `ObjectFormSection` still declares both keys — so a later uncast
`className: s.className` would type-check and silently restore consumption.

32 changes: 31 additions & 1 deletion
packages/plugin-form/README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -229,7 +229,7 @@ here too. Two that a reader might expect, and that are **not** declared:
| Not a `FormField` key | Write this instead |
|---|---|
| `defaultValue` | `FormSchema.defaultValues` at form level. An object-bound form seeds from the object field's own declared `defaultValue` — see [What a create form opens with](#what-a-create-form-opens-with) |
| `className` | `span` / `colSpan` for width, `FormSchema.fieldContainerClass` for the grid. (An undeclared key still rides the props spread down to whichever component the field resolves to, so a field-level `className` can visibly land on a built-in control — but nothing in the contract promises that, and a registered widget honours it only if it happens to spread its leftover props. The renderer reads it *explicitly* on exactly one pseudo-field, `type: 'section-divider'`, where it styles the inline section header.) |
| `className` | `span` / `colSpan` for width, `FormSchema.fieldContainerClass` for the grid. (An undeclared key still rides the props spread down to whichever component the field resolves to, so a field-level `className` can visibly land on a built-in control — but nothing in the contract promises that, and a registered widget honours it only if it happens to spread its leftover props. The renderer reads it *explicitly* nowhere: it used to stamp the `type: 'section-divider'` pseudo-field from an authored section's `className`, and that read was **retired** in objectstack#13626 — see [Section styling is not authorable](#section-styling-is-not-authorable).) |

There is no `ValidationRule` type in this repo, under any spelling.

Expand DownExpand Up@@ -376,6 +376,36 @@ The grid is applied to the field container **inside** the form, never wrapped
around the `<form>` (which would put the whole form in cell 1 and leave the other
columns empty — #2128).

### Section styling is not authorable

`className` and `gridClassName` on a form-view **section** do nothing. Authoring
them is not an error and not a compile failure — the renderer simply does not
read them.

This is deliberate. Both keys sit on the SDUI-only side of the authorable
boundary: `@objectstack/spec` does not declare either on the form-view/section
surface, and the authorable-surface ledger carries no entry for them. The
renderer nevertheless reached them through `as any` at seven sites until
objectstack#13626 (maintainer ruling 2026-09-01) retired those reads — the
boundary had been declared on one side and crossed on the other.

Declaring the keys instead was weighed and rejected: it would invite free
Tailwind strings into authored metadata, which is the class the boundary exists
to keep out, and per ADR-0065 / ADR-0080 utility classNames in runtime metadata
are never scanned by the build-time Tailwind — so they silently produce no CSS
even when they are read. If per-view styling becomes a real product need it will
get an explicit controlled token surface rather than two leaked keys.

**What still works:** the form ROOT `className` (`FormSchema.className`) is a
different key on a different node and is unaffected; section *layout* stays
authorable through `columns` (above); and a host application styles sections
through its own CSS.

> Note for contributors: `ObjectFormSection` in `@object-ui/types` still declares
> both keys, so a plain `className: s.className` would type-check and silently
> restore consumption. The non-consumption is therefore pinned behaviourally, in
> `src/__tests__/sectionStyleKeysRetired-13626.test.tsx`, across all seven arms.

### Tabbed field layout (`fieldTabs`)

A sectioned form is **one** form. Instead of rendering a form per section — which
Expand Down

7 changes: 6 additions & 1 deletion
packages/plugin-form/src/DrawerForm.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -595,7 +595,12 @@ export const DrawerForm: React.FC<DrawerFormProps> = ({
 onToggle: section.collapsible
 ? () => setCollapsedSections(prev => ({ ...prev, [sectionKey]: !isCollapsed }))
 : undefined,
 className: (section as any).className,
 // ⛔ `className` deliberately not read — objectstack#13626, maintainer
 // ruling 2026-09-01 (batch C) "retire the reads". The key is on the
 // SDUI-only side of the authorable boundary; `ObjectForm`'s drawer map
 // stops copying it in the same pass. Full rationale at the tabbed arm
 // in `ObjectForm.tsx`; pinned by
 // `__tests__/sectionStyleKeysRetired-13626.test.tsx`.
 } as any);

 if (isCollapsed) {
Expand Down

48 changes: 38 additions & 10 deletions
packages/plugin-form/src/ObjectForm.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -290,8 +290,33 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 // compiling and silently copy `undefined` — the exact silent-drop
 // failure this line exists to fix.
 visibleWhen: s.visibleWhen,
 className: (s as any).className,
 gridClassName: (s as any).gridClassName,
 // ⛔ `className` / `gridClassName` are DELIBERATELY not copied here
 // or at any of the six sibling sites below — objectstack#13626,
 // maintainer ruling 2026-09-01 (director decision batch C):
 // "retire the reads".
 //
 // The two keys sit on the SDUI-only side of the authorable
 // boundary: `@objectstack/spec` deliberately does NOT declare them
 // on the form-view/section surface (see the "Deliberately NOT
 // declared" note in its `component.zod.ts`), and the
 // authorable-surface ledger carries no entry for them. They were
 // nevertheless reached off the parsed view through `as any` — the
 // boundary declared on one side and crossed on the other.
 //
 // Declaring them instead was weighed and NOT adopted: it would
 // formally invite free Tailwind strings into authored metadata,
 // the exact class the boundary exists to keep out — and per
 // ADR-0065 / ADR-0080 (rev. 2026-06-30) utility classNames in
 // runtime metadata are never scanned by the build-time Tailwind,
 // so they silently produce no CSS. If per-view styling becomes a
 // real product need it gets an explicit controlled token surface,
 // not two leaked keys.
 //
 // ⚠️ Re-adding the read does NOT require a cast to compile:
 // `ObjectFormSection` (this repo's own `@object-ui/types`) still
 // declares both keys, so a plain `className: s.className` type
 // -checks. The omission is therefore pinned behaviourally, not by
 // a source grep — `__tests__/sectionStyleKeysRetired-13626.test.tsx`.
 })),
 defaultTab: schema.defaultTab,
 tabPosition: schema.tabPosition,
Expand DownExpand Up@@ -322,8 +347,8 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 description: s.description,
 columns: s.columns,
 fields: s.fields,
 className: (s as any).className,
gridClassName: (s as any).gridClassName,
// `className` / `gridClassName`: deliberately not copied — see the
// tabbed arm above (objectstack#13626, ruled 2026-09-01).
 })),
 allowSkip: schema.allowSkip,
 showStepIndicator: schema.showStepIndicator,
Expand DownExpand Up@@ -356,8 +381,8 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 // ADR-0089 section predicate (#6111) — same reason as `pane` above:
 // a key this map does not copy never reaches the layout at all.
 visibleWhen: (s as any).visibleWhen,
 className: (s as any).className,
gridClassName: (s as any).gridClassName,
// `className` / `gridClassName`: deliberately not copied — see the
// tabbed arm above (objectstack#13626, ruled 2026-09-01).
 })),
 splitDirection: schema.splitDirection,
 splitSize: schema.splitSize,
Expand DownExpand Up@@ -389,7 +414,9 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 // ADR-0089 section predicate (#6111) — key-by-key rebuild, so an
 // uncopied key is silently dropped before DrawerForm ever sees it.
 visibleWhen: (s as any).visibleWhen,
 className: (s as any).className,
 // `className`: deliberately not copied — see the tabbed arm above
 // (objectstack#13626, ruled 2026-09-01). DrawerForm's own divider
 // site stops reading it in the same pass.
 })),
 open: schema.open,
 onOpenChange: schema.onOpenChange,
Expand DownExpand Up@@ -420,8 +447,8 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 // ADR-0089 section predicate (#6111) — key-by-key rebuild, so an
 // uncopied key is silently dropped before ModalForm ever sees it.
 visibleWhen: (s as any).visibleWhen,
 className: (s as any).className,
gridClassName: (s as any).gridClassName,
// `className` / `gridClassName`: deliberately not copied — see the
// tabbed arm above (objectstack#13626, ruled 2026-09-01).
 })),
 open: schema.open,
 onOpenChange: schema.onOpenChange,
Expand DownExpand Up@@ -1290,7 +1317,8 @@ const SimpleObjectForm: React.FC<ObjectFormComponentProps> = ({
 onToggle: section.collapsible
 ? () => setCollapsedSections(prev => ({ ...prev, [sectionKey]: !isCollapsed }))
 : undefined,
 className: (section as any).className,
 // `className`: deliberately not read — see the tabbed arm above
 // (objectstack#13626, ruled 2026-09-01 "retire the reads").
 } as FormField);
 }

Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
refactor(plugin-form): retire the form-view section className/gridClassName reads#7198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-support-ai
merged 3 commits into

from

Sep 1, 2026
 Merged


refactor(plugin-form): retire the form-view section className/gridClassName reads
#7198
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
e3e7ff2

refactor(plugin-form): retire the form-view section className/gridCla…


claude Sep 1, 2026
e3f2dc5

docs(plugin-form): record that section styling is not authorable, + c…


claude Sep 1, 2026
4174960

Merge origin/main into claude/issue-13626-formview-classname-reads


claude Sep 1, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


39 changes: 39 additions & 0 deletions
.changeset/13626-formview-section-style-keys-retired.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
---
'@object-ui/plugin-form': minor
---

Retire the form-view section `className` / `gridClassName` reads (objectstack#13626,
maintainer ruling 2026-09-01, director decision batch C).

**Breaking, deliberately.** A `className` or `gridClassName` authored on a form-view
section no longer has any effect. Before this change an authored `gridClassName`
reached the section's field-grid `<div>` and an authored `className` reached the
section wrapper / divider header; both are now dropped at the renderer.

The two keys sit on the SDUI-only side of the authorable boundary: `@objectstack/spec`
deliberately does not declare either on the form-view/section surface (its
`component.zod.ts` says so in as many words) and the authorable-surface ledger carries
no entry for them. The renderer nevertheless reached them off the parsed view through
`as any` at seven sites — the boundary declared on one side and crossed on the other,
with the two repos each deliberate and in opposite directions.

Declaring the keys instead was weighed and **not** adopted: it would formally invite
free Tailwind strings into authored metadata, the exact class the boundary exists to
keep out — and per ADR-0065 / ADR-0080 (rev. 2026-06-30) utility classNames in runtime
metadata are never scanned by the build-time Tailwind, so they silently produce no CSS
anyway. Declaring them would have published a styling surface whose most obvious use
does nothing. If per-view styling becomes a real product need it gets an explicit
controlled token surface, not two leaked keys.

**Migration.** Nothing in the measured corpora has to change. A census across the
objectstack corpus, this repo's corpus, and the hotcrm application found **zero**
authored uses of either key on a form-view section (201 authored section nodes reached,
0 carrying either key). If you author them in your own metadata, move the styling to
the host application's own CSS, or to the form ROOT `className` — which is a different
key on a different node and is **unaffected** by this change.

Six sites in `ObjectForm` (the tabbed / wizard / split / drawer / modal section maps and
the stacked section-divider) and one in `DrawerForm` (its own divider) stop copying the
keys. The omission is pinned behaviourally across all seven arms rather than by a source
grep, because `ObjectFormSection` still declares both keys — so a later uncast
`className: s.className` would type-check and silently restore consumption.

32 changes: 31 additions & 1 deletion
packages/plugin-form/README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -229,7 +229,7 @@ here too. Two that a reader might expect, and that are **not** declared:
| Not a `FormField` key | Write this instead |
|---|---|
| `defaultValue` | `FormSchema.defaultValues` at form level. An object-bound form seeds from the object field's own declared `defaultValue` — see [What a create form opens with](#what-a-create-form-opens-with) |
| `className` | `span` / `colSpan` for width, `FormSchema.fieldContainerClass` for the grid. (An undeclared key still rides the props spread down to whichever component the field resolves to, so a field-level `className` can visibly land on a built-in control — but nothing in the contract promises that, and a registered widget honours it only if it happens to spread its leftover props. The renderer reads it *explicitly* on exactly one pseudo-field, `type: 'section-divider'`, where it styles the inline section header.) |
| `className` | `span` / `colSpan` for width, `FormSchema.fieldContainerClass` for the grid. (An undeclared key still rides the props spread down to whichever component the field resolves to, so a field-level `className` can visibly land on a built-in control — but nothing in the contract promises that, and a registered widget honours it only if it happens to spread its leftover props. The renderer reads it *explicitly* nowhere: it used to stamp the `type: 'section-divider'` pseudo-field from an authored section's `className`, and that read was **retired** in objectstack#13626 — see [Section styling is not authorable](#section-styling-is-not-authorable).) |

There is no `ValidationRule` type in this repo, under any spelling.

Expand DownExpand Up@@ -376,6 +376,36 @@ The grid is applied to the field container **inside** the form, never wrapped
around the `<form>` (which would put the whole form in cell 1 and leave the other
columns empty — #2128).

### Section styling is not authorable

`className` and `gridClassName` on a form-view **section** do nothing. Authoring
them is not an error and not a compile failure — the renderer simply does not
read them.

This is deliberate. Both keys sit on the SDUI-only side of the authorable
boundary: `@objectstack/spec` does not declare either on the form-view/section
surface, and the authorable-surface ledger carries no entry for them. The
renderer nevertheless reached them through `as any` at seven sites until
objectstack#13626 (maintainer ruling 2026-09-01) retired those reads — the
boundary had been declared on one side and crossed on the other.

Declaring the keys instead was weighed and rejected: it would invite free
Tailwind strings into authored metadata, which is the class the boundary exists
to keep out, and per ADR-0065 / ADR-0080 utility classNames in runtime metadata
are never scanned by the build-time Tailwind — so they silently produce no CSS
even when they are read. If per-view styling becomes a real product need it will
get an explicit controlled token surface rather than two leaked keys.

**What still works:** the form ROOT `className` (`FormSchema.className`) is a
different key on a different node and is unaffected; section *layout* stays
authorable through `columns` (above); and a host application styles sections
through its own CSS.

> Note for contributors: `ObjectFormSection` in `@object-ui/types` still declares
> both keys, so a plain `className: s.className` would type-check and silently
> restore consumption. The non-consumption is therefore pinned behaviourally, in
> `src/__tests__/sectionStyleKeysRetired-13626.test.tsx`, across all seven arms.

### Tabbed field layout (`fieldTabs`)

A sectioned form is **one** form. Instead of rendering a form per section — which
Expand Down

7 changes: 6 additions & 1 deletion
packages/plugin-form/src/DrawerForm.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -595,7 +595,12 @@ export const DrawerForm: React.FC<DrawerFormProps> = ({
 onToggle: section.collapsible
 ? () => setCollapsedSections(prev => ({ ...prev, [sectionKey]: !isCollapsed }))
 : undefined,
 className: (section as any).className,
 // ⛔ `className` deliberately not read — objectstack#13626, maintainer
 // ruling 2026-09-01 (batch C) "retire the reads". The key is on the
 // SDUI-only side of the authorable boundary; `ObjectForm`'s drawer map
 // stops copying it in the same pass. Full rationale at the tabbed arm
 // in `ObjectForm.tsx`; pinned by
 // `__tests__/sectionStyleKeysRetired-13626.test.tsx`.
 } as any);

 if (isCollapsed) {
Expand Down

48 changes: 38 additions & 10 deletions
packages/plugin-form/src/ObjectForm.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -290,8 +290,33 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 // compiling and silently copy `undefined` — the exact silent-drop
 // failure this line exists to fix.
 visibleWhen: s.visibleWhen,
 className: (s as any).className,
 gridClassName: (s as any).gridClassName,
 // ⛔ `className` / `gridClassName` are DELIBERATELY not copied here
 // or at any of the six sibling sites below — objectstack#13626,
 // maintainer ruling 2026-09-01 (director decision batch C):
 // "retire the reads".
 //
 // The two keys sit on the SDUI-only side of the authorable
 // boundary: `@objectstack/spec` deliberately does NOT declare them
 // on the form-view/section surface (see the "Deliberately NOT
 // declared" note in its `component.zod.ts`), and the
 // authorable-surface ledger carries no entry for them. They were
 // nevertheless reached off the parsed view through `as any` — the
 // boundary declared on one side and crossed on the other.
 //
 // Declaring them instead was weighed and NOT adopted: it would
 // formally invite free Tailwind strings into authored metadata,
 // the exact class the boundary exists to keep out — and per
 // ADR-0065 / ADR-0080 (rev. 2026-06-30) utility classNames in
 // runtime metadata are never scanned by the build-time Tailwind,
 // so they silently produce no CSS. If per-view styling becomes a
 // real product need it gets an explicit controlled token surface,
 // not two leaked keys.
 //
 // ⚠️ Re-adding the read does NOT require a cast to compile:
 // `ObjectFormSection` (this repo's own `@object-ui/types`) still
 // declares both keys, so a plain `className: s.className` type
 // -checks. The omission is therefore pinned behaviourally, not by
 // a source grep — `__tests__/sectionStyleKeysRetired-13626.test.tsx`.
 })),
 defaultTab: schema.defaultTab,
 tabPosition: schema.tabPosition,
Expand DownExpand Up@@ -322,8 +347,8 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 description: s.description,
 columns: s.columns,
 fields: s.fields,
 className: (s as any).className,
gridClassName: (s as any).gridClassName,
// `className` / `gridClassName`: deliberately not copied — see the
// tabbed arm above (objectstack#13626, ruled 2026-09-01).
 })),
 allowSkip: schema.allowSkip,
 showStepIndicator: schema.showStepIndicator,
Expand DownExpand Up@@ -356,8 +381,8 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 // ADR-0089 section predicate (#6111) — same reason as `pane` above:
 // a key this map does not copy never reaches the layout at all.
 visibleWhen: (s as any).visibleWhen,
 className: (s as any).className,
gridClassName: (s as any).gridClassName,
// `className` / `gridClassName`: deliberately not copied — see the
// tabbed arm above (objectstack#13626, ruled 2026-09-01).
 })),
 splitDirection: schema.splitDirection,
 splitSize: schema.splitSize,
Expand DownExpand Up@@ -389,7 +414,9 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 // ADR-0089 section predicate (#6111) — key-by-key rebuild, so an
 // uncopied key is silently dropped before DrawerForm ever sees it.
 visibleWhen: (s as any).visibleWhen,
 className: (s as any).className,
 // `className`: deliberately not copied — see the tabbed arm above
 // (objectstack#13626, ruled 2026-09-01). DrawerForm's own divider
 // site stops reading it in the same pass.
 })),
 open: schema.open,
 onOpenChange: schema.onOpenChange,
Expand DownExpand Up@@ -420,8 +447,8 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 // ADR-0089 section predicate (#6111) — key-by-key rebuild, so an
 // uncopied key is silently dropped before ModalForm ever sees it.
 visibleWhen: (s as any).visibleWhen,
 className: (s as any).className,
gridClassName: (s as any).gridClassName,
// `className` / `gridClassName`: deliberately not copied — see the
// tabbed arm above (objectstack#13626, ruled 2026-09-01).
 })),
 open: schema.open,
 onOpenChange: schema.onOpenChange,
Expand DownExpand Up@@ -1290,7 +1317,8 @@ const SimpleObjectForm: React.FC<ObjectFormComponentProps> = ({
 onToggle: section.collapsible
 ? () => setCollapsedSections(prev => ({ ...prev, [sectionKey]: !isCollapsed }))
 : undefined,
 className: (section as any).className,
 // `className`: deliberately not read — see the tabbed arm above
 // (objectstack#13626, ruled 2026-09-01 "retire the reads").
 } as FormField);
 }

Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
refactor(plugin-form): retire the form-view section className/gridClassName reads#7198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-support-ai
merged 3 commits into

from

Sep 1, 2026
 Merged


refactor(plugin-form): retire the form-view section className/gridClassName reads
#7198
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
e3e7ff2

refactor(plugin-form): retire the form-view section className/gridCla…


claude Sep 1, 2026
e3f2dc5

docs(plugin-form): record that section styling is not authorable, + c…


claude Sep 1, 2026
4174960

Merge origin/main into claude/issue-13626-formview-classname-reads


claude Sep 1, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


39 changes: 39 additions & 0 deletions
.changeset/13626-formview-section-style-keys-retired.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
---
'@object-ui/plugin-form': minor
---

Retire the form-view section `className` / `gridClassName` reads (objectstack#13626,
maintainer ruling 2026-09-01, director decision batch C).

**Breaking, deliberately.** A `className` or `gridClassName` authored on a form-view
section no longer has any effect. Before this change an authored `gridClassName`
reached the section's field-grid `<div>` and an authored `className` reached the
section wrapper / divider header; both are now dropped at the renderer.

The two keys sit on the SDUI-only side of the authorable boundary: `@objectstack/spec`
deliberately does not declare either on the form-view/section surface (its
`component.zod.ts` says so in as many words) and the authorable-surface ledger carries
no entry for them. The renderer nevertheless reached them off the parsed view through
`as any` at seven sites — the boundary declared on one side and crossed on the other,
with the two repos each deliberate and in opposite directions.

Declaring the keys instead was weighed and **not** adopted: it would formally invite
free Tailwind strings into authored metadata, the exact class the boundary exists to
keep out — and per ADR-0065 / ADR-0080 (rev. 2026-06-30) utility classNames in runtime
metadata are never scanned by the build-time Tailwind, so they silently produce no CSS
anyway. Declaring them would have published a styling surface whose most obvious use
does nothing. If per-view styling becomes a real product need it gets an explicit
controlled token surface, not two leaked keys.

**Migration.** Nothing in the measured corpora has to change. A census across the
objectstack corpus, this repo's corpus, and the hotcrm application found **zero**
authored uses of either key on a form-view section (201 authored section nodes reached,
0 carrying either key). If you author them in your own metadata, move the styling to
the host application's own CSS, or to the form ROOT `className` — which is a different
key on a different node and is **unaffected** by this change.

Six sites in `ObjectForm` (the tabbed / wizard / split / drawer / modal section maps and
the stacked section-divider) and one in `DrawerForm` (its own divider) stop copying the
keys. The omission is pinned behaviourally across all seven arms rather than by a source
grep, because `ObjectFormSection` still declares both keys — so a later uncast
`className: s.className` would type-check and silently restore consumption.

32 changes: 31 additions & 1 deletion
packages/plugin-form/README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -229,7 +229,7 @@ here too. Two that a reader might expect, and that are **not** declared:
| Not a `FormField` key | Write this instead |
|---|---|
| `defaultValue` | `FormSchema.defaultValues` at form level. An object-bound form seeds from the object field's own declared `defaultValue` — see [What a create form opens with](#what-a-create-form-opens-with) |
| `className` | `span` / `colSpan` for width, `FormSchema.fieldContainerClass` for the grid. (An undeclared key still rides the props spread down to whichever component the field resolves to, so a field-level `className` can visibly land on a built-in control — but nothing in the contract promises that, and a registered widget honours it only if it happens to spread its leftover props. The renderer reads it *explicitly* on exactly one pseudo-field, `type: 'section-divider'`, where it styles the inline section header.) |
| `className` | `span` / `colSpan` for width, `FormSchema.fieldContainerClass` for the grid. (An undeclared key still rides the props spread down to whichever component the field resolves to, so a field-level `className` can visibly land on a built-in control — but nothing in the contract promises that, and a registered widget honours it only if it happens to spread its leftover props. The renderer reads it *explicitly* nowhere: it used to stamp the `type: 'section-divider'` pseudo-field from an authored section's `className`, and that read was **retired** in objectstack#13626 — see [Section styling is not authorable](#section-styling-is-not-authorable).) |

There is no `ValidationRule` type in this repo, under any spelling.

Expand DownExpand Up@@ -376,6 +376,36 @@ The grid is applied to the field container **inside** the form, never wrapped
around the `<form>` (which would put the whole form in cell 1 and leave the other
columns empty — #2128).

### Section styling is not authorable

`className` and `gridClassName` on a form-view **section** do nothing. Authoring
them is not an error and not a compile failure — the renderer simply does not
read them.

This is deliberate. Both keys sit on the SDUI-only side of the authorable
boundary: `@objectstack/spec` does not declare either on the form-view/section
surface, and the authorable-surface ledger carries no entry for them. The
renderer nevertheless reached them through `as any` at seven sites until
objectstack#13626 (maintainer ruling 2026-09-01) retired those reads — the
boundary had been declared on one side and crossed on the other.

Declaring the keys instead was weighed and rejected: it would invite free
Tailwind strings into authored metadata, which is the class the boundary exists
to keep out, and per ADR-0065 / ADR-0080 utility classNames in runtime metadata
are never scanned by the build-time Tailwind — so they silently produce no CSS
even when they are read. If per-view styling becomes a real product need it will
get an explicit controlled token surface rather than two leaked keys.

**What still works:** the form ROOT `className` (`FormSchema.className`) is a
different key on a different node and is unaffected; section *layout* stays
authorable through `columns` (above); and a host application styles sections
through its own CSS.

> Note for contributors: `ObjectFormSection` in `@object-ui/types` still declares
> both keys, so a plain `className: s.className` would type-check and silently
> restore consumption. The non-consumption is therefore pinned behaviourally, in
> `src/__tests__/sectionStyleKeysRetired-13626.test.tsx`, across all seven arms.

### Tabbed field layout (`fieldTabs`)

A sectioned form is **one** form. Instead of rendering a form per section — which
Expand Down

7 changes: 6 additions & 1 deletion
packages/plugin-form/src/DrawerForm.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -595,7 +595,12 @@ export const DrawerForm: React.FC<DrawerFormProps> = ({
 onToggle: section.collapsible
 ? () => setCollapsedSections(prev => ({ ...prev, [sectionKey]: !isCollapsed }))
 : undefined,
 className: (section as any).className,
 // ⛔ `className` deliberately not read — objectstack#13626, maintainer
 // ruling 2026-09-01 (batch C) "retire the reads". The key is on the
 // SDUI-only side of the authorable boundary; `ObjectForm`'s drawer map
 // stops copying it in the same pass. Full rationale at the tabbed arm
 // in `ObjectForm.tsx`; pinned by
 // `__tests__/sectionStyleKeysRetired-13626.test.tsx`.
 } as any);

 if (isCollapsed) {
Expand Down

48 changes: 38 additions & 10 deletions
packages/plugin-form/src/ObjectForm.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -290,8 +290,33 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 // compiling and silently copy `undefined` — the exact silent-drop
 // failure this line exists to fix.
 visibleWhen: s.visibleWhen,
 className: (s as any).className,
 gridClassName: (s as any).gridClassName,
 // ⛔ `className` / `gridClassName` are DELIBERATELY not copied here
 // or at any of the six sibling sites below — objectstack#13626,
 // maintainer ruling 2026-09-01 (director decision batch C):
 // "retire the reads".
 //
 // The two keys sit on the SDUI-only side of the authorable
 // boundary: `@objectstack/spec` deliberately does NOT declare them
 // on the form-view/section surface (see the "Deliberately NOT
 // declared" note in its `component.zod.ts`), and the
 // authorable-surface ledger carries no entry for them. They were
 // nevertheless reached off the parsed view through `as any` — the
 // boundary declared on one side and crossed on the other.
 //
 // Declaring them instead was weighed and NOT adopted: it would
 // formally invite free Tailwind strings into authored metadata,
 // the exact class the boundary exists to keep out — and per
 // ADR-0065 / ADR-0080 (rev. 2026-06-30) utility classNames in
 // runtime metadata are never scanned by the build-time Tailwind,
 // so they silently produce no CSS. If per-view styling becomes a
 // real product need it gets an explicit controlled token surface,
 // not two leaked keys.
 //
 // ⚠️ Re-adding the read does NOT require a cast to compile:
 // `ObjectFormSection` (this repo's own `@object-ui/types`) still
 // declares both keys, so a plain `className: s.className` type
 // -checks. The omission is therefore pinned behaviourally, not by
 // a source grep — `__tests__/sectionStyleKeysRetired-13626.test.tsx`.
 })),
 defaultTab: schema.defaultTab,
 tabPosition: schema.tabPosition,
Expand DownExpand Up@@ -322,8 +347,8 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 description: s.description,
 columns: s.columns,
 fields: s.fields,
 className: (s as any).className,
gridClassName: (s as any).gridClassName,
// `className` / `gridClassName`: deliberately not copied — see the
// tabbed arm above (objectstack#13626, ruled 2026-09-01).
 })),
 allowSkip: schema.allowSkip,
 showStepIndicator: schema.showStepIndicator,
Expand DownExpand Up@@ -356,8 +381,8 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 // ADR-0089 section predicate (#6111) — same reason as `pane` above:
 // a key this map does not copy never reaches the layout at all.
 visibleWhen: (s as any).visibleWhen,
 className: (s as any).className,
gridClassName: (s as any).gridClassName,
// `className` / `gridClassName`: deliberately not copied — see the
// tabbed arm above (objectstack#13626, ruled 2026-09-01).
 })),
 splitDirection: schema.splitDirection,
 splitSize: schema.splitSize,
Expand DownExpand Up@@ -389,7 +414,9 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 // ADR-0089 section predicate (#6111) — key-by-key rebuild, so an
 // uncopied key is silently dropped before DrawerForm ever sees it.
 visibleWhen: (s as any).visibleWhen,
 className: (s as any).className,
 // `className`: deliberately not copied — see the tabbed arm above
 // (objectstack#13626, ruled 2026-09-01). DrawerForm's own divider
 // site stops reading it in the same pass.
 })),
 open: schema.open,
 onOpenChange: schema.onOpenChange,
Expand DownExpand Up@@ -420,8 +447,8 @@ export const ObjectForm: React.FC<ObjectFormComponentProps> = ({
 // ADR-0089 section predicate (#6111) — key-by-key rebuild, so an
 // uncopied key is silently dropped before ModalForm ever sees it.
 visibleWhen: (s as any).visibleWhen,
 className: (s as any).className,
gridClassName: (s as any).gridClassName,
// `className` / `gridClassName`: deliberately not copied — see the
// tabbed arm above (objectstack#13626, ruled 2026-09-01).
 })),
 open: schema.open,
 onOpenChange: schema.onOpenChange,
Expand DownExpand Up@@ -1290,7 +1317,8 @@ const SimpleObjectForm: React.FC<ObjectFormComponentProps> = ({
 onToggle: section.collapsible
 ? () => setCollapsedSections(prev => ({ ...prev, [sectionKey]: !isCollapsed }))
 : undefined,
 className: (section as any).className,
 // `className`: deliberately not read — see the tabbed arm above
 // (objectstack#13626, ruled 2026-09-01 "retire the reads").
 } as FormField);
 }

Expand Down
Loading
Loading