test(console): take the app-shell barrel out of three vi.mock factories (#6580)#7315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yinlianghui merged 1 commit into from
Sep 2, 2026
Merged

test(console): take the app-shell barrel out of three vi.mock factories (#6580) #7315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/six-donkeys-shake.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
---
---

Test-only change to three `apps/console` test files: the `vi.mock('@object-ui/app-shell', …)`
factories no longer call `importOriginal()`, which was transforming the whole source-aliased
barrel graph (measured 10019 ms per file) to reach a handful of real exports. They now spread
only the app-shell submodules those exports live in. No published behaviour changes.
37 changes: 26 additions & 11 deletions apps/console/src/components/FormPage.predicateScope.test.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -73,14 +73,16 @@ import { FormPage } from './FormPage';
*
* This module's graph is the first VALUE request for `@object-ui/app-shell` in
* the file (`FormPage` only `import type`s it), so it is what runs the
* `vi.mock('@object-ui/app-shell')` factory's `importOriginal()` below — and
* that specifier is aliased to `packages/app-shell/src`
* (`apps/console/vite.config.ts`), a barrel carrying eight side-effect imports,
* transformed on demand. Measured on an IDLE machine it cost **10204ms** of
* `hop1SessionPrincipal`'s 15000ms budget; the render and the assertions cost
* ~12ms, the same as the seven cases above. Nothing was wrong with the test —
* it was racing the module loader, and lost whenever the transform pipeline was
* saturated by a full-project run.
* `vi.mock('@object-ui/app-shell')` factory below — and that specifier is
* aliased to `packages/app-shell/src` (`apps/console/vite.config.ts`), a barrel
* carrying thirteen side-effect imports, transformed on demand. While that
* factory still called `importOriginal()` the load cost **10204ms** of
* `hop1SessionPrincipal`'s 15000ms budget on an IDLE machine, against ~12ms for
* the render and the assertions. Nothing was wrong with the test — it was
* racing the module loader, and lost whenever the transform pipeline was
* saturated by a full-project run. objectui#6580 took the barrel out of the
* factory; the module-scope import below is what keeps the remaining load out
* of a bounded window.
*
* Module scope moves that cost into the IMPORT phase, which no test or hook
* timeout bounds. `beforeAll` would not do: it is bounded by `hookTimeout`
Expand DownExpand Up@@ -342,10 +344,23 @@ describe('#6110 controls — green before AND after the fix, by construction', (
* `vi.mock` calls are hoisted above every import in the file, so the factories
* are registered before that import executes.
*/
vi.mock('@object-ui/app-shell', async (importOriginal) => {
const actual = await importOriginal<Record<string, unknown>>();
// The barrel is aliased to `packages/app-shell/src`, so an `importOriginal()`
// on it transforms that whole graph on demand — 10204ms when objectui#6567
// instrumented it, 10019ms re-measured for objectui#6580. The three submodules
// below carry every name this file's graph reads from the barrel and cost a few
// ms together: `ExpressionProvider`, `buildExpressionUser` (`expressionUser`)
// and `resolveHostAppSegment` (`utils/`).
vi.mock('@object-ui/app-shell', async () => {
return {
...actual,
...(await vi.importActual<Record<string, unknown>>(
'../../../../packages/app-shell/src/providers/ExpressionProvider'
)),
...(await vi.importActual<Record<string, unknown>>(
'../../../../packages/app-shell/src/providers/expressionUser'
)),
...(await vi.importActual<Record<string, unknown>>(
'../../../../packages/app-shell/src/utils/index'
)),
useMetadata: () => ({ apps: [] }),
useNavigationContext: () => ({ currentAppName: undefined }),
DefaultHomeLayout: ({ children }: { children?: unknown }) => children as never,
Expand Down
22 changes: 20 additions & 2 deletions apps/console/src/components/SetupRoute.test.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -68,8 +68,26 @@ vi.mock('../../../../packages/app-shell/src/providers/MetadataProvider', async (
useMetadata: () => ({ apps, objects: [], loading: false, error: null, refresh: async () => {} }),
}));

vi.mock('@object-ui/app-shell', async (importOriginal) => ({
...(await importOriginal<Record<string, unknown>>()),
// `@object-ui/app-shell` is aliased to `packages/app-shell/src`
// (`apps/console/vite.config.ts`), so an `importOriginal()` on it transforms the
// whole barrel graph on demand — measured on this tree at **10019ms**
// (objectui#6580). The three submodules below carry every name this file's graph
// reads from the barrel and cost ~2.0s together: `chrome/` has
// `RedirectWithSplash`, `console/ConsoleShell` has `SetupRedirect`,
// `SETUP_APP_PACKAGE_ID` and `SETUP_APP_NAME`.
vi.mock('@object-ui/app-shell', async () => ({
...(await vi.importActual<Record<string, unknown>>(
'../../../../packages/app-shell/src/chrome/index'
)),
...(await vi.importActual<Record<string, unknown>>(
'../../../../packages/app-shell/src/console/ConsoleShell'
)),
// `RootLandingRedirect` reads `useMetadata` through the BARREL, so the
// provider mock above — which only reaches importers of the provider module
// itself — does not cover it. The whole-barrel spread this factory used to do
// covered it by re-exporting the already-mocked provider; spelling the same
// stub out here keeps that, and is why the two must stay in step.
useMetadata: () => ({ apps, objects: [], loading: false, error: null, refresh: async () => {} }),
// Pass-through: the provider stack is not what decides this question.
ConnectedShell: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
RequireOrganization: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
Expand Down
14 changes: 12 additions & 2 deletions apps/console/src/components/StudioRoute.test.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -90,8 +90,18 @@ vi.mock('../../../../packages/auth/src/useAuth', async (importOriginal) => ({
const builderLanding = vi.fn();
const designSurface = vi.fn();

vi.mock('@object-ui/app-shell', async (importOriginal) => ({
...(await importOriginal<Record<string, unknown>>()),
// `@object-ui/app-shell` is aliased to `packages/app-shell/src`
// (`apps/console/vite.config.ts`), so an `importOriginal()` on it transforms the
// whole barrel graph on demand: measured on this tree at **10019ms**, against
// 237ms for `@object-ui/auth` in this same file (objectui#6580). Every name this
// file's graph reads from the barrel is either overridden below or lives in
// `chrome/`, so the factory pulls that ONE submodule (**549ms**) instead.
// `RedirectWithSplash` is the only real export left standing: `ProtectedRoute`
// renders it for the unauthenticated case, which this file asserts.
vi.mock('@object-ui/app-shell', async () => ({
...(await vi.importActual<Record<string, unknown>>(
'../../../../packages/app-shell/src/chrome/index'
)),
// Pass-through: the provider stack is not what decides this question.
ConnectedShell: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
RequireOrganization: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
test(console): take the app-shell barrel out of three vi.mock factories (#6580)#7315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

yinlianghui
merged 1 commit into

from

Sep 2, 2026
 Merged


test(console): take the app-shell barrel out of three vi.mock factories (#6580)
#7315
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


7 changes: 7 additions & 0 deletions
.changeset/six-donkeys-shake.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
---
---

Test-only change to three `apps/console` test files: the `vi.mock('@object-ui/app-shell', …)`
factories no longer call `importOriginal()`, which was transforming the whole source-aliased
barrel graph (measured 10019 ms per file) to reach a handful of real exports. They now spread
only the app-shell submodules those exports live in. No published behaviour changes.

37 changes: 26 additions & 11 deletions
apps/console/src/components/FormPage.predicateScope.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -73,14 +73,16 @@ import { FormPage } from './FormPage';
 *
 * This module's graph is the first VALUE request for `@object-ui/app-shell` in
 * the file (`FormPage` only `import type`s it), so it is what runs the
 * `vi.mock('@object-ui/app-shell')` factory's `importOriginal()` below — and
 * that specifier is aliased to `packages/app-shell/src`
 * (`apps/console/vite.config.ts`), a barrel carrying eight side-effect imports,
 * transformed on demand. Measured on an IDLE machine it cost **10204ms** of
 * `hop1SessionPrincipal`'s 15000ms budget; the render and the assertions cost
 * ~12ms, the same as the seven cases above. Nothing was wrong with the test —
 * it was racing the module loader, and lost whenever the transform pipeline was
 * saturated by a full-project run.
 * `vi.mock('@object-ui/app-shell')` factory below — and that specifier is
 * aliased to `packages/app-shell/src` (`apps/console/vite.config.ts`), a barrel
 * carrying thirteen side-effect imports, transformed on demand. While that
 * factory still called `importOriginal()` the load cost **10204ms** of
 * `hop1SessionPrincipal`'s 15000ms budget on an IDLE machine, against ~12ms for
 * the render and the assertions. Nothing was wrong with the test — it was
 * racing the module loader, and lost whenever the transform pipeline was
 * saturated by a full-project run. objectui#6580 took the barrel out of the
 * factory; the module-scope import below is what keeps the remaining load out
 * of a bounded window.
 *
 * Module scope moves that cost into the IMPORT phase, which no test or hook
 * timeout bounds. `beforeAll` would not do: it is bounded by `hookTimeout`
Expand DownExpand Up@@ -342,10 +344,23 @@ describe('#6110 controls — green before AND after the fix, by construction', (
 * `vi.mock` calls are hoisted above every import in the file, so the factories
 * are registered before that import executes.
 */
vi.mock('@object-ui/app-shell', async (importOriginal) => {
 const actual = await importOriginal<Record<string, unknown>>();
// The barrel is aliased to `packages/app-shell/src`, so an `importOriginal()`
// on it transforms that whole graph on demand — 10204ms when objectui#6567
// instrumented it, 10019ms re-measured for objectui#6580. The three submodules
// below carry every name this file's graph reads from the barrel and cost a few
// ms together: `ExpressionProvider`, `buildExpressionUser` (`expressionUser`)
// and `resolveHostAppSegment` (`utils/`).
vi.mock('@object-ui/app-shell', async () => {
 return {
 ...actual,
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/providers/ExpressionProvider'
 )),
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/providers/expressionUser'
 )),
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/utils/index'
 )),
 useMetadata: () => ({ apps: [] }),
 useNavigationContext: () => ({ currentAppName: undefined }),
 DefaultHomeLayout: ({ children }: { children?: unknown }) => children as never,
Expand Down

22 changes: 20 additions & 2 deletions
apps/console/src/components/SetupRoute.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -68,8 +68,26 @@ vi.mock('../../../../packages/app-shell/src/providers/MetadataProvider', async (
 useMetadata: () => ({ apps, objects: [], loading: false, error: null, refresh: async () => {} }),
}));

vi.mock('@object-ui/app-shell', async (importOriginal) => ({
 ...(await importOriginal<Record<string, unknown>>()),
// `@object-ui/app-shell` is aliased to `packages/app-shell/src`
// (`apps/console/vite.config.ts`), so an `importOriginal()` on it transforms the
// whole barrel graph on demand — measured on this tree at **10019ms**
// (objectui#6580). The three submodules below carry every name this file's graph
// reads from the barrel and cost ~2.0s together: `chrome/` has
// `RedirectWithSplash`, `console/ConsoleShell` has `SetupRedirect`,
// `SETUP_APP_PACKAGE_ID` and `SETUP_APP_NAME`.
vi.mock('@object-ui/app-shell', async () => ({
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/chrome/index'
 )),
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/console/ConsoleShell'
 )),
 // `RootLandingRedirect` reads `useMetadata` through the BARREL, so the
 // provider mock above — which only reaches importers of the provider module
 // itself — does not cover it. The whole-barrel spread this factory used to do
 // covered it by re-exporting the already-mocked provider; spelling the same
 // stub out here keeps that, and is why the two must stay in step.
 useMetadata: () => ({ apps, objects: [], loading: false, error: null, refresh: async () => {} }),
 // Pass-through: the provider stack is not what decides this question.
 ConnectedShell: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
 RequireOrganization: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
Expand Down

14 changes: 12 additions & 2 deletions
apps/console/src/components/StudioRoute.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -90,8 +90,18 @@ vi.mock('../../../../packages/auth/src/useAuth', async (importOriginal) => ({
const builderLanding = vi.fn();
const designSurface = vi.fn();

vi.mock('@object-ui/app-shell', async (importOriginal) => ({
 ...(await importOriginal<Record<string, unknown>>()),
// `@object-ui/app-shell` is aliased to `packages/app-shell/src`
// (`apps/console/vite.config.ts`), so an `importOriginal()` on it transforms the
// whole barrel graph on demand: measured on this tree at **10019ms**, against
// 237ms for `@object-ui/auth` in this same file (objectui#6580). Every name this
// file's graph reads from the barrel is either overridden below or lives in
// `chrome/`, so the factory pulls that ONE submodule (**549ms**) instead.
// `RedirectWithSplash` is the only real export left standing: `ProtectedRoute`
// renders it for the unauthenticated case, which this file asserts.
vi.mock('@object-ui/app-shell', async () => ({
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/chrome/index'
 )),
 // Pass-through: the provider stack is not what decides this question.
 ConnectedShell: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
 RequireOrganization: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test(console): take the app-shell barrel out of three vi.mock factories (#6580)#7315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

yinlianghui
merged 1 commit into

from

Sep 2, 2026
 Merged


test(console): take the app-shell barrel out of three vi.mock factories (#6580)
#7315
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


7 changes: 7 additions & 0 deletions
.changeset/six-donkeys-shake.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
---
---

Test-only change to three `apps/console` test files: the `vi.mock('@object-ui/app-shell', …)`
factories no longer call `importOriginal()`, which was transforming the whole source-aliased
barrel graph (measured 10019 ms per file) to reach a handful of real exports. They now spread
only the app-shell submodules those exports live in. No published behaviour changes.

37 changes: 26 additions & 11 deletions
apps/console/src/components/FormPage.predicateScope.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -73,14 +73,16 @@ import { FormPage } from './FormPage';
 *
 * This module's graph is the first VALUE request for `@object-ui/app-shell` in
 * the file (`FormPage` only `import type`s it), so it is what runs the
 * `vi.mock('@object-ui/app-shell')` factory's `importOriginal()` below — and
 * that specifier is aliased to `packages/app-shell/src`
 * (`apps/console/vite.config.ts`), a barrel carrying eight side-effect imports,
 * transformed on demand. Measured on an IDLE machine it cost **10204ms** of
 * `hop1SessionPrincipal`'s 15000ms budget; the render and the assertions cost
 * ~12ms, the same as the seven cases above. Nothing was wrong with the test —
 * it was racing the module loader, and lost whenever the transform pipeline was
 * saturated by a full-project run.
 * `vi.mock('@object-ui/app-shell')` factory below — and that specifier is
 * aliased to `packages/app-shell/src` (`apps/console/vite.config.ts`), a barrel
 * carrying thirteen side-effect imports, transformed on demand. While that
 * factory still called `importOriginal()` the load cost **10204ms** of
 * `hop1SessionPrincipal`'s 15000ms budget on an IDLE machine, against ~12ms for
 * the render and the assertions. Nothing was wrong with the test — it was
 * racing the module loader, and lost whenever the transform pipeline was
 * saturated by a full-project run. objectui#6580 took the barrel out of the
 * factory; the module-scope import below is what keeps the remaining load out
 * of a bounded window.
 *
 * Module scope moves that cost into the IMPORT phase, which no test or hook
 * timeout bounds. `beforeAll` would not do: it is bounded by `hookTimeout`
Expand DownExpand Up@@ -342,10 +344,23 @@ describe('#6110 controls — green before AND after the fix, by construction', (
 * `vi.mock` calls are hoisted above every import in the file, so the factories
 * are registered before that import executes.
 */
vi.mock('@object-ui/app-shell', async (importOriginal) => {
 const actual = await importOriginal<Record<string, unknown>>();
// The barrel is aliased to `packages/app-shell/src`, so an `importOriginal()`
// on it transforms that whole graph on demand — 10204ms when objectui#6567
// instrumented it, 10019ms re-measured for objectui#6580. The three submodules
// below carry every name this file's graph reads from the barrel and cost a few
// ms together: `ExpressionProvider`, `buildExpressionUser` (`expressionUser`)
// and `resolveHostAppSegment` (`utils/`).
vi.mock('@object-ui/app-shell', async () => {
 return {
 ...actual,
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/providers/ExpressionProvider'
 )),
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/providers/expressionUser'
 )),
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/utils/index'
 )),
 useMetadata: () => ({ apps: [] }),
 useNavigationContext: () => ({ currentAppName: undefined }),
 DefaultHomeLayout: ({ children }: { children?: unknown }) => children as never,
Expand Down

22 changes: 20 additions & 2 deletions
apps/console/src/components/SetupRoute.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -68,8 +68,26 @@ vi.mock('../../../../packages/app-shell/src/providers/MetadataProvider', async (
 useMetadata: () => ({ apps, objects: [], loading: false, error: null, refresh: async () => {} }),
}));

vi.mock('@object-ui/app-shell', async (importOriginal) => ({
 ...(await importOriginal<Record<string, unknown>>()),
// `@object-ui/app-shell` is aliased to `packages/app-shell/src`
// (`apps/console/vite.config.ts`), so an `importOriginal()` on it transforms the
// whole barrel graph on demand — measured on this tree at **10019ms**
// (objectui#6580). The three submodules below carry every name this file's graph
// reads from the barrel and cost ~2.0s together: `chrome/` has
// `RedirectWithSplash`, `console/ConsoleShell` has `SetupRedirect`,
// `SETUP_APP_PACKAGE_ID` and `SETUP_APP_NAME`.
vi.mock('@object-ui/app-shell', async () => ({
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/chrome/index'
 )),
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/console/ConsoleShell'
 )),
 // `RootLandingRedirect` reads `useMetadata` through the BARREL, so the
 // provider mock above — which only reaches importers of the provider module
 // itself — does not cover it. The whole-barrel spread this factory used to do
 // covered it by re-exporting the already-mocked provider; spelling the same
 // stub out here keeps that, and is why the two must stay in step.
 useMetadata: () => ({ apps, objects: [], loading: false, error: null, refresh: async () => {} }),
 // Pass-through: the provider stack is not what decides this question.
 ConnectedShell: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
 RequireOrganization: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
Expand Down

14 changes: 12 additions & 2 deletions
apps/console/src/components/StudioRoute.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -90,8 +90,18 @@ vi.mock('../../../../packages/auth/src/useAuth', async (importOriginal) => ({
const builderLanding = vi.fn();
const designSurface = vi.fn();

vi.mock('@object-ui/app-shell', async (importOriginal) => ({
 ...(await importOriginal<Record<string, unknown>>()),
// `@object-ui/app-shell` is aliased to `packages/app-shell/src`
// (`apps/console/vite.config.ts`), so an `importOriginal()` on it transforms the
// whole barrel graph on demand: measured on this tree at **10019ms**, against
// 237ms for `@object-ui/auth` in this same file (objectui#6580). Every name this
// file's graph reads from the barrel is either overridden below or lives in
// `chrome/`, so the factory pulls that ONE submodule (**549ms**) instead.
// `RedirectWithSplash` is the only real export left standing: `ProtectedRoute`
// renders it for the unauthenticated case, which this file asserts.
vi.mock('@object-ui/app-shell', async () => ({
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/chrome/index'
 )),
 // Pass-through: the provider stack is not what decides this question.
 ConnectedShell: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
 RequireOrganization: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test(console): take the app-shell barrel out of three vi.mock factories (#6580)#7315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

yinlianghui
merged 1 commit into

from

Sep 2, 2026
 Merged


test(console): take the app-shell barrel out of three vi.mock factories (#6580)
#7315
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


7 changes: 7 additions & 0 deletions
.changeset/six-donkeys-shake.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
---
---

Test-only change to three `apps/console` test files: the `vi.mock('@object-ui/app-shell', …)`
factories no longer call `importOriginal()`, which was transforming the whole source-aliased
barrel graph (measured 10019 ms per file) to reach a handful of real exports. They now spread
only the app-shell submodules those exports live in. No published behaviour changes.

37 changes: 26 additions & 11 deletions
apps/console/src/components/FormPage.predicateScope.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -73,14 +73,16 @@ import { FormPage } from './FormPage';
 *
 * This module's graph is the first VALUE request for `@object-ui/app-shell` in
 * the file (`FormPage` only `import type`s it), so it is what runs the
 * `vi.mock('@object-ui/app-shell')` factory's `importOriginal()` below — and
 * that specifier is aliased to `packages/app-shell/src`
 * (`apps/console/vite.config.ts`), a barrel carrying eight side-effect imports,
 * transformed on demand. Measured on an IDLE machine it cost **10204ms** of
 * `hop1SessionPrincipal`'s 15000ms budget; the render and the assertions cost
 * ~12ms, the same as the seven cases above. Nothing was wrong with the test —
 * it was racing the module loader, and lost whenever the transform pipeline was
 * saturated by a full-project run.
 * `vi.mock('@object-ui/app-shell')` factory below — and that specifier is
 * aliased to `packages/app-shell/src` (`apps/console/vite.config.ts`), a barrel
 * carrying thirteen side-effect imports, transformed on demand. While that
 * factory still called `importOriginal()` the load cost **10204ms** of
 * `hop1SessionPrincipal`'s 15000ms budget on an IDLE machine, against ~12ms for
 * the render and the assertions. Nothing was wrong with the test — it was
 * racing the module loader, and lost whenever the transform pipeline was
 * saturated by a full-project run. objectui#6580 took the barrel out of the
 * factory; the module-scope import below is what keeps the remaining load out
 * of a bounded window.
 *
 * Module scope moves that cost into the IMPORT phase, which no test or hook
 * timeout bounds. `beforeAll` would not do: it is bounded by `hookTimeout`
Expand DownExpand Up@@ -342,10 +344,23 @@ describe('#6110 controls — green before AND after the fix, by construction', (
 * `vi.mock` calls are hoisted above every import in the file, so the factories
 * are registered before that import executes.
 */
vi.mock('@object-ui/app-shell', async (importOriginal) => {
 const actual = await importOriginal<Record<string, unknown>>();
// The barrel is aliased to `packages/app-shell/src`, so an `importOriginal()`
// on it transforms that whole graph on demand — 10204ms when objectui#6567
// instrumented it, 10019ms re-measured for objectui#6580. The three submodules
// below carry every name this file's graph reads from the barrel and cost a few
// ms together: `ExpressionProvider`, `buildExpressionUser` (`expressionUser`)
// and `resolveHostAppSegment` (`utils/`).
vi.mock('@object-ui/app-shell', async () => {
 return {
 ...actual,
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/providers/ExpressionProvider'
 )),
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/providers/expressionUser'
 )),
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/utils/index'
 )),
 useMetadata: () => ({ apps: [] }),
 useNavigationContext: () => ({ currentAppName: undefined }),
 DefaultHomeLayout: ({ children }: { children?: unknown }) => children as never,
Expand Down

22 changes: 20 additions & 2 deletions
apps/console/src/components/SetupRoute.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -68,8 +68,26 @@ vi.mock('../../../../packages/app-shell/src/providers/MetadataProvider', async (
 useMetadata: () => ({ apps, objects: [], loading: false, error: null, refresh: async () => {} }),
}));

vi.mock('@object-ui/app-shell', async (importOriginal) => ({
 ...(await importOriginal<Record<string, unknown>>()),
// `@object-ui/app-shell` is aliased to `packages/app-shell/src`
// (`apps/console/vite.config.ts`), so an `importOriginal()` on it transforms the
// whole barrel graph on demand — measured on this tree at **10019ms**
// (objectui#6580). The three submodules below carry every name this file's graph
// reads from the barrel and cost ~2.0s together: `chrome/` has
// `RedirectWithSplash`, `console/ConsoleShell` has `SetupRedirect`,
// `SETUP_APP_PACKAGE_ID` and `SETUP_APP_NAME`.
vi.mock('@object-ui/app-shell', async () => ({
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/chrome/index'
 )),
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/console/ConsoleShell'
 )),
 // `RootLandingRedirect` reads `useMetadata` through the BARREL, so the
 // provider mock above — which only reaches importers of the provider module
 // itself — does not cover it. The whole-barrel spread this factory used to do
 // covered it by re-exporting the already-mocked provider; spelling the same
 // stub out here keeps that, and is why the two must stay in step.
 useMetadata: () => ({ apps, objects: [], loading: false, error: null, refresh: async () => {} }),
 // Pass-through: the provider stack is not what decides this question.
 ConnectedShell: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
 RequireOrganization: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
Expand Down

14 changes: 12 additions & 2 deletions
apps/console/src/components/StudioRoute.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -90,8 +90,18 @@ vi.mock('../../../../packages/auth/src/useAuth', async (importOriginal) => ({
const builderLanding = vi.fn();
const designSurface = vi.fn();

vi.mock('@object-ui/app-shell', async (importOriginal) => ({
 ...(await importOriginal<Record<string, unknown>>()),
// `@object-ui/app-shell` is aliased to `packages/app-shell/src`
// (`apps/console/vite.config.ts`), so an `importOriginal()` on it transforms the
// whole barrel graph on demand: measured on this tree at **10019ms**, against
// 237ms for `@object-ui/auth` in this same file (objectui#6580). Every name this
// file's graph reads from the barrel is either overridden below or lives in
// `chrome/`, so the factory pulls that ONE submodule (**549ms**) instead.
// `RedirectWithSplash` is the only real export left standing: `ProtectedRoute`
// renders it for the unauthenticated case, which this file asserts.
vi.mock('@object-ui/app-shell', async () => ({
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/chrome/index'
 )),
 // Pass-through: the provider stack is not what decides this question.
 ConnectedShell: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
 RequireOrganization: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
test(console): take the app-shell barrel out of three vi.mock factories (#6580)#7315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

yinlianghui
merged 1 commit into

from

Sep 2, 2026
 Merged


test(console): take the app-shell barrel out of three vi.mock factories (#6580)
#7315
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


7 changes: 7 additions & 0 deletions
.changeset/six-donkeys-shake.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
---
---

Test-only change to three `apps/console` test files: the `vi.mock('@object-ui/app-shell', …)`
factories no longer call `importOriginal()`, which was transforming the whole source-aliased
barrel graph (measured 10019 ms per file) to reach a handful of real exports. They now spread
only the app-shell submodules those exports live in. No published behaviour changes.

37 changes: 26 additions & 11 deletions
apps/console/src/components/FormPage.predicateScope.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -73,14 +73,16 @@ import { FormPage } from './FormPage';
 *
 * This module's graph is the first VALUE request for `@object-ui/app-shell` in
 * the file (`FormPage` only `import type`s it), so it is what runs the
 * `vi.mock('@object-ui/app-shell')` factory's `importOriginal()` below — and
 * that specifier is aliased to `packages/app-shell/src`
 * (`apps/console/vite.config.ts`), a barrel carrying eight side-effect imports,
 * transformed on demand. Measured on an IDLE machine it cost **10204ms** of
 * `hop1SessionPrincipal`'s 15000ms budget; the render and the assertions cost
 * ~12ms, the same as the seven cases above. Nothing was wrong with the test —
 * it was racing the module loader, and lost whenever the transform pipeline was
 * saturated by a full-project run.
 * `vi.mock('@object-ui/app-shell')` factory below — and that specifier is
 * aliased to `packages/app-shell/src` (`apps/console/vite.config.ts`), a barrel
 * carrying thirteen side-effect imports, transformed on demand. While that
 * factory still called `importOriginal()` the load cost **10204ms** of
 * `hop1SessionPrincipal`'s 15000ms budget on an IDLE machine, against ~12ms for
 * the render and the assertions. Nothing was wrong with the test — it was
 * racing the module loader, and lost whenever the transform pipeline was
 * saturated by a full-project run. objectui#6580 took the barrel out of the
 * factory; the module-scope import below is what keeps the remaining load out
 * of a bounded window.
 *
 * Module scope moves that cost into the IMPORT phase, which no test or hook
 * timeout bounds. `beforeAll` would not do: it is bounded by `hookTimeout`
Expand DownExpand Up@@ -342,10 +344,23 @@ describe('#6110 controls — green before AND after the fix, by construction', (
 * `vi.mock` calls are hoisted above every import in the file, so the factories
 * are registered before that import executes.
 */
vi.mock('@object-ui/app-shell', async (importOriginal) => {
 const actual = await importOriginal<Record<string, unknown>>();
// The barrel is aliased to `packages/app-shell/src`, so an `importOriginal()`
// on it transforms that whole graph on demand — 10204ms when objectui#6567
// instrumented it, 10019ms re-measured for objectui#6580. The three submodules
// below carry every name this file's graph reads from the barrel and cost a few
// ms together: `ExpressionProvider`, `buildExpressionUser` (`expressionUser`)
// and `resolveHostAppSegment` (`utils/`).
vi.mock('@object-ui/app-shell', async () => {
 return {
 ...actual,
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/providers/ExpressionProvider'
 )),
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/providers/expressionUser'
 )),
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/utils/index'
 )),
 useMetadata: () => ({ apps: [] }),
 useNavigationContext: () => ({ currentAppName: undefined }),
 DefaultHomeLayout: ({ children }: { children?: unknown }) => children as never,
Expand Down

22 changes: 20 additions & 2 deletions
apps/console/src/components/SetupRoute.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -68,8 +68,26 @@ vi.mock('../../../../packages/app-shell/src/providers/MetadataProvider', async (
 useMetadata: () => ({ apps, objects: [], loading: false, error: null, refresh: async () => {} }),
}));

vi.mock('@object-ui/app-shell', async (importOriginal) => ({
 ...(await importOriginal<Record<string, unknown>>()),
// `@object-ui/app-shell` is aliased to `packages/app-shell/src`
// (`apps/console/vite.config.ts`), so an `importOriginal()` on it transforms the
// whole barrel graph on demand — measured on this tree at **10019ms**
// (objectui#6580). The three submodules below carry every name this file's graph
// reads from the barrel and cost ~2.0s together: `chrome/` has
// `RedirectWithSplash`, `console/ConsoleShell` has `SetupRedirect`,
// `SETUP_APP_PACKAGE_ID` and `SETUP_APP_NAME`.
vi.mock('@object-ui/app-shell', async () => ({
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/chrome/index'
 )),
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/console/ConsoleShell'
 )),
 // `RootLandingRedirect` reads `useMetadata` through the BARREL, so the
 // provider mock above — which only reaches importers of the provider module
 // itself — does not cover it. The whole-barrel spread this factory used to do
 // covered it by re-exporting the already-mocked provider; spelling the same
 // stub out here keeps that, and is why the two must stay in step.
 useMetadata: () => ({ apps, objects: [], loading: false, error: null, refresh: async () => {} }),
 // Pass-through: the provider stack is not what decides this question.
 ConnectedShell: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
 RequireOrganization: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
Expand Down

14 changes: 12 additions & 2 deletions
apps/console/src/components/StudioRoute.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -90,8 +90,18 @@ vi.mock('../../../../packages/auth/src/useAuth', async (importOriginal) => ({
const builderLanding = vi.fn();
const designSurface = vi.fn();

vi.mock('@object-ui/app-shell', async (importOriginal) => ({
 ...(await importOriginal<Record<string, unknown>>()),
// `@object-ui/app-shell` is aliased to `packages/app-shell/src`
// (`apps/console/vite.config.ts`), so an `importOriginal()` on it transforms the
// whole barrel graph on demand: measured on this tree at **10019ms**, against
// 237ms for `@object-ui/auth` in this same file (objectui#6580). Every name this
// file's graph reads from the barrel is either overridden below or lives in
// `chrome/`, so the factory pulls that ONE submodule (**549ms**) instead.
// `RedirectWithSplash` is the only real export left standing: `ProtectedRoute`
// renders it for the unauthenticated case, which this file asserts.
vi.mock('@object-ui/app-shell', async () => ({
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/chrome/index'
 )),
 // Pass-through: the provider stack is not what decides this question.
 ConnectedShell: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
 RequireOrganization: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test(console): take the app-shell barrel out of three vi.mock factories (#6580)#7315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

yinlianghui
merged 1 commit into

from

Sep 2, 2026
 Merged


test(console): take the app-shell barrel out of three vi.mock factories (#6580)
#7315
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


7 changes: 7 additions & 0 deletions
.changeset/six-donkeys-shake.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
---
---

Test-only change to three `apps/console` test files: the `vi.mock('@object-ui/app-shell', …)`
factories no longer call `importOriginal()`, which was transforming the whole source-aliased
barrel graph (measured 10019 ms per file) to reach a handful of real exports. They now spread
only the app-shell submodules those exports live in. No published behaviour changes.

37 changes: 26 additions & 11 deletions
apps/console/src/components/FormPage.predicateScope.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -73,14 +73,16 @@ import { FormPage } from './FormPage';
 *
 * This module's graph is the first VALUE request for `@object-ui/app-shell` in
 * the file (`FormPage` only `import type`s it), so it is what runs the
 * `vi.mock('@object-ui/app-shell')` factory's `importOriginal()` below — and
 * that specifier is aliased to `packages/app-shell/src`
 * (`apps/console/vite.config.ts`), a barrel carrying eight side-effect imports,
 * transformed on demand. Measured on an IDLE machine it cost **10204ms** of
 * `hop1SessionPrincipal`'s 15000ms budget; the render and the assertions cost
 * ~12ms, the same as the seven cases above. Nothing was wrong with the test —
 * it was racing the module loader, and lost whenever the transform pipeline was
 * saturated by a full-project run.
 * `vi.mock('@object-ui/app-shell')` factory below — and that specifier is
 * aliased to `packages/app-shell/src` (`apps/console/vite.config.ts`), a barrel
 * carrying thirteen side-effect imports, transformed on demand. While that
 * factory still called `importOriginal()` the load cost **10204ms** of
 * `hop1SessionPrincipal`'s 15000ms budget on an IDLE machine, against ~12ms for
 * the render and the assertions. Nothing was wrong with the test — it was
 * racing the module loader, and lost whenever the transform pipeline was
 * saturated by a full-project run. objectui#6580 took the barrel out of the
 * factory; the module-scope import below is what keeps the remaining load out
 * of a bounded window.
 *
 * Module scope moves that cost into the IMPORT phase, which no test or hook
 * timeout bounds. `beforeAll` would not do: it is bounded by `hookTimeout`
Expand DownExpand Up@@ -342,10 +344,23 @@ describe('#6110 controls — green before AND after the fix, by construction', (
 * `vi.mock` calls are hoisted above every import in the file, so the factories
 * are registered before that import executes.
 */
vi.mock('@object-ui/app-shell', async (importOriginal) => {
 const actual = await importOriginal<Record<string, unknown>>();
// The barrel is aliased to `packages/app-shell/src`, so an `importOriginal()`
// on it transforms that whole graph on demand — 10204ms when objectui#6567
// instrumented it, 10019ms re-measured for objectui#6580. The three submodules
// below carry every name this file's graph reads from the barrel and cost a few
// ms together: `ExpressionProvider`, `buildExpressionUser` (`expressionUser`)
// and `resolveHostAppSegment` (`utils/`).
vi.mock('@object-ui/app-shell', async () => {
 return {
 ...actual,
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/providers/ExpressionProvider'
 )),
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/providers/expressionUser'
 )),
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/utils/index'
 )),
 useMetadata: () => ({ apps: [] }),
 useNavigationContext: () => ({ currentAppName: undefined }),
 DefaultHomeLayout: ({ children }: { children?: unknown }) => children as never,
Expand Down

22 changes: 20 additions & 2 deletions
apps/console/src/components/SetupRoute.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -68,8 +68,26 @@ vi.mock('../../../../packages/app-shell/src/providers/MetadataProvider', async (
 useMetadata: () => ({ apps, objects: [], loading: false, error: null, refresh: async () => {} }),
}));

vi.mock('@object-ui/app-shell', async (importOriginal) => ({
 ...(await importOriginal<Record<string, unknown>>()),
// `@object-ui/app-shell` is aliased to `packages/app-shell/src`
// (`apps/console/vite.config.ts`), so an `importOriginal()` on it transforms the
// whole barrel graph on demand — measured on this tree at **10019ms**
// (objectui#6580). The three submodules below carry every name this file's graph
// reads from the barrel and cost ~2.0s together: `chrome/` has
// `RedirectWithSplash`, `console/ConsoleShell` has `SetupRedirect`,
// `SETUP_APP_PACKAGE_ID` and `SETUP_APP_NAME`.
vi.mock('@object-ui/app-shell', async () => ({
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/chrome/index'
 )),
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/console/ConsoleShell'
 )),
 // `RootLandingRedirect` reads `useMetadata` through the BARREL, so the
 // provider mock above — which only reaches importers of the provider module
 // itself — does not cover it. The whole-barrel spread this factory used to do
 // covered it by re-exporting the already-mocked provider; spelling the same
 // stub out here keeps that, and is why the two must stay in step.
 useMetadata: () => ({ apps, objects: [], loading: false, error: null, refresh: async () => {} }),
 // Pass-through: the provider stack is not what decides this question.
 ConnectedShell: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
 RequireOrganization: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
Expand Down

14 changes: 12 additions & 2 deletions
apps/console/src/components/StudioRoute.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -90,8 +90,18 @@ vi.mock('../../../../packages/auth/src/useAuth', async (importOriginal) => ({
const builderLanding = vi.fn();
const designSurface = vi.fn();

vi.mock('@object-ui/app-shell', async (importOriginal) => ({
 ...(await importOriginal<Record<string, unknown>>()),
// `@object-ui/app-shell` is aliased to `packages/app-shell/src`
// (`apps/console/vite.config.ts`), so an `importOriginal()` on it transforms the
// whole barrel graph on demand: measured on this tree at **10019ms**, against
// 237ms for `@object-ui/auth` in this same file (objectui#6580). Every name this
// file's graph reads from the barrel is either overridden below or lives in
// `chrome/`, so the factory pulls that ONE submodule (**549ms**) instead.
// `RedirectWithSplash` is the only real export left standing: `ProtectedRoute`
// renders it for the unauthenticated case, which this file asserts.
vi.mock('@object-ui/app-shell', async () => ({
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/chrome/index'
 )),
 // Pass-through: the provider stack is not what decides this question.
 ConnectedShell: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
 RequireOrganization: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test(console): take the app-shell barrel out of three vi.mock factories (#6580)#7315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

yinlianghui
merged 1 commit into

from

Sep 2, 2026
 Merged


test(console): take the app-shell barrel out of three vi.mock factories (#6580)
#7315
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


7 changes: 7 additions & 0 deletions
.changeset/six-donkeys-shake.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
---
---

Test-only change to three `apps/console` test files: the `vi.mock('@object-ui/app-shell', …)`
factories no longer call `importOriginal()`, which was transforming the whole source-aliased
barrel graph (measured 10019 ms per file) to reach a handful of real exports. They now spread
only the app-shell submodules those exports live in. No published behaviour changes.

37 changes: 26 additions & 11 deletions
apps/console/src/components/FormPage.predicateScope.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -73,14 +73,16 @@ import { FormPage } from './FormPage';
 *
 * This module's graph is the first VALUE request for `@object-ui/app-shell` in
 * the file (`FormPage` only `import type`s it), so it is what runs the
 * `vi.mock('@object-ui/app-shell')` factory's `importOriginal()` below — and
 * that specifier is aliased to `packages/app-shell/src`
 * (`apps/console/vite.config.ts`), a barrel carrying eight side-effect imports,
 * transformed on demand. Measured on an IDLE machine it cost **10204ms** of
 * `hop1SessionPrincipal`'s 15000ms budget; the render and the assertions cost
 * ~12ms, the same as the seven cases above. Nothing was wrong with the test —
 * it was racing the module loader, and lost whenever the transform pipeline was
 * saturated by a full-project run.
 * `vi.mock('@object-ui/app-shell')` factory below — and that specifier is
 * aliased to `packages/app-shell/src` (`apps/console/vite.config.ts`), a barrel
 * carrying thirteen side-effect imports, transformed on demand. While that
 * factory still called `importOriginal()` the load cost **10204ms** of
 * `hop1SessionPrincipal`'s 15000ms budget on an IDLE machine, against ~12ms for
 * the render and the assertions. Nothing was wrong with the test — it was
 * racing the module loader, and lost whenever the transform pipeline was
 * saturated by a full-project run. objectui#6580 took the barrel out of the
 * factory; the module-scope import below is what keeps the remaining load out
 * of a bounded window.
 *
 * Module scope moves that cost into the IMPORT phase, which no test or hook
 * timeout bounds. `beforeAll` would not do: it is bounded by `hookTimeout`
Expand DownExpand Up@@ -342,10 +344,23 @@ describe('#6110 controls — green before AND after the fix, by construction', (
 * `vi.mock` calls are hoisted above every import in the file, so the factories
 * are registered before that import executes.
 */
vi.mock('@object-ui/app-shell', async (importOriginal) => {
 const actual = await importOriginal<Record<string, unknown>>();
// The barrel is aliased to `packages/app-shell/src`, so an `importOriginal()`
// on it transforms that whole graph on demand — 10204ms when objectui#6567
// instrumented it, 10019ms re-measured for objectui#6580. The three submodules
// below carry every name this file's graph reads from the barrel and cost a few
// ms together: `ExpressionProvider`, `buildExpressionUser` (`expressionUser`)
// and `resolveHostAppSegment` (`utils/`).
vi.mock('@object-ui/app-shell', async () => {
 return {
 ...actual,
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/providers/ExpressionProvider'
 )),
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/providers/expressionUser'
 )),
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/utils/index'
 )),
 useMetadata: () => ({ apps: [] }),
 useNavigationContext: () => ({ currentAppName: undefined }),
 DefaultHomeLayout: ({ children }: { children?: unknown }) => children as never,
Expand Down

22 changes: 20 additions & 2 deletions
apps/console/src/components/SetupRoute.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -68,8 +68,26 @@ vi.mock('../../../../packages/app-shell/src/providers/MetadataProvider', async (
 useMetadata: () => ({ apps, objects: [], loading: false, error: null, refresh: async () => {} }),
}));

vi.mock('@object-ui/app-shell', async (importOriginal) => ({
 ...(await importOriginal<Record<string, unknown>>()),
// `@object-ui/app-shell` is aliased to `packages/app-shell/src`
// (`apps/console/vite.config.ts`), so an `importOriginal()` on it transforms the
// whole barrel graph on demand — measured on this tree at **10019ms**
// (objectui#6580). The three submodules below carry every name this file's graph
// reads from the barrel and cost ~2.0s together: `chrome/` has
// `RedirectWithSplash`, `console/ConsoleShell` has `SetupRedirect`,
// `SETUP_APP_PACKAGE_ID` and `SETUP_APP_NAME`.
vi.mock('@object-ui/app-shell', async () => ({
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/chrome/index'
 )),
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/console/ConsoleShell'
 )),
 // `RootLandingRedirect` reads `useMetadata` through the BARREL, so the
 // provider mock above — which only reaches importers of the provider module
 // itself — does not cover it. The whole-barrel spread this factory used to do
 // covered it by re-exporting the already-mocked provider; spelling the same
 // stub out here keeps that, and is why the two must stay in step.
 useMetadata: () => ({ apps, objects: [], loading: false, error: null, refresh: async () => {} }),
 // Pass-through: the provider stack is not what decides this question.
 ConnectedShell: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
 RequireOrganization: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
Expand Down

14 changes: 12 additions & 2 deletions
apps/console/src/components/StudioRoute.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -90,8 +90,18 @@ vi.mock('../../../../packages/auth/src/useAuth', async (importOriginal) => ({
const builderLanding = vi.fn();
const designSurface = vi.fn();

vi.mock('@object-ui/app-shell', async (importOriginal) => ({
 ...(await importOriginal<Record<string, unknown>>()),
// `@object-ui/app-shell` is aliased to `packages/app-shell/src`
// (`apps/console/vite.config.ts`), so an `importOriginal()` on it transforms the
// whole barrel graph on demand: measured on this tree at **10019ms**, against
// 237ms for `@object-ui/auth` in this same file (objectui#6580). Every name this
// file's graph reads from the barrel is either overridden below or lives in
// `chrome/`, so the factory pulls that ONE submodule (**549ms**) instead.
// `RedirectWithSplash` is the only real export left standing: `ProtectedRoute`
// renders it for the unauthenticated case, which this file asserts.
vi.mock('@object-ui/app-shell', async () => ({
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/chrome/index'
 )),
 // Pass-through: the provider stack is not what decides this question.
 ConnectedShell: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
 RequireOrganization: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
test(console): take the app-shell barrel out of three vi.mock factories (#6580)#7315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

yinlianghui
merged 1 commit into

from

Sep 2, 2026
 Merged


test(console): take the app-shell barrel out of three vi.mock factories (#6580)
#7315
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


7 changes: 7 additions & 0 deletions
.changeset/six-donkeys-shake.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
---
---

Test-only change to three `apps/console` test files: the `vi.mock('@object-ui/app-shell', …)`
factories no longer call `importOriginal()`, which was transforming the whole source-aliased
barrel graph (measured 10019 ms per file) to reach a handful of real exports. They now spread
only the app-shell submodules those exports live in. No published behaviour changes.

37 changes: 26 additions & 11 deletions
apps/console/src/components/FormPage.predicateScope.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -73,14 +73,16 @@ import { FormPage } from './FormPage';
 *
 * This module's graph is the first VALUE request for `@object-ui/app-shell` in
 * the file (`FormPage` only `import type`s it), so it is what runs the
 * `vi.mock('@object-ui/app-shell')` factory's `importOriginal()` below — and
 * that specifier is aliased to `packages/app-shell/src`
 * (`apps/console/vite.config.ts`), a barrel carrying eight side-effect imports,
 * transformed on demand. Measured on an IDLE machine it cost **10204ms** of
 * `hop1SessionPrincipal`'s 15000ms budget; the render and the assertions cost
 * ~12ms, the same as the seven cases above. Nothing was wrong with the test —
 * it was racing the module loader, and lost whenever the transform pipeline was
 * saturated by a full-project run.
 * `vi.mock('@object-ui/app-shell')` factory below — and that specifier is
 * aliased to `packages/app-shell/src` (`apps/console/vite.config.ts`), a barrel
 * carrying thirteen side-effect imports, transformed on demand. While that
 * factory still called `importOriginal()` the load cost **10204ms** of
 * `hop1SessionPrincipal`'s 15000ms budget on an IDLE machine, against ~12ms for
 * the render and the assertions. Nothing was wrong with the test — it was
 * racing the module loader, and lost whenever the transform pipeline was
 * saturated by a full-project run. objectui#6580 took the barrel out of the
 * factory; the module-scope import below is what keeps the remaining load out
 * of a bounded window.
 *
 * Module scope moves that cost into the IMPORT phase, which no test or hook
 * timeout bounds. `beforeAll` would not do: it is bounded by `hookTimeout`
Expand DownExpand Up@@ -342,10 +344,23 @@ describe('#6110 controls — green before AND after the fix, by construction', (
 * `vi.mock` calls are hoisted above every import in the file, so the factories
 * are registered before that import executes.
 */
vi.mock('@object-ui/app-shell', async (importOriginal) => {
 const actual = await importOriginal<Record<string, unknown>>();
// The barrel is aliased to `packages/app-shell/src`, so an `importOriginal()`
// on it transforms that whole graph on demand — 10204ms when objectui#6567
// instrumented it, 10019ms re-measured for objectui#6580. The three submodules
// below carry every name this file's graph reads from the barrel and cost a few
// ms together: `ExpressionProvider`, `buildExpressionUser` (`expressionUser`)
// and `resolveHostAppSegment` (`utils/`).
vi.mock('@object-ui/app-shell', async () => {
 return {
 ...actual,
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/providers/ExpressionProvider'
 )),
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/providers/expressionUser'
 )),
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/utils/index'
 )),
 useMetadata: () => ({ apps: [] }),
 useNavigationContext: () => ({ currentAppName: undefined }),
 DefaultHomeLayout: ({ children }: { children?: unknown }) => children as never,
Expand Down

22 changes: 20 additions & 2 deletions
apps/console/src/components/SetupRoute.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -68,8 +68,26 @@ vi.mock('../../../../packages/app-shell/src/providers/MetadataProvider', async (
 useMetadata: () => ({ apps, objects: [], loading: false, error: null, refresh: async () => {} }),
}));

vi.mock('@object-ui/app-shell', async (importOriginal) => ({
 ...(await importOriginal<Record<string, unknown>>()),
// `@object-ui/app-shell` is aliased to `packages/app-shell/src`
// (`apps/console/vite.config.ts`), so an `importOriginal()` on it transforms the
// whole barrel graph on demand — measured on this tree at **10019ms**
// (objectui#6580). The three submodules below carry every name this file's graph
// reads from the barrel and cost ~2.0s together: `chrome/` has
// `RedirectWithSplash`, `console/ConsoleShell` has `SetupRedirect`,
// `SETUP_APP_PACKAGE_ID` and `SETUP_APP_NAME`.
vi.mock('@object-ui/app-shell', async () => ({
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/chrome/index'
 )),
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/console/ConsoleShell'
 )),
 // `RootLandingRedirect` reads `useMetadata` through the BARREL, so the
 // provider mock above — which only reaches importers of the provider module
 // itself — does not cover it. The whole-barrel spread this factory used to do
 // covered it by re-exporting the already-mocked provider; spelling the same
 // stub out here keeps that, and is why the two must stay in step.
 useMetadata: () => ({ apps, objects: [], loading: false, error: null, refresh: async () => {} }),
 // Pass-through: the provider stack is not what decides this question.
 ConnectedShell: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
 RequireOrganization: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
Expand Down

14 changes: 12 additions & 2 deletions
apps/console/src/components/StudioRoute.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -90,8 +90,18 @@ vi.mock('../../../../packages/auth/src/useAuth', async (importOriginal) => ({
const builderLanding = vi.fn();
const designSurface = vi.fn();

vi.mock('@object-ui/app-shell', async (importOriginal) => ({
 ...(await importOriginal<Record<string, unknown>>()),
// `@object-ui/app-shell` is aliased to `packages/app-shell/src`
// (`apps/console/vite.config.ts`), so an `importOriginal()` on it transforms the
// whole barrel graph on demand: measured on this tree at **10019ms**, against
// 237ms for `@object-ui/auth` in this same file (objectui#6580). Every name this
// file's graph reads from the barrel is either overridden below or lives in
// `chrome/`, so the factory pulls that ONE submodule (**549ms**) instead.
// `RedirectWithSplash` is the only real export left standing: `ProtectedRoute`
// renders it for the unauthenticated case, which this file asserts.
vi.mock('@object-ui/app-shell', async () => ({
 ...(await vi.importActual<Record<string, unknown>>(
 '../../../../packages/app-shell/src/chrome/index'
 )),
 // Pass-through: the provider stack is not what decides this question.
 ConnectedShell: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
 RequireOrganization: ({ children }: { children?: React.ReactNode }) => <>{children}</>,
Expand Down
Loading