Uh oh!
There was an error while loading. Please reload this page.
Conversation
tmcw
commented
Mar 21, 2019
ContributorAuthor
In terms of doing this the long way, I opened a PR to add an ES Module entry point to marked markedjs/marked#1452 |
mbostock
commented
Mar 21, 2019
Member
Let’s fork marked and use that as a dependency for now. |
mbostock
commented
Mar 21, 2019
Member
Thanks. If you revert the rollup.config.js changes and remove the rollup-plugin-commonjs dep, this looks good. 👍 |
mbostock
approved these changes
Mar 21, 2019
mootari
commented
Mar 22, 2019
Was the version jump from 0.3.12 to 0.6.1 intended? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One part of https://github.com/observablehq/notebook/issues/2197
Main gotcha that happens here is that the dependency path notebook - runtime - stdlib ends up with the 'module' entry in stdlib, and that means that it tries to import marked, and because marked is commonjs, it fails. So… we may need to either special-case that in the notebook, or something else.