Add new text styles - #122
Open
barry-observation wants to merge 1 commit into
Open
Conversation
barry-observation
force-pushed
the
feature/new-static-text-styles
branch
from
September 10, 2026 14:51
5c4f58e to
e992062
Compare
barry-observation
force-pushed
the
feature/new-static-text-styles
branch
from
September 10, 2026 15:06
e992062 to
fe480f5
Compare
| fontWeight: 'bold', | ||
| color: theme.color.text.system.strong, | ||
| }, | ||
| speciesLocalNameCompact: { |
Member
There was a problem hiding this comment.
Als je binnen de factory method dit definieert:
const speciesLocalName = {
fontFamily: 'Ubuntu',
fontStyle: 'normal',
fontSize: 16,
lineHeight: 24,
fontWeight: 'bold',
color: theme.color.text.system.strong,
} satisfies Text['speciesLocalName']dan kun je hier dit doen:
speciesLocalName,
speciesLocalNameCompact: {
...speciesLocalName,
lineHeight: 22,
},| fontFamily: 'Ubuntu', | ||
| fontStyle: 'normal', | ||
| fontSize: 10, | ||
| lineHeight: 14, |
Member
There was a problem hiding this comment.
Dit was
lineHeight: theme.font.extraSmall.fontSize,oftewel 10, en die wijziging resulteert ook in de snapshot-verschillen. Was dit de bedoeling?
Contributor
Author
There was a problem hiding this comment.
Ik ga het maandag met Karel bespreken. Het design zegt 14 maar op dit moment is het 12 in Observation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Necessary for https://github.com/observation/app/pull/1373