idian: Refactor Idian widgets - #13765
Merged
Merged
Conversation
7 tasks
PatTheMav
requested changes
Aug 11, 2026
Warchamp7
force-pushed
the
idian-refactor
branch
3 times, most recently
from
August 12, 2026 20:07
3374529 to
0734aa1
Compare
Warchamp7
force-pushed
the
idian-refactor
branch
2 times, most recently
from
September 3, 2026 17:30
20a6b01 to
f73364f
Compare
PatTheMav
reviewed
Sep 7, 2026
RytoEX
requested changes
Sep 10, 2026
PatTheMav
reviewed
Sep 11, 2026
Member
|
LGTM. Will approve once commits are squashed. |
Warchamp7
force-pushed
the
idian-refactor
branch
from
September 11, 2026 20:58
4b72c85 to
04509c0
Compare
The idian widgets were built when we had a much lower understanding of how Qt expects you to build custom complex widgets and without a direct use-case. They were also built far too rigid for what every attempted use of them thus far has necessitated. These changes break them into simpler 'pieces' and provide getters for internals that are intended to be accessed.
Updates the idian widgets to no longer inherit from the Utils class. The multi-inheritance approach was from an earlier iteration of the utils prior to the static methods and served as a convenience factor. With the addition of the static methods, many of them no longer need an actual instance of the class.
PatTheMav
approved these changes
Sep 17, 2026
Member
|
LGTM, please squash commits. |
Warchamp7
force-pushed
the
idian-refactor
branch
from
September 18, 2026 03:53
04509c0 to
084dc12
Compare
Member
Author
|
Commits squashed now. |
RytoEX
requested changes
Sep 18, 2026
Uses Qt's QGlobalStatic macro to create a shared Utils singleton for repolishing widgets. This means that multiple calls to the Utils' styling class helpers only trigger a single repolish per widget during a one tick of the Qt event loop.
Warchamp7
force-pushed
the
idian-refactor
branch
from
September 18, 2026 19:01
084dc12 to
bfa6fe2
Compare
RytoEX
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors the Idian widgets based after some slight usage in other PRs.
This has been extracted out from #13433
Motivation and Context
The idian widgets were built when we had a much lower understanding of how Qt expects you to build custom complex widgets and without a direct use-case.
They were also built far too rigid for what every attempted use of them thus far has necessitated. These changes break them into simpler 'pieces' and provide getters for internals that are intended to be accessed.
How Has This Been Tested?
Included in #13433
Types of changes
Checklist: