Fix: ERR_PNPM_RECURSIVE_EXEC_FIRST_FAIL Command "prebuild:developme…" and gradle plugin issue with java version - #371
Merged
Conversation
✅ Deploy Preview for obytes-starter canceled.
|
yjose
self-requested a review
October 17, 2024 17:51
yjose
approved these changes
Oct 17, 2024
yjose
left a comment
Member
There was a problem hiding this comment.
Sounds good, thank you @mrpmohiburrahman for your work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
It fixes this issue #370 and #372
Why did you do this?
I have added
prebuild:developmentscript on package.jsonand added
java-version: '17'in here.github/actions/setup-jdk-generate-apk/action.ymlWho/what does this impact?
Other than solving the issue, It should not affect any other parts of this template.
How did you test this?
I have tested with my project.