Skip to content
This repository was archived by the owner on Aug 22, 2023. It is now read-only.

feature/decorators - #57

Open
IKatsuba wants to merge 5 commits into
oclif:mainfrom
IKatsuba:feature/decorators
Open

feature/decorators#57
IKatsuba wants to merge 5 commits into
oclif:mainfrom
IKatsuba:feature/decorators

Conversation

@IKatsuba

Copy link
Copy Markdown

Added decorators for key parameters of the Command class. This improves auto-completion, and also guarantees correct type checking when compiling TS.

Added decorators for key parameters of the class Command
@salesforce-cla

Copy link
Copy Markdown

Thanks for the contribution! Before we can merge this, we need @IKatsuba to sign the Salesforce.com Contributor License Agreement.

@codecov

codecovBot commented Apr 5, 2019

Copy link
Copy Markdown

Codecov Report

Merging #57 into master will increase coverage by 69.10%.
The diff coverage is 87.50%.

Impacted file tree graph

@@ Coverage Diff @@## master #57 +/- ##
===========================================
+ Coverage 0.00% 69.10% +69.10% 
===========================================
Files 1 6 +5 Lines 10 178 +168 Branches 2 35 +33 ===========================================
+ Hits 0 123 +123 - Misses 10 35 +25 - Partials 0 20 +20 
Impacted FilesCoverage Δ
src/decorators.ts86.66% <86.66%> (ø)
src/index.ts78.94% <100.00%> (+78.94%)⬆️
src/main.ts61.53% <0.00%> (ø)
src/util.ts38.88% <0.00%> (ø)
src/command.ts76.25% <0.00%> (ø)
src/flags.ts55.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b018bb6...3562386. Read the comment docs.

@IKatsuba

Copy link
Copy Markdown
Author

Any update on this?

@IKatsuba
IKatsuba requested a review from jdxJanuary 29, 2020 13:01
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@IKatsuba