chore(meta): follow the product-group rename into crates.io keywords - #329
Open
LKSNDRTMLKV wants to merge 1 commit into
Open
LKSNDRTMLKV wants to merge 1 commit into
LKSNDRTMLKV wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two words, and a deadline.
The rename stopped at the manifest
#184 renamed sector to product group across the workspace. The source
followed — the only remaining hits are a doc note recording the rename itself and
the CELEX sector letter, which is a real EUR-Lex term and unrelated.
The published metadata did not:
Confirmed live on crates.io, not just in the tree.
So the two crates that define what a product group plugin is are indexed
under a word the project abandoned — and
sectoris one of only fivekeyword slots, spent on a term nobody searching for this will type.
🚨 Why this cannot wait for a later cleanup
crates.io keywords are fixed per published version. They cannot be edited
retroactively; they change only when a new version is published. If 0.21.0 ships
as-is,
sectoris the public vocabulary for another release cycle.That makes this a pre-release fix rather than a tidy-up — the same shape as
#328, and cheaper.
The change
"sector"→"product-group"in both manifests. Nothing else: no slot added, noother keyword touched, no description reworded.
Verified against the crates.io constraints — 5 keywords maximum, ≤20 characters
each,
[A-Za-z0-9_-]only. Both manifests pass, andcargo metadataparses.Verification
just checkgreen, 1555/1555.Noticed, not fixed here
dpp-engines GitHub repository topics containeu-compl— a truncatedeu-compliance, whichdpp-corecarries correctly. Nobody browses that topic,so the tag is inert.
It is a repository setting rather than a file, so it does not belong in a
pull request and I have not changed it. The fix, if you want it:
Note that
dpp-enginedeliberately lacks theopen-sourcetopic thatdpp-corehas. That is correct — the engine is source-available under BSL,not open-source — and the command above preserves the omission.