chore(ci): scope the workflow token and cancel superseded runs - #380
Open
LKSNDRTMLKV wants to merge 1 commit into
Open
LKSNDRTMLKV wants to merge 1 commit into
LKSNDRTMLKV wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P4/P6 of the check-coverage audit, applied here. Small and mechanical.
Found by
tools/check-ci-parity.sh— a cross-repo drift report added in thedocs repo after a single audit turned up four separate cases of a fix being made
in one repository and never reaching its sibling.
This repo came back green on almost everything: actions all SHA-pinned, one CI
run per change,
Cargo.lockcommitted,deny.tomlpresent. It is thereference the others were brought up to. Two gaps remained.
permissions:onci.ymlandfuzz.ymlNeither had a block, so every job inherited the repository default token scope.
Both only read the tree, build and test — nothing writes.
release.ymlis leftexactly as it is: it publishes images and correctly declares
packages: write, which is the point of having the block rather than a blanketrule.
concurrencyonci.ymlA rebase or a follow-up push left the superseded run going to completion. Now
cancelled — except on
main, deliberately: the post-merge run is the record forthat commit, and cancelling it would leave a merged commit never fully built.
Verification
All four workflow files parse and now carry a
permissionsblock. No job logic,no dependency and no build step touched, so CI on this PR is the check.