Skip to content

[IMP] l10n_fi: Add new 13.5 VAT rate - #5222

Open
Tom-Hermann wants to merge 1 commit into
19.0-onboarding-august-malbfrom
19.0-l10n_fi-onboarding-change-VAT-rate-toher
Open

[IMP] l10n_fi: Add new 13.5 VAT rate#5222
Tom-Hermann wants to merge 1 commit into
19.0-onboarding-august-malbfrom
19.0-l10n_fi-onboarding-change-VAT-rate-toher

Conversation

@Tom-Hermann

@Tom-HermannTom-Hermann commented Aug 6, 2026

Copy link
Copy Markdown

Add new tax rate of 13.5:
Duplicate tax rate of 14 but change the rate to 13.5 for the new one

Add new tax group: tax_group_13_5:
New tax group base on tax_group_25_5

Add new tax to the tax report:
Change base on the 25.5 and 24 tax

Task id:6438991

@robodoo

Copy link
Copy Markdown

This PR targets the un-managed branch odoo-dev/odoo:19.0-onboarding-august-malb, it needs to be retargeted before it can be merged.

@Tom-Hermann
Tom-Hermannforce-pushed the 19.0-l10n_fi-onboarding-change-VAT-rate-toher branch from c112958 to ffb889fCompareAugust 6, 2026 08:41

@SaddemAmineSaddemAmine left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR Tom!
Don't forget to use the right commit title tag as per our git contribution guidelines

Also don't forget the 2nd part of the spec, changing the tax report export.

"","","","","","","","","","","tax","invoice","account_2930","fi_302","","","","","",""
"","","","","","","","","","","base","refund","","","","","","","",""
"","","","","","","","","","","tax","refund","account_2930","fi_302","","","","","",""
"tax_dom_sales_goods_13_5","13.5%","","13.5%","13.5.0","tax_group_13_5","sale","percent","False","","base","invoice","","","","","13.5%","eu_no_vat,finland","",""

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the extra .0 ?
Also wondering if we should leave it active? Why are you setting it to False?

Suggested change
"tax_dom_sales_goods_13_5","13.5%","","13.5%","13.5.0","tax_group_13_5","sale","percent","False","","base","invoice","","","","","13.5%","eu_no_vat,finland","",""
"tax_dom_sales_goods_13_5","13.5%","","13.5%","13.5","tax_group_13_5","sale","percent","","","base","invoice","","","","","13.5%","eu_no_vat,finland","",""

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment about the amount and active for the rest of the file

Add new tax rate of 13.5:
Duplicate tax rate of 14 but change the rate to 13.5 for the new one
Add new tax group: tax_group_13_5:
New tax group base on tax_group_25_5
Add new tax to the tax report:
Change base on the 25.5 and 24 tax
@Tom-Hermann
Tom-Hermannforce-pushed the 19.0-l10n_fi-onboarding-change-VAT-rate-toher branch from ffb889f to 23f0230CompareAugust 11, 2026 15:13
@Tom-Hermann

Copy link
Copy Markdown
Author

Regarding the second part (modifying the tax report), isn't the change made to the file addons/l10n_fi/data/account_tax_report_line.xml sufficient?
Because if not, I really don't understand what I need to change.

@Tom-HermannTom-Hermann changed the title [ADD] l10n_fi: Add new 13.5 VAT rate[IMP] l10n_fi: Add new 13.5 VAT rateAug 13, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Tom-Hermann@robodoo@SaddemAmine