Uh oh!
There was an error while loading. Please reload this page.
use node 16 - #200
Merged
Merged
Conversation
will-moore
commented
Jan 12, 2023
Member
Is there a reason to pick node v16 specifically? |
MemberAuthor
The reason I picked 16 is to match https://github.com/ome/omero-figure/blob/master/.omeroci/app-deps |
will-moore
commented
Jan 12, 2023
Member
Ah - I see https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-web/1533/console just failed with my figure PR: ome/omero-figure#477 I have been developing with this version locally: |
will-moore
commented
Jan 12, 2023
Member
I've reverted that figure PR to "draft" (until node is updated) so as not to break the omero-web job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades the node version.
This has been tested in the upgraded CI.