You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
…port shadow
evalIfExpr used to re-parse the original formula's condition/then/else snippets
(tryEvaluateIfFromSource -> P4IfSourceSupport, a char-scanning re-parse with
findMatching/charAt) and only fall back to eval(node.condition())/eval(branch).
That source shadow was a correctness crutch from when mapped IfExpr sub-trees were
unfaithful. With the mapper fixes (#43/#32/#35/#49) and packrat memoization now
default-on, the condition/branch nodes evaluate correctly on their own.
- evalIfExpr is now pure-AST (eval condition, pick branch, eval branch).
- Deleted the now-dead tryEvaluateIfFromSource and the P4IfSourceSupport class
(the largest remaining char-scanning source-reparse shadow).
Verified: full suite 633 tests, 0 failures/errors; baseline gate green (no new
failures) with the shadow removed — i.e. the pure-AST if path is faithful.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…port shadow (#52)
evalIfExpr used to re-parse the original formula's condition/then/else snippets
(tryEvaluateIfFromSource -> P4IfSourceSupport, a char-scanning re-parse with
findMatching/charAt) and only fall back to eval(node.condition())/eval(branch).
That source shadow was a correctness crutch from when mapped IfExpr sub-trees were
unfaithful. With the mapper fixes (#43/#32/#35/#49) and packrat memoization now
default-on, the condition/branch nodes evaluate correctly on their own.
- evalIfExpr is now pure-AST (eval condition, pick branch, eval branch).
- Deleted the now-dead tryEvaluateIfFromSource and the P4IfSourceSupport class
(the largest remaining char-scanning source-reparse shadow).
Verified: full suite 633 tests, 0 failures/errors; baseline gate green (no new
failures) with the shadow removed — i.e. the pure-AST if path is faithful.
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unlaxer-dsl 3.0.9(parser PR #48)採用。ネスト slice の value 解決を AST 経路で完成(多ルール plain dispatch + bounded capture fallback)。consumer 変更なし(純 codegen・AST 型不変)。pom のみ 3.0.9 に。
検証
mvn compile(release 3.0.9)成功。注: Central→repo1 同期ラグで CI 一時赤の可能性。
🤖 Generated with Claude Code