Skip to content

docs: fix links to the openfeature ecosystem page - #432

Merged
beeme1mr merged 2 commits into
open-feature:mainfrom
therb1:patch-1
Feb 5, 2025
Merged

docs: fix links to the openfeature ecosystem page#432
beeme1mr merged 2 commits into
open-feature:mainfrom
therb1:patch-1

Conversation

@therb1

@therb1therb1 commented Feb 5, 2025

Copy link
Copy Markdown
Contributor

This PR

  1. The parameter in the form has changed from python to Python.
    Now the link from readme.md goes to a blank page.

  2. I also added end_slash to the link, if the site does it, then why not do it right away.

Notes

This is not a problem_PROBLEM, but if it can be fixed, why not fix it.

Follow-up Tasks

How to test

Chrome incognito mode

@therb1
Update README.md
0581fa5
Because of the missing slash before the parameters, the site does not perceive the request correctly. The site adds the slash it needs to the request, but ignores the parameters passed. And when clicking on the link from the readme file, the user sees a blank page. This is not a problem_PROBLEM, but if it can be fixed, why not fix it.
The problem is reproduced on Chrome and Edge browsers
Signed-off-by: Maxim <therb1@mail.com>
@beeme1mrbeeme1mr changed the title Update README.mddocs: fix links to the openfeature ecosystem pageFeb 5, 2025
@beeme1mr

beeme1mr commented Feb 5, 2025

Copy link
Copy Markdown
Member

Hey @therb1, good catch and thanks for the PR. Could you please also update the link in the hooks section? That's also invalid.

@codecov

codecovBot commented Feb 5, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (fe0fea1) to head (90de0a3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #432 +/- ##
=======================================
Coverage 97.55% 97.55% =======================================
Files 31 31 Lines 1393 1393 =======================================
Hits 1359 1359 Misses 34 34
FlagCoverage Δ
unittests97.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@therb1

therb1 commented Feb 5, 2025

Copy link
Copy Markdown
ContributorAuthor

Hey @therb1, good catch and thanks for the PR. Could you please also update the link in the hooks section? That's also invalid.

No problem, give me couple minutes

@therb1

therb1 commented Feb 5, 2025

Copy link
Copy Markdown
ContributorAuthor

@beeme1mr where did the documentation move?
I found another broken link docs/reference/concepts/evaluation-context

@therb1
Update README.md
90de0a3
fix example hooks url
Signed-off-by: Maxim <therb1@mail.com>
@therb1

therb1 commented Feb 5, 2025

Copy link
Copy Markdown
ContributorAuthor

I corrected the link to hooks.

@beeme1mr

beeme1mr commented Feb 5, 2025

Copy link
Copy Markdown
Member

Hey @therb1, the main docs can be found in this repo.

@beeme1mr
beeme1mr merged commit 49edce2 into open-feature:mainFeb 5, 2025
@openfeaturebotopenfeaturebot mentioned this pull request Feb 5, 2025
Merged
This was referenced Feb 5, 2025
Closed
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beeme1mrbeeme1mrbeeme1mr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@therb1@beeme1mr