Skip to content

Patch 1 - #437

Closed
therb1 wants to merge 3 commits into
open-feature:mainfrom
therb1:patch-1
Closed

Patch 1#437
therb1 wants to merge 3 commits into
open-feature:mainfrom
therb1:patch-1

Conversation

@therb1

Copy link
Copy Markdown
Contributor

@beeme1mr You merge it too fast =)
here is 1 more fix docs

Because of the missing slash before the parameters, the site does not perceive the request correctly. The site adds the slash it needs to the request, but ignores the parameters passed. And when clicking on the link from the readme file, the user sees a blank page. This is not a problem_PROBLEM, but if it can be fixed, why not fix it.
The problem is reproduced on Chrome and Edge browsers
Signed-off-by: Maxim <therb1@mail.com>
fix example hooks url
Signed-off-by: Maxim <therb1@mail.com>
fix evaluation-context docs link
Signed-off-by: Maxim <therb1@mail.com>
@therb1therb1 closed this Feb 5, 2025
@codecov

codecovBot commented Feb 5, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (fe0fea1) to head (8fa408c).
Report is 4 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #437 +/- ##
=======================================
Coverage 97.55% 97.55% =======================================
Files 31 31 Lines 1393 1393 =======================================
Hits 1359 1359 Misses 34 34 
FlagCoverage Δ
unittests97.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@therb1