Skip to content

chore: split eval and resolution details objects, adjust providers accordingly - #103

Merged
beeme1mr merged 2 commits into
open-feature:mainfrom
mowies:evaluation-resolution-split
Apr 24, 2023
Merged

chore: split eval and resolution details objects, adjust providers accordingly#103
beeme1mr merged 2 commits into
open-feature:mainfrom
mowies:evaluation-resolution-split

Conversation

@mowies

@mowiesmowies commented Apr 20, 2023•
edited
Loading

Copy link
Copy Markdown
Member

This PR

  • adds a new FlagResolutionDetails class according to the spec
  • makes use of the new class in the abstract provider and the no_op provider instead of using EvaluationDetails

Fixes#97

@mowies
chore: split eval and resolution details objects, adjust providers ac…
84231da
…cordingly
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
remove unused import
3758aa4
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@codecov

codecovBot commented Apr 20, 2023

Copy link
Copy Markdown

Codecov Report

Merging #103 (3758aa4) into main (5259dcf) will increase coverage by 0.26%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## main #103 +/- ##
==========================================
+ Coverage 92.66% 92.93% +0.26% 
==========================================
Files 19 20 +1 Lines 341 354 +13 ==========================================
+ Hits 316 329 +13 
Misses 25 25
FlagCoverage Δ
unittests92.93% <100.00%> (+0.26%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted FilesCoverage Δ
open_feature/flag_evaluation/resolution_details.py100.00% <100.00%> (ø)
open_feature/provider/no_op_provider.py100.00% <100.00%> (ø)
open_feature/provider/provider.py75.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mowies
mowies marked this pull request as ready for review April 20, 2023 08:25
thisthat
thisthat reviewed Apr 21, 2023
View reviewed changes
Comment threadopen_feature/provider/no_op_provider.py
Comment threadopen_feature/flag_evaluation/resolution_details.py
thisthat
thisthat approved these changes Apr 24, 2023
View reviewed changes

@thisthatthisthat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beeme1mr
beeme1mr merged commit 68b4796 into open-feature:mainApr 24, 2023
@mowies
mowies deleted the evaluation-resolution-split branch April 24, 2023 13:00
kikihakiem pushed a commit to ResalApps/openfeature-python-sdk that referenced this pull request Aug 28, 2025
@aepfli
fix: object resolution for RPC and Object types, add test-harness. (o…
ca76802
…pen-feature#103)
fix: object resolution for RPC and Object types, add test-harness
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beeme1mrbeeme1mrbeeme1mr approved these changes
+2 more reviewers
@thisthatthisthatthisthat approved these changes
@james-milliganjames-milliganjames-milligan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Separate EvaluationDetails from ResolutionDetails

4 participants

@mowies@beeme1mr@thisthat@james-milligan