Uh oh!
There was an error while loading. Please reload this page.
fix: object client methods can receive dict or list as default_value - #134
Conversation
Codecov Report
@@ Coverage Diff @@## main #134 +/- ##
=======================================
Coverage 93.09% 93.09% =======================================
Files 20 20 Lines 362 362 =======================================
Hits 337 337 Misses 25 25
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hlipsig
left a comment
There was a problem hiding this comment.
LGTM I don't see anything wrong with it from a code perspective. This change is straighforward and easy to understand. I'm double checking there's not any obscure reason in our codebase that this shouldn't be done.
Kavindu-Dodan
commented
Jul 5, 2023
@federicobond can we add few test cases to cover this scenario ? This will help to validate this change as well as not break this with future changes |
federicobond
commented
Jul 5, 2023
@Kavindu-Dodan sure! Not sure what kind of tests are you referring to, but I did update the one I found that was missing the list case. |
federicobond
commented
Jul 5, 2023
To get proper type testing we would have to run mypy or some other typechecker in some example code, but I think this exceeds the scope of this pull request. |
Signed-off-by: Federico Bond <federicobond@gmail.com>
federicobond
commented
Jul 6, 2023
Replaced get_object_value for get_object_details in test case. Everything should be green now. |
Kavindu-Dodan
commented
Jul 6, 2023
Sorry for not being specific. I was referring to the handling list type and seems you already added that. |
…schemas digest to b81a56e (open-feature#134) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This PR
Updates client object methods to accept dict or list as default value.