Skip to content

feat: implement api-level hooks - #139

Merged
beeme1mr merged 1 commit into
open-feature:mainfrom
federicobond:api-hooks
Jul 10, 2023
Merged

feat: implement api-level hooks#139
beeme1mr merged 1 commit into
open-feature:mainfrom
federicobond:api-hooks

Conversation

@federicobond

Copy link
Copy Markdown
Member

This PR

Implements API-level hooks as defined in the spec.

Related Issues

Resolves#72

Follow-up Tasks

Additional testing around hook evaluation for the OpenFeatureClient is necessary but I wanted to avoid scope creep for this pull request.

@federicobond
federicobondforce-pushed the api-hooks branch 4 times, most recently from cda5e95 to 1aa9af4CompareJuly 8, 2023 01:19
@codecov

codecovBot commented Jul 8, 2023

Copy link
Copy Markdown

Codecov Report

Merging #139 (c2f8224) into main (571f5eb) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## main #139 +/- ##
==========================================
+ Coverage 93.02% 93.21% +0.18% 
==========================================
Files 20 21 +1 Lines 373 383 +10 ==========================================
+ Hits 347 357 +10 
Misses 26 26 
FlagCoverage Δ
unittests93.21% <100.00%> (+0.18%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted FilesCoverage Δ
open_feature/hooks/__init__.py100.00% <100.00%> (ø)
open_feature/open_feature_client.py95.91% <100.00%> (+0.04%)⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@federicobond
federicobondforce-pushed the api-hooks branch 2 times, most recently from 9a65b07 to c6b1a40CompareJuly 8, 2023 03:36
Signed-off-by: Federico Bond <federicobond@gmail.com>
@federicobond

Copy link
Copy Markdown
MemberAuthor

Rebased on top of latest main. Should be clean to merge now.

@beeme1mr
beeme1mr merged commit 7fe511f into open-feature:mainJul 10, 2023
@github-actionsgithub-actionsBot mentioned this pull request Jul 10, 2023
@federicobond
federicobond deleted the api-hooks branch July 10, 2023 17:07
kikihakiem pushed a commit to ResalApps/openfeature-python-sdk that referenced this pull request Aug 28, 2025
….5 (open-feature#139)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement API-level hooks

5 participants

@federicobond@beeme1mr@Kavindu-Dodan@tcarrio@toddbaert