Uh oh!
There was an error while loading. Please reload this page.
refactor: make Reason enum values instances of str - #142
Merged
Conversation
federicobondforce-pushed
the
strenum
branch
3 times, most recently
from
July 11, 2023 14:09
bf8ebec to
5be2ae4CompareSigned-off-by: Federico Bond <federicobond@gmail.com>
Codecov Report
@@ Coverage Diff @@## main #142 +/- ##
=======================================
Coverage 93.26% 93.26% =======================================
Files 21 22 +1 Lines 386 386 =======================================
Hits 360 360 Misses 26 26
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
beeme1mr
approved these changes
Jul 11, 2023
hlipsig
approved these changes
Jul 12, 2023
hlipsig
left a comment
Collaborator
There was a problem hiding this comment.
I don't have any concerns here. This is a good change.
kikihakiem pushed a commit
to ResalApps/openfeature-python-sdk
that referenced
this pull request
Aug 28, 2025
…-feature#142) Signed-off-by: atmask <benjaminajm@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Is a refinement on #126. In particular, it makes Reason values also instances of str, and thus directly comparable without having to access the
.valueproperty, and without having to define custom getters and setters in dataclasses.The motivation for this was to fix a
no-redefissue reported by mypy in the FlagEvaluationDetails definition:StrEnumis available since Python 3.11 so it requires a minimal backport for earlier Python versions.