Uh oh!
There was an error while loading. Please reload this page.
Conversation
Signed-off-by: gruebel <anton.gruebel@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #441 +/- ##
=======================================
Coverage 97.71% 97.71% =======================================
Files 32 32 Lines 1621 1621 =======================================
Hits 1584 1584 Misses 37 37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: gruebel <anton.gruebel@gmail.com>
gruebel
commented
Feb 7, 2025
@beeme1mr should we release it as 0.8 version or is 0.7.6 ok too? |
beeme1mr
commented
Feb 7, 2025
I'm fine with that and recommending keeping it a breaking change so we can it's very obvious in the release notes. I'm just wondering if we should release the async changes before merging this. |
beeme1mr
commented
Feb 7, 2025
Python 3.8 EOL was 2024-10-07. |
gruebel
commented
Feb 7, 2025
@beeme1mr yeah I thought about the same thing. I'm somehow more inclined to put the async change with this together into the first 0.8.0 version. It is technically not a breaking change, but still quite a big new feature. |
beeme1mr
commented
Feb 7, 2025
Sure, either way works for me. We should give folks a few days to let us know if dropping 3.8 is fine. Let's aim for merging this early next week unless we run into any blockers. |
This PR
mypydropped 3.8 support in its latest version and the flagd test suite will benefit from it