Skip to content

chore: resolve open dependabot security alerts - #426

Open
jonathannorris wants to merge 2 commits into
mainfrom
chore/dependabot-alerts-4
Open

chore: resolve open dependabot security alerts#426
jonathannorris wants to merge 2 commits into
mainfrom
chore/dependabot-alerts-4

Conversation

@jonathannorris

Copy link
Copy Markdown
Member

Summary

  • Overrode transitive toml dependency to >=4.1.2 to resolve a high severity prototype pollution vulnerability (alert Hook Specification #42)

Dependabot Alerts Resolved

Alert Package Severity Fix
#42 toml high Overrode to >=4.1.2 (resolves to 5.0.0) via npm overrides, since the vulnerable version is pulled in transitively through markdown-toc -> gray-matter@2.1.1, and markdown-toc (unmaintained, latest is 1.2.0) pins gray-matter" to ^2.1.0, which cannot resolve to a gray-matter version without the vulnerable toml dependency. Verified make markdown-toc` produces identical output with the overridden toml version.

- toml <4.1.2 -> 5.0.0 via npm override (high, alert #42)

Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
@jonathannorris
jonathannorris marked this pull request as draft September 8, 2026 13:55
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 047f3ff4-bd81-43cb-9f02-f937151c09ad

📥 Commits

Reviewing files that changed from the base of the PR and between 2875d06 and de5e410.

📒 Files selected for processing (1)
  • .markdown-link-check-config.json

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The package configuration requires toml version 4.1.2 or newer. The Markdown link-check configuration enables retries for HTTP 429 responses.

Changes

Configuration updates

Layer / File(s) Summary
toml version override
package.json
Adds an npm overrides entry that requires toml version 4.1.2 or newer.
Link-check retry configuration
.markdown-link-check-config.json
Adds retryOn429: true to retry requests that receive HTTP 429 responses.

Priority: ⬆️ High

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to de5e4

This updates dependency resolution and retries rate-limited Markdown links, reducing vulnerability exposure and transient link-check failures without an identified merge-readiness risk.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The linked issue [#42] requires a hook specification. The changeset instead updates the toml dependency and adds retryOn429 configuration. It does not address the linked issue requirements. Link the pull request to the correct Dependabot or security-alert issue, or add changes that satisfy issue [#42]'s hook specification requirements.
Out of Scope Changes check ⚠️ Warning The package.json toml override and retryOn429 configuration are unrelated to the linked hook specification issue [#42]. Remove the unrelated dependency and Markdown link configuration changes, or update the linked issue to the correct security-alert objective.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately identifies the primary change: resolving a dependency security alert through dependency configuration updates.
Description check ✅ Passed The description explains the transitive toml vulnerability, the npm override, and the verification performed. It is related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
  • Fix all pre-merge checks with AI

Comment @coderabbitai help to get the list of available commands.

@jonathannorris

Copy link
Copy Markdown
Member Author

@copilot fix the json-lint CI failure

Co-authored-by: jonathannorris <1219069+jonathannorris@users.noreply.github.com>

Copilot AI commented Sep 8, 2026

Copy link
Copy Markdown

@copilot fix the json-lint CI failure

Fixed in de5e410 by enabling retryOn429 in the markdown link checker configuration, so transient Slack rate limiting no longer fails make lint.

@jonathannorris
jonathannorris marked this pull request as ready for review September 8, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants