Skip to content

Update French Principles and Glossary files - #84

Merged
scottrigby merged 10 commits into
open-gitops:mainfrom
juliafmorgado:main
Aug 14, 2024
Merged

Update French Principles and Glossary files#84
scottrigby merged 10 commits into
open-gitops:mainfrom
juliafmorgado:main

Conversation

@juliafmorgado

@juliafmorgadojuliafmorgado commented Aug 13, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Signed-off-by: Julia Furst Morgado juliafmorgado@gmail.com

Related to #77

@juliafmorgadojuliafmorgado mentioned this pull request Aug 13, 2024
Open
8 tasks
@scottrigby

scottrigby commented Aug 14, 2024

Copy link
Copy Markdown
Member

thanks so much! would you please fix the DCO sign-off? The DCO bot check gives step by step instructions. Ping me if i can help with that.

@scottrigbyscottrigby mentioned this pull request Aug 14, 2024
Closed
@juliafmorgado
update principles_fr
d0d8387
Signed-off-by: Julia Furst Morgado <juliafmorgado@gmail.com>
@juliafmorgado
update glossary_fr
9805095
Signed-off-by: Julia Furst Morgado <juliafmorgado@gmail.com>
@scottrigby

scottrigby commented Aug 14, 2024

Copy link
Copy Markdown
Member

Thanks for fixing DCO - and for noticing this repo's CONTRIBUTING guidelines doens't mention that as a requirement! Our GitHub org's default contributing file does, but the repo-specific one overrides that, so we need to fix that. I opened an issue to track that:

Anyway, we now just need another French speaker to review this PR 😄

lrochette
lrochette suggested changes Aug 14, 2024
View reviewed changes

@lrochettelrochette left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments

Comment threadi18n/GLOSSARY_fr.md
Comment threadi18n/GLOSSARY_fr.md
Comment threadi18n/GLOSSARY_fr.md Outdated
Comment threadi18n/GLOSSARY_fr.md Outdated
Comment threadi18n/GLOSSARY_fr.md Outdated
Comment threadi18n/PRINCIPLES_fr.md Outdated
@juliafmorgado
Update GLOSSARY_fr.md
7f82d45
Implement lrochette's recommendations
Signed-off-by: Julia Furst Morgado <52685951+juliafmorgado@users.noreply.github.com>
@juliafmorgado
Update PRINCIPLES_fr.md
49b4210
Signed-off-by: Julia Furst Morgado <52685951+juliafmorgado@users.noreply.github.com>
@juliafmorgado
Update PRINCIPLES_fr.md
c7b2a2c
Signed-off-by: Julia Furst Morgado <52685951+juliafmorgado@users.noreply.github.com>
@juliafmorgado
Update GLOSSARY_fr.md
459c591
Signed-off-by: Julia Furst Morgado <52685951+juliafmorgado@users.noreply.github.com>
@juliafmorgado
Update PRINCIPLES_fr.md
92ea299
Signed-off-by: Julia Furst Morgado <52685951+juliafmorgado@users.noreply.github.com>
@juliafmorgado
Update PRINCIPLES_fr.md
93e7883
Signed-off-by: Julia Furst Morgado <52685951+juliafmorgado@users.noreply.github.com>
@juliafmorgado
Update GLOSSARY_fr.md
45d4c82
Signed-off-by: Julia Furst Morgado <52685951+juliafmorgado@users.noreply.github.com>
@juliafmorgado
Update GLOSSARY_fr.md
3c0a932
Signed-off-by: Julia Furst Morgado <52685951+juliafmorgado@users.noreply.github.com>
lrochette
lrochette approved these changes Aug 14, 2024
View reviewed changes

@lrochettelrochette left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

scottrigby
scottrigby approved these changes Aug 14, 2024
View reviewed changes

@scottrigbyscottrigby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @juliafmorgado and @lrochette 🤝 🙌

@scottrigby
scottrigby merged commit 8be046e into open-gitops:mainAug 14, 2024
@scottrigbyscottrigby linked an issue Jul 16, 2025 that may be closed by this pull request
GitOps principles 1.0 translations #53
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scottrigbyscottrigbyscottrigby approved these changes
+1 more reviewer
@lrochettelrochettelrochette approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GitOps principles 1.0 translations

3 participants

@juliafmorgado@scottrigby@lrochette