Skip to content

[CODE HEALTH] clang-tidy warnings in baggage.h #3980

Description

@dbarker

clang-tidy reports the following warnings in baggage.h


opentelemetry-cpp/api/include/opentelemetry/baggage/baggage.h (3 warnings)

Line Check Message
238 cppcoreguidelines-narrowing-conversions narrowing conversion from 'int' to signed type 'char' is implementation-defined
239 cppcoreguidelines-narrowing-conversions narrowing conversion from 'int' to signed type 'char' is implementation-defined
270 cppcoreguidelines-narrowing-conversions narrowing conversion from 'int' to signed type 'char' is implementation-defined

To reproduce locally run the following in the development container:

export CXX_STANDARD=14
./ci/do_ci.sh cmake.clang_tidy.test

The markdown report with unique errors can be generated locally after building with the ci/create_clang_tidy_report.py script.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood for newcomershelp wantedGood for taking. Extra help will be provided by maintainerstriage/acceptedIndicates an issue or PR is ready to be actively worked on.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions