Skip to content

[CONFIGURATION] Implement ComposableSampler Extensions #4409

Description

@marcalff

In the yaml schema spec:

  ExperimentalComposableSampler:
    type: object
    additionalProperties: <------------------------------------------------------------------- HERE
      type:
        - object
        - "null"
    minProperties: 1
    maxProperties: 1
    properties:
      always_off:
        $ref: "#/$defs/ExperimentalComposableAlwaysOffSampler"
        description: Configure sampler to be always_off.
        defaultBehavior: ignore
      always_on:
        $ref: "#/$defs/ExperimentalComposableAlwaysOnSampler"
        description: Configure sampler to be always_on.
        defaultBehavior: ignore
      parent_threshold:
        $ref: "#/$defs/ExperimentalComposableParentThresholdSampler"
        description: |
          Configure sampler to be parent_threshold.
        defaultBehavior: ignore
      probability:
        $ref: "#/$defs/ExperimentalComposableProbabilitySampler"
        description: Configure sampler to be probability.
        defaultBehavior: ignore
      rule_based:
        $ref: "#/$defs/ExperimentalComposableRuleBasedSampler"
        description: Configure sampler to be rule_based.
        defaultBehavior: ignore

composable samplers can ALSO be an extension point (additionalProperties).

This was missed when fixing #4028.

Applications should be allowed to add a custom composable sampler.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomershelp wantedGood for taking. Extra help will be provided by maintainerstriage/acceptedIndicates an issue or PR is ready to be actively worked on.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions