Skip to content

[CMAKE] Clean up pkgconfig install methods and add tests #4503

Description

@dbarker

Background:

This issue is to track work addressing #3829 (comment)

The opentelemetry_add_pkgconfig CMake function creates and installs pkgconfig files per CMake target.

Currently this method is invoked for each target with the target name, a description, and dependencies. The corresponding pkgconfig files are only superficially verified in CI and are not used to compile any tests or examples. Regressions in pkgconfig support can be easily missed.

The otel_add_component function creates the install components for the opentelemetry-cpp CMake package. This method can be updated to accept a description and to create the pkgconfig files for each target in the component.

Scope:

  1. Add a description arg to otel_add_component
  2. Add the pkgconfig file install functionality to otel_add_component
  3. Add a CMake based pkgconfig test for the generated pkgconfig files against the install test files (./install/test/src)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    triage/acceptedIndicates an issue or PR is ready to be actively worked on.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions