Jaeger: ThriftSender unit test - #1162
Merged
ThomsonTan merged 8 commits intoJan 3, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1162 +/- ##
==========================================
+ Coverage 93.25% 93.26% +0.02%
==========================================
Files 173 173
Lines 6362 6362
==========================================
+ Hits 5932 5933 +1
+ Misses 430 429 -1
|
esigo
marked this pull request as ready for review
December 22, 2021 18:52
lalitb
approved these changes
Dec 27, 2021
Member
Member
Author
bjosv
approved these changes
Jan 3, 2022
bjosv
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Sorry for late response.
ThomsonTan
approved these changes
Jan 3, 2022
This was referenced Jan 25, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unit test to cover the memory leak issue reported in #1160
Changes
Mocks
Transportso that we can reachThriftSender::AppendwhenJaegerExporter::Exportwas called.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes