Skip to content

AttributesProcessor dtor - #1263

Merged
lalitb merged 2 commits into
open-telemetry:mainfrom
esigo:AttributesProcessor-dtor
Mar 13, 2022
Merged

AttributesProcessor dtor#1263
lalitb merged 2 commits into
open-telemetry:mainfrom
esigo:AttributesProcessor-dtor

Conversation

@esigo

@esigo esigo commented Mar 13, 2022

Copy link
Copy Markdown
Member

Fixes AttributesProcessor dtor

Changes

Adds AttributesProcessor missing virtual dtor.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@esigo
esigo requested a review from a team March 13, 2022 11:13
@codecov

codecov Bot commented Mar 13, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1263 (258ca98) into main (28bd621) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1263      +/-   ##
==========================================
+ Coverage   92.37%   92.37%   +0.01%     
==========================================
  Files         202      202              
  Lines        7335     7336       +1     
==========================================
+ Hits         6775     6776       +1     
  Misses        560      560              
Impacted Files Coverage Δ
...ntelemetry/sdk/metrics/view/attributes_processor.h 100.00% <100.00%> (ø)

@lalitb lalitb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix,

@lalitb
lalitb merged commit da94697 into open-telemetry:main Mar 13, 2022
@esigo
esigo deleted the AttributesProcessor-dtor branch March 13, 2022 16:47
DebajitDas pushed a commit to DebajitDas/opentelemetry-cpp that referenced this pull request Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants