Skip to content

MetricStorage dtors #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lalitb merged 1 commit into from
Mar 18, 2022
Merged

MetricStorage dtors #1270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,4 @@
/build

tags
.cache/clangd/*
3 changes: 3 additions & 0 deletions sdk/include/opentelemetry/sdk/metrics/state/metric_storage.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ class MetricStorage
opentelemetry::sdk::instrumentationlibrary::InstrumentationLibrary *instrumentation_library,
opentelemetry::sdk::resource::Resource *resource,
nostd::function_ref<bool(MetricData &)> callback) noexcept = 0;

virtual ~MetricStorage() = default;
};

class WritableMetricStorage
Expand All @@ -38,6 +40,7 @@ class WritableMetricStorage

virtual void RecordDouble(double value,
const opentelemetry::common::KeyValueIterable &attributes) noexcept = 0;
virtual ~WritableMetricStorage() = default;
};

class NoopMetricStorage : public MetricStorage
Expand Down