Skip to content

Link opentelemetry_ext with opentelemetry_api #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThomsonTan merged 1 commit into from
Apr 21, 2022
Merged

Link opentelemetry_ext with opentelemetry_api #1336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ext/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ target_include_directories(
"$<INSTALL_INTERFACE:include>")

set_target_properties(opentelemetry_ext PROPERTIES EXPORT_NAME "ext")
target_link_libraries(opentelemetry_ext INTERFACE opentelemetry_api)

install(
TARGETS opentelemetry_ext
Expand Down
2 changes: 1 addition & 1 deletion ext/src/http/client/nosend/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ if(${BUILD_TESTING})
endif()

target_link_libraries(http_client_nosend ${GTEST_BOTH_LIBRARIES} ${GMOCK_LIB}
opentelemetry_api opentelemetry_ext)
opentelemetry_ext)

install(
TARGETS http_client_nosend
Expand Down
5 changes: 2 additions & 3 deletions ext/src/zpages/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,8 @@ add_library(

set_target_properties(opentelemetry_zpages PROPERTIES EXPORT_NAME zpages)

target_link_libraries(
opentelemetry_zpages PUBLIC opentelemetry_ext opentelemetry_api
opentelemetry_trace)
target_link_libraries(opentelemetry_zpages PUBLIC opentelemetry_ext
opentelemetry_trace)

install(
TARGETS opentelemetry_zpages
Expand Down