Implement https://github.com/open-telemetry/opentelemetry-specification/pull/2452 by owent · Pull Request #1456 · open-telemetry/opentelemetry-cpp

owent · 2022-06-16T09:58:04Z

Follow the lastest specification changes.

Implement open-telemetry/opentelemetry-specification#2452

I also merged main nefore I start to achive this specification. It bring many changes of main branch.

Please visit https://github.com/open-telemetry/opentelemetry-cpp/pull/1456/files/b4d47e1ffd077c282a6efb86e701d383dcff7b1a..31dfd5a5bfcb17f376d878c3981ad6dbb0c312d8 to view the real changes of this PR.

Changes

Update the latest main branch.
Remove AsyncBatch*Processor
Using configure to decide whether to use async exporting.

For significant contributions please make sure you have completed the following items:

CHANGELOG.md updated for non-trivial changes
Unit tests have been added
Changes in public API reviewed

* add owent as reviewer * fix order

…mporality) (open-telemetry#1288)

…elemetry#1301) Signed-off-by: owent <admin@owent.net>

…emetry#1309) Signed-off-by: owent <admin@owent.net>

…ed. (open-telemetry#1299)

Signed-off-by: owent <admin@owent.net>

Co-authored-by: Tom Tan <Tom.Tan@microsoft.com> Co-authored-by: Lalit Kumar Bhasin <lalit_fin@yahoo.com>

…lemetry#1303)

Co-authored-by: Lalit Kumar Bhasin <lalit_fin@yahoo.com>

…o_async-changes

…metry#1408)

…metry#1425)

…alues (open-telemetry#1427) * validate histogram value * handle Nan * add changelog * divide by 0 error on windows * fix markdown lint

Signed-off-by: WenTao Ou <admin@owent.net> # Conflicts: # CHANGELOG.md

…#1400)

…etry#1347) (open-telemetry#1439)

…#1441)

…emetry#1446)

…o_async-changes

…#2452](open-telemetry/opentelemetry-specification#2452) Signed-off-by: WenTao Ou <admin@owent.net>

Signed-off-by: WenTao Ou <admin@owent.net>

codecov · 2022-06-16T10:07:21Z

Codecov Report

❗ No coverage uploaded for pull request base (async-changes@d7b03e8). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             async-changes    #1456   +/-   ##
================================================
  Coverage                 ?   84.72%           
================================================
  Files                    ?      155           
  Lines                    ?     4783           
  Branches                 ?        0           
================================================
  Hits                     ?     4052           
  Misses                   ?      731           
  Partials                 ?        0

Signed-off-by: WenTao Ou <admin@owent.net>

lalitb · 2022-06-16T22:15:38Z

+  }
+#  ifdef ENABLE_ASYNC_EXPORT
+  , asynchronous_mode_ { asynchronous_mode }
+#  endif


Just a thought - Is it necessary to keep the sync mode, or can we have async as default and only option? And ExportResult would always mean that exporter has received the event batch and uploading them. Upload may fail, in which case exporter will retry and eventually log the error.

OTLP may also need always return ExportResult::kSuccess and ignore the result of HTTP client.

Signed-off-by: WenTao Ou <admin@owent.net>

lalitb · 2022-06-17T04:55:21Z

Thanks. I have gone through this PR - https://github.com/open-telemetry/opentelemetry-cpp/pull/1456/files/b4d47e1ffd077c282a6efb86e701d383dcff7b1a..31dfd5a5bfcb17f376d878c3981ad6dbb0c312d8 - for relavant changes, and it looks good to me. I think you should be able to merge this to the async-changes branch right?

esigo and others added 30 commits March 21, 2022 07:02

install sdk config (open-telemetry#1273)

e072daa

Bump actions/cache from 2 to 3 (open-telemetry#1277)

6ec1b59

Add owent as an Approver (open-telemetry#1276)

b5155a5

* add owent as reviewer * fix order

Disable benchmark action failure (open-telemetry#1284)

0c9aece

metrics exemplar round 1 (open-telemetry#1264)

3c7b44b

[Metrics SDK] - fix spelling (AggregationTemporarily to AggregationTe…

2c9ce39

…mporality) (open-telemetry#1288)

fix compilation error with protobuf 3.5 (open-telemetry#1289)

91b0572

Fix span SetAttribute crash (open-telemetry#1283)

c1b9590

Synchronous Metric collection (Delta , Cumulative) (open-telemetry#1265)

a7e814a

Rename http_client_curl to opentelemetry_http_client_curl (open-t…

76c664a

…elemetry#1301) Signed-off-by: owent <admin@owent.net>

Don't show coverage annotation for pull requests (open-telemetry#1304)

2034c9b

Implement periodic exporting metric reader (open-telemetry#1286)

33d9c62

Add async-changes branch to pull_request of github action (open-tel…

48a4060

…emetry#1309) Signed-off-by: owent <admin@owent.net>

Add InstrumentationInfo and Resource to the metrics data to be export…

be75bbc

…ed. (open-telemetry#1299)

Excempt should be applied on issue instead of PR (open-telemetry#1316)

237a0b2

Bump codecov/codecov-action from 2.1.0 to 3 (open-telemetry#1318)

fd338cc

Move public definitions into opentelemetry_api. (open-telemetry#1314)

74ec691

Signed-off-by: owent <admin@owent.net>

Add building test without RTTI (open-telemetry#1294)

6b87300

Remove implicitly deleted default constructor (open-telemetry#1267)

3122254

Co-authored-by: Tom Tan <Tom.Tan@microsoft.com> Co-authored-by: Lalit Kumar Bhasin <lalit_fin@yahoo.com>

[ETW Exporter] - ETW provider handle cleanup (open-telemetry#1322)

d72dcb6

Bump actions/stale from 4 to 5 (open-telemetry#1323)

e200c1f

ostream metrics example (open-telemetry#1312)

755f109

Prepare v1.3.0 release (open-telemetry#1324)

da2911c

Update yield logic for ARM processor (open-telemetry#1325)

75c2a8f

Fix for open-telemetry#1292 (open-telemetry#1326)

e7f051e

Implement Merge and Diff operation for Histogram Aggregation (open-te…

29d68f1

…lemetry#1303)

fix metrics compiler warnings (open-telemetry#1328)

e3304d7

Replace deprecated googletest API (open-telemetry#1327)

defdfd2

Remove redundant tail / in CMake install (open-telemetry#1329)

2e9b7a1

dependencies image as artifact (open-telemetry#1333)

1d2cd42

Co-authored-by: Lalit Kumar Bhasin <lalit_fin@yahoo.com>

owent and others added 19 commits May 25, 2022 12:11

Merge remote-tracking branch 'opentelemetry/main' into merge_main_int…

0abf162

…o_async-changes

[Metrics API/SDK] - Pass state to async callback function. (open-tele…

9df5c4f

…metry#1408)

Copy string_view passed to ETW exporter in PropertyVariant (open-tele…

93ef013

…metry#1425)

Fix ETW log exporter header inclusion (open-telemetry#1426)

81df64b

[Metrics SDK] Only record non-negative / finite / Non-NAN histogram v…

62b65fa

…alues (open-telemetry#1427) * validate histogram value * handle Nan * add changelog * divide by 0 error on windows * fix markdown lint

Fix global log handle symbols when using dlopen (open-telemetry#1420)

7e90dae

Merge remote-tracking branch 'opentelemetry/main' into async-changes

c484d16

Signed-off-by: WenTao Ou <admin@owent.net> # Conflicts: # CHANGELOG.md

Add attributes/dimensions to metrics ostream exporter (open-telemetry…

18991a6

…#1400)

Log current timestamp instead of epoch time (open-telemetry#1434)

473c931

install sdk-config.h (open-telemetry#1419)

4c657a1

Fix GettingStarted documentation for Jaeger HTTP exporter (open-telem…

6ee70a7

…etry#1347) (open-telemetry#1439)

fix histogram (open-telemetry#1440)

423a1a2

Upgrade nlohmann_json to 3.10.5 (open-telemetry#1438) (open-telemetry…

33567b9

…#1441)

Fixed broken link to OpenTelemetry.io (open-telemetry#1445) (open-tel…

2f0a3d6

…emetry#1446)

Merge remote-tracking branch 'opentelemetry/main' into merge_main_int…

5ce608c

…o_async-changes

Fix variables inizialization (open-telemetry#1430)

2d78a56

Merge remote-tracking branch 'opentelemetry/main' into merge_main_int…

b4d47e1

…o_async-changes

Remove AsyncBatch*Processor, implement [opentelemetry-specification…

b75089a

…#2452](open-telemetry/opentelemetry-specification#2452) Signed-off-by: WenTao Ou <admin@owent.net>

Remove invalid changelog

a4ec016

Signed-off-by: WenTao Ou <admin@owent.net>

owent requested a review from a team June 16, 2022 09:58

Fix compiling problems without ENABLE_ASYNC_EXPORT

fe77084

Signed-off-by: WenTao Ou <admin@owent.net>

owent mentioned this pull request Jun 16, 2022

Merge all commits of async-changes into main #1413

Merged

3 tasks

lalitb reviewed Jun 16, 2022

View reviewed changes

Always return ExportResult::kSuccess

31dfd5a

Signed-off-by: WenTao Ou <admin@owent.net>

lalitb approved these changes Jun 17, 2022

View reviewed changes

owent merged commit daf5091 into open-telemetry:async-changes Jun 17, 2022

owent deleted the async-changes branch June 17, 2022 06:51

Navigation Menu

Uh oh!

Implement https://github.com/open-telemetry/opentelemetry-specification/pull/2452 - #1456

Implement https://github.com/open-telemetry/opentelemetry-specification/pull/2452#1456
owent merged 93 commits into
open-telemetry:async-changesfrom
owent:async-changes

owent commented Jun 16, 2022 •

edited

Loading

Uh oh!

codecov Bot commented Jun 16, 2022 •

edited

Loading

Uh oh!

lalitb Jun 16, 2022 •

edited

Loading

Uh oh!

owent Jun 17, 2022 •

edited

Loading

Uh oh!

lalitb commented Jun 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Uh oh!

Conversation

owent commented Jun 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

codecov Bot commented Jun 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lalitb Jun 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

owent Jun 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lalitb commented Jun 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

owent commented Jun 16, 2022 •

edited

Loading

codecov Bot commented Jun 16, 2022 •

edited

Loading

lalitb Jun 16, 2022 •

edited

Loading

owent Jun 17, 2022 •

edited

Loading