Prometheus unit test - #1461
Merged
Merged
Prometheus unit test#1461
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1461 +/- ##
==========================================
+ Coverage 84.61% 84.68% +0.07%
==========================================
Files 155 155
Lines 4782 4782
==========================================
+ Hits 4046 4049 +3
+ Misses 736 733 -3
|
lalitb
reviewed
Jun 21, 2022
ThomsonTan
reviewed
Jun 23, 2022
ThomsonTan
reviewed
Jun 23, 2022
| ASSERT_EQ(res, code); | ||
| } | ||
|
|
||
| #endif // ENABLE_METRICS_PREVIEW |
Contributor
There was a problem hiding this comment.
nit: put the condition here in front of ENABLE_METRICS_PREVIEW? To imply that the previous block is in effect when ENABLE_METRICS_PREVIEW is not defined.
ThomsonTan
reviewed
Jun 23, 2022
| break; | ||
| } | ||
| case prometheus::MetricType::Untyped: | ||
| break; |
Contributor
There was a problem hiding this comment.
Put an ASSERT here as well to catch unexpected type?
lalitb
reviewed
Jun 23, 2022
Member
|
Looks like merging #1454 is failing this PR, as the otlp PR adds AggregationTemporality as part of MetricData :( |
ThomsonTan
approved these changes
Jul 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1349 (issue)
Changes
Adds unit test for Prometheus.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes