[Metrics] Add OTLP http metric exporter - #1487
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1487 +/- ##
==========================================
- Coverage 84.72% 84.66% -0.06%
==========================================
Files 156 156
Lines 4784 4784
==========================================
- Hits 4053 4050 -3
- Misses 731 734 +3
|
owent
force-pushed
the
otlp_metrics_exporter
branch
2 times, most recently
from
July 13, 2022 04:59
26a6826 to
456bd6c
Compare
3 tasks
Member
Author
|
@lalitb Could you please review this PR? |
ThomsonTan
reviewed
Jul 14, 2022
lalitb
approved these changes
Jul 14, 2022
lalitb
left a comment
Member
There was a problem hiding this comment.
LGTM. Nicely done. There are a few improvements I can see to be done for the OTLP GRPC Metrics exporter. I will raise a PR for that.
marcalff
reviewed
Jul 15, 2022
Member
|
@owent - Have some conflicts to resolve here :) |
owent
force-pushed
the
otlp_metrics_exporter
branch
from
July 16, 2022 05:32
0acfe4d to
7ef9684
Compare
Member
Author
Resloved |
ThomsonTan
reviewed
Jul 18, 2022
ThomsonTan
approved these changes
Jul 18, 2022
Member
|
@owent - Can you please rebase it, so can be merged. |
Signed-off-by: owentou <owentou@tencent.com>
Signed-off-by: owentou <owentou@tencent.com>
Signed-off-by: owentou <owentou@tencent.com>
…cUtils::PopulateRequest` Signed-off-by: owentou <owentou@tencent.com>
Signed-off-by: owentou <owentou@tencent.com>
Signed-off-by: owentou <owentou@tencent.com>
Signed-off-by: owentou <owentou@tencent.com>
owent
force-pushed
the
otlp_metrics_exporter
branch
from
July 19, 2022 06:38
7ef9684 to
4fe3069
Compare
Member
Author
Done |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1371
Changes
Shutdowntest for all OTLP HTTP exportersForceFlushforOtlpHttpClientGaugesupport forOtlpMetricUtils::PopulateRequestFor significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes