Skip to content

Add Marc Alff in cpp-approvers - #1635

Merged
lalitb merged 3 commits into
open-telemetry:mainfrom
marcalff:marc_cpp_approver
Sep 27, 2022
Merged

Add Marc Alff in cpp-approvers#1635
lalitb merged 3 commits into
open-telemetry:mainfrom
marcalff:marc_cpp_approver

Conversation

@marcalff

Copy link
Copy Markdown
Member

Add Marc Alff in cpp-approvers

Per discussion in C++ SIG Meeting, 2022-09-26.

Per discussion in C++ SIG Meeting, 2022-09-26.
@marcalff
marcalff requested a review from a team September 26, 2022 21:27
Comment thread README.md Outdated

@reyang reyang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcalff 🥳💯🥇🎆👍

@codecov

codecov Bot commented Sep 26, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1635 (32b921e) into main (5c180a1) will decrease coverage by 0.07%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1635      +/-   ##
==========================================
- Coverage   85.12%   85.06%   -0.06%     
==========================================
  Files         159      159              
  Lines        4999     4999              
==========================================
- Hits         4255     4252       -3     
- Misses        744      747       +3     
Impacted Files Coverage Δ
ext/src/http/client/curl/http_client_curl.cc 80.31% <0.00%> (-1.13%) ⬇️

@lalitb

lalitb commented Sep 27, 2022

Copy link
Copy Markdown
Member

@marcalff - Can you approve this PR too, as acceptance for the role :)

@reyang

reyang commented Sep 27, 2022

Copy link
Copy Markdown
Member

@marcalff - Can you approve this PR too, as acceptance for the role :)

Having @marcalff approving his own PR? 🤣

@lalitb

lalitb commented Sep 27, 2022

Copy link
Copy Markdown
Member

Having @marcalff approving his own PR? 🤣

Yes, we have been following this tradition for both approvers and maintainers- #410, #1276, #1183. #936

@lalitb

lalitb commented Sep 27, 2022

Copy link
Copy Markdown
Member

Having @marcalff approving his own PR? 🤣

Yes, we have been following this tradition for both approvers and maintainers- #410, #1276, #1183. #936

Oh sorry, I didn't notice this was created by @marcalff , I thought it was @esigo . Good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants