Custom Aggregation support - #1899
Merged
Merged
Conversation
lalitb
marked this pull request as draft
January 5, 2023 05:58
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1899 +/- ##
==========================================
+ Coverage 86.90% 87.12% +0.23%
==========================================
Files 165 165
Lines 4594 4596 +2
==========================================
+ Hits 3992 4004 +12
+ Misses 602 592 -10
|
Member
Author
|
@mprzybylski Have created a draft PR, if you want to test this. Haven't added all unit-test scenarios, basically blocked on #1869 to be merged before adding tests for histogram aggregation. But should be good enough to test. |
lalitb
marked this pull request as ready for review
January 18, 2023 20:59
esigo
approved these changes
Jan 22, 2023
esigo
left a comment
Member
There was a problem hiding this comment.
LGTM
just had one nit comment.
Thanks for the PR :)
lalitb
enabled auto-merge (squash)
January 23, 2023 05:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1664
Changes
This is ready to review now. With the change, it is possible to use the custom aggregator for the Instruments.
Also added tests for:
As a side change, it fixes few warning for unused variables.
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes