Skip to content

pass in library_name and library_version into meter - #232

Merged
reyang merged 2 commits into
open-telemetry:masterfrom
HudsonHumphries:meter-provider-sdk-constructor
Jul 30, 2020
Merged

reyang merged 2 commits into
open-telemetry:masterfrom
HudsonHumphries:meter-provider-sdk-constructor

Conversation

@HudsonHumphries

Copy link
Copy Markdown
Member

Simple PR to route library_name and library_version into the Meter constructor.

@HudsonHumphries
HudsonHumphries requested a review from a team July 30, 2020 18:58
@codecov

codecov Bot commented Jul 30, 2020

Copy link
Copy Markdown

Codecov Report

Merging #232 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #232   +/-   ##
=======================================
  Coverage   94.22%   94.22%           
=======================================
  Files         115      115           
  Lines        3877     3881    +4     
=======================================
+ Hits         3653     3657    +4     
  Misses        224      224           
Impacted Files Coverage Δ
...include/opentelemetry/sdk/metrics/meter_provider.h 100.00% <ø> (ø)
sdk/include/opentelemetry/sdk/metrics/meter.h 100.00% <100.00%> (ø)
sdk/src/metrics/meter_provider.cc 100.00% <100.00%> (ø)

@reyang reyang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@reyang
reyang merged commit 15b4178 into open-telemetry:master Jul 30, 2020
GerHobbelt pushed a commit to GerHobbelt/opentelemetry-cpp that referenced this pull request Jun 17, 2025
…wnload-artifact-digest

chore(deps): update actions/download-artifact digest to 95815c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants