Adding a tracer provider - #24
Conversation
|
I signed it |
|
It'll be great to point to the specification. |
|
How Serious are we about the "header only" requirement specified here: https://github.com/open-telemetry/opentelemetry-cpp/blob/master/docs/requirements.md |
Should this be tracer_factory.h with an underscore, to match e.g. string_view.h? |
Good call, will change. |
4ef274d to
8393c4d
Compare
|
This looks good. One nit: open-telemetry/oteps#76 says that we'll standardize on the term "Provider" instead or "Factory". |
Thanks, I'll update that. What do you think about making the return value of |
a7a1c57 to
14e1526
Compare
c2971b6 to
e3f463e
Compare
|
@reyang: I just rebased the branch. |
removed all TraceState references
There seems to be some movement on implementing things from spans up, so I thought I would start building from the tracer factory down.
This currently requires C++14 for its use of unique_ptrs. I know there was some talk about wanting to limit the standard to C++11, but not sure how hard this requirement is.