Skip to content

[EXPORTER] Change OTLP HTTP content_type default to binary - #2480

Closed
kkuehl wants to merge 5 commits into
open-telemetry:mainfrom
kkuehl:main
Closed

kkuehl wants to merge 5 commits into
open-telemetry:mainfrom
kkuehl:main

Conversation

@kkuehl

@kkuehl kkuehl commented Jan 9, 2024

Copy link
Copy Markdown

https://github.com/open-telemetry/opentelemetry-proto/blob/main/docs/specification.md

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@kkuehl
kkuehl requested a review from a team January 9, 2024 18:31
@linux-foundation-easycla

linux-foundation-easycla Bot commented Jan 9, 2024

Copy link
Copy Markdown

CLA Not Signed

@ThomsonTan

Copy link
Copy Markdown
Contributor

@kkuehl thanks for the contribution. Could you please sign the CLA?

Comment thread exporters/otlp/test/otlp_http_exporter_test.cc Outdated
@lalitb

lalitb commented Jan 9, 2024

Copy link
Copy Markdown
Member

Thanks for working on it. Also, please add the changelog as this is supposed to be a breaking change.

@kkuehl

kkuehl commented Jan 9, 2024

Copy link
Copy Markdown
Author

@kkuehl thanks for the contribution. Could you please sign the CLA?

I have signed the CLA (twice now), but I assume there is a manual step?

@marcalff marcalff changed the title Change content_type default from HttpRequestContentType::kJson to Htt… [EXPORTER] Change OTLP HTTP content_type default to binary Jan 9, 2024
@codecov

codecov Bot commented Jan 9, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f084fbc) 87.06% compared to head (d7168ce) 87.04%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2480      +/-   ##
==========================================
- Coverage   87.06%   87.04%   -0.01%     
==========================================
  Files         199      199              
  Lines        6087     6087              
==========================================
- Hits         5299     5298       -1     
- Misses        788      789       +1     

see 1 file with indirect coverage changes

@marcalff marcalff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch.

The spec does not say (unless I missed it) to use binary of json by default,
what is the motivation for this change ?

Comment thread CHANGELOG.md Outdated
@marcalff

marcalff commented Jan 9, 2024

Copy link
Copy Markdown
Member

/easycla

@marcalff marcalff added the pr:waiting-on-cla Waiting on CLA label Jan 9, 2024
@marcalff

Copy link
Copy Markdown
Member

@kkuehl

About the CLA, somehow the system sees two accounts : @kkuehl and @kirby-mimic

Please make sure you sign the CLA for the proper account.

This needs to be resolved, as we can not merge a PR without it.

Start over and create another clean PR if you have to.

@kkuehl kkuehl closed this by deleting the head repository Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:waiting-on-cla Waiting on CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants