Conversation
|
|
@kkuehl thanks for the contribution. Could you please sign the CLA? |
|
Thanks for working on it. Also, please add the changelog as this is supposed to be a breaking change. |
ExportBinaryIntegrationTest
I have signed the CLA (twice now), but I assume there is a manual step? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2480 +/- ##
==========================================
- Coverage 87.06% 87.04% -0.01%
==========================================
Files 199 199
Lines 6087 6087
==========================================
- Hits 5299 5298 -1
- Misses 788 789 +1 |
marcalff
left a comment
There was a problem hiding this comment.
Thanks for the patch.
The spec does not say (unless I missed it) to use binary of json by default,
what is the motivation for this change ?
|
/easycla |
|
About the CLA, somehow the system sees two accounts : @kkuehl and @kirby-mimic Please make sure you sign the CLA for the proper account. This needs to be resolved, as we can not merge a PR without it. Start over and create another clean PR if you have to. |
https://github.com/open-telemetry/opentelemetry-proto/blob/main/docs/specification.md
Fixes # (issue)
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes