Support adding links to span - #351
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #351 +/- ##
==========================================
+ Coverage 94.98% 95.00% +0.02%
==========================================
Files 162 164 +2
Lines 6997 7086 +89
==========================================
+ Hits 6646 6732 +86
- Misses 351 354 +3
|
pyohannes
reviewed
Oct 7, 2020
lalitb
marked this pull request as draft
October 15, 2020 16:28
lalitb
marked this pull request as ready for review
October 21, 2020 17:44
pyohannes
reviewed
Oct 21, 2020
pyohannes
approved these changes
Nov 11, 2020
pyohannes
left a comment
Contributor
There was a problem hiding this comment.
Thanks for diving into template metaprogramming. This looks good to me.
Member
Author
Thanks for your guidance and reviewing it. |
Member
Author
|
@reyang This should be good to merge once all the checks are completed. |
GerHobbelt
pushed a commit
to GerHobbelt/opentelemetry-cpp
that referenced
this pull request
Aug 31, 2025
…el_lib-2.x Update dependency aspect_bazel_lib to v2.19.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing old PR #342 , as this was rework. Review comments from old PR have been incorporated here.