[CONFIGURATION] File configuration - composable samplers - #3966
Conversation
Implements parser logic, SDK builder visitor instantiation, safe test patterns, and expands coverage for all composable sampler variants to resolve open-telemetry#3914. Signed-off-by: DCchoudhury15 <divyanshuchoudhury3@gmail.com>
92ed254 to
ae0c9dd
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3966 +/- ##
==========================================
+ Coverage 81.75% 81.83% +0.09%
==========================================
Files 374 389 +15
Lines 16083 16234 +151
==========================================
+ Hits 13147 13284 +137
- Misses 2936 2950 +14
🚀 New features to boost your workflow:
|
|
Thanks for the PR. Please check the CI logs for failures, and adjust the code accordingly. In the mean time, I will start the code review and provide feedback. Thanks for your contribution. Examples of failures below Include what you use: Build in maintainer mode Clang-tidy Download the clang-tidy report from ci, and inspect failures related to new code. |
|
Hi @marcalff, addressed all the CI failures:
|
Signed-off-by: DCchoudhury15 <divyanshuchoudhury3@gmail.com>
f5be4bf to
659aafe
Compare
marcalff
left a comment
There was a problem hiding this comment.
Thanks for the PR.
Focusing on the yaml part for now: all the yaml nodes and properties should be parsed, and represented in memory in C++ classes.
This includes rules with attribute_values, attribute_patterns and span_kinds.
2e15234 to
758e3a5
Compare
|
I have applied the changes given on the pr review , will resolve all the ci errors and commit again asap . |
Signed-off-by: DCchoudhury15 <divyanshuchoudhury3@gmail.com>
13f24d4 to
1a4617d
Compare
Signed-off-by: DCchoudhury15 <divyanshuchoudhury3@gmail.com>
e207db5 to
e22556d
Compare
7b65db4 to
b96bd0b
Compare
Signed-off-by: DCchoudhury15 <divyanshuchoudhury3@gmail.com>
…sed_sampler_rule_attribute_values_configuration.h Co-authored-by: Marc Alff <marc.alff@free.fr>
…sed_sampler_rule_attribute_patterns_configuration.h Co-authored-by: Marc Alff <marc.alff@free.fr>
…sed_sampler_rule_attribute_patterns_configuration.h Co-authored-by: Marc Alff <marc.alff@free.fr>
…sed_sampler_configuration.h Co-authored-by: Marc Alff <marc.alff@free.fr>
…ion.cc Co-authored-by: Marc Alff <marc.alff@free.fr>
…sed_sampler_configuration.h Co-authored-by: Marc Alff <marc.alff@free.fr>
…lity_sampler_configuration.h Co-authored-by: Marc Alff <marc.alff@free.fr>
…lity_sampler_configuration.h Co-authored-by: Marc Alff <marc.alff@free.fr>
…threshold_sampler_configuration.h Co-authored-by: Marc Alff <marc.alff@free.fr>
…on_sampler_configuration.h Co-authored-by: Marc Alff <marc.alff@free.fr>
…on_sampler_configuration.h Co-authored-by: Marc Alff <marc.alff@free.fr>
…threshold_sampler_configuration.h Co-authored-by: Marc Alff <marc.alff@free.fr>
f4d6dea to
096f4e9
Compare
Co-authored-by: Marc Alff <marc.alff@free.fr>
Co-authored-by: Marc Alff <marc.alff@free.fr>
Co-authored-by: Marc Alff <marc.alff@free.fr>
Fixes #3914
Changes
This PR implements the necessary infrastructure and test coverage to fully support composable samplers. Specifically, the changes include:
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes