[CODE HEALTH] Remove last unused nostd namespace alias in otlp_populate_attribute_utils - #4114
Merged
marcalff merged 1 commit intoJun 3, 2026
Conversation
…te_attribute_utils Removes the file-scope `namespace nostd = opentelemetry::nostd;` declaration that was deliberately left in place by PR open-telemetry#4091 to avoid conflicting with the then in-flight PR open-telemetry#4090 on the same file. Now that both PRs have merged, this completes the misc-unused-alias-decls cleanup: the project drops from 1 to 0 such warnings. The alias was unused. References to `nostd::` inside `OPENTELEMETRY_BEGIN_NAMESPACE` resolve via parent-namespace lookup to `opentelemetry::nostd` without needing the file-scope alias. Ratchet: * abiv1-preview warning_limit lowered from 385 to 384 * abiv2-preview warning_limit lowered from 391 to 390 Part of open-telemetry#2053 Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com>
thc1006
force-pushed
the
codehealth/otlp-populate-alias-decl
branch
from
June 2, 2026 20:06
cae636a to
02bc457
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4114 +/- ##
=======================================
Coverage 82.01% 82.01%
=======================================
Files 385 385
Lines 16031 16031
=======================================
Hits 13146 13146
Misses 2885 2885
🚀 New features to boost your workflow:
|
marcalff
approved these changes
Jun 3, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the single remaining
misc-unused-alias-declswarning in the project: a file-scopenamespace nostd = opentelemetry::nostd;declaration atexporters/otlp/src/otlp_populate_attribute_utils.cc:31.This declaration was deliberately left in place by #4091 to avoid conflicting with the then in-flight #4090 on the same file. Both have now merged (#4091 by marcalff on 2026-05-18, #4090 by lalitb on 2026-06-01), so the conflict surface is gone.
After this PR, the
misc-unused-alias-declswarning count for the project is0under bothall-options-abiv1-previewandall-options-abiv2-preview.Why the alias is unused
References to
nostd::inside theOPENTELEMETRY_BEGIN_NAMESPACEblock resolve via parent-namespace lookup toopentelemetry::nostdwithout needing the file-scope alias. The alias was redundant from day one; clang-tidy'smisc-unused-alias-declscheck correctly flagged it.There are no global-scope references to
nostd::in this file (only the alias declaration itself, which is removed). Removing it does not affect any include or any other code path. Same pattern as the 29 alias removals in #4091.Ratchet
all-options-abiv1-previewwarning_limitlowered from 385 to 384all-options-abiv2-previewwarning_limitlowered from 391 to 390Both presets reported the warning at this site; both ratchets drop by 1.
Verification
Counts measured against artifacts of the most recent successful CI run on
main(workflowclang-tidy.yaml, run26782221265, head83c135d8):Local
clang-format --dry-run --Werroragainst the modified source file: clean.Test plan
clang-tidyjob passes both abiv1-preview and abiv2-preview at the new limitsPart of #2053