Skip to content

[CODE HEALTH] Move trace and baggage propagation test classes into anonymous namespace - #4199

Merged
marcalff merged 3 commits into
open-telemetry:mainfrom
mateenali66:fix/4196-internal-linkage-trace-baggage-propagation
Jul 2, 2026
Merged

[CODE HEALTH] Move trace and baggage propagation test classes into anonymous namespace#4199
marcalff merged 3 commits into
open-telemetry:mainfrom
mateenali66:fix/4196-internal-linkage-trace-baggage-propagation

Conversation

@mateenali66

Copy link
Copy Markdown
Member

Moves the TextMapCarrierTest helper in the b3, http_text_format and jaeger trace propagation tests, and BaggageCarrierTest in the baggage propagation test, into anonymous namespaces, resolving their misc-use-internal-linkage clang-tidy warnings. Test-only, no behavior change.

Lowered the clang-tidy warning_limit by 4 for both ABI presets accordingly.

Part of #4196.

…onymous namespace

Resolves the misc-use-internal-linkage clang-tidy warnings for the
TextMapCarrierTest and BaggageCarrierTest helper classes in the b3,
http_text_format, jaeger and baggage propagation tests by giving them
internal linkage.

Part of open-telemetry#4196.

Signed-off-by: Mateen Anjum <mateenali66@gmail.com>
@mateenali66
mateenali66 requested a review from a team as a code owner June 30, 2026 19:18
Signed-off-by: Mateen Anjum <mateenali66@gmail.com>
@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.90%. Comparing base (a56f0e2) to head (cd33fb0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4199      +/-   ##
==========================================
+ Coverage   82.89%   82.90%   +0.01%     
==========================================
  Files         405      405              
  Lines       17292    17289       -3     
==========================================
- Hits        14332    14331       -1     
+ Misses       2960     2958       -2     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thc1006

thc1006 commented Jun 30, 2026

Copy link
Copy Markdown
Member

These look clean. One cross-PR heads-up since #4199 and #4200 overlap on the ratchet file: both lower warning_limit in clang-tidy.yaml from the same base (328 abiv1, 338 abiv2) while touching disjoint test files (#4199 removes 4 warnings, #4200 removes 3). So whichever merges first, the other will hit a merge conflict on those two lines and need a quick rebase. After both land the combined value should be 321 and 331 (328 and 338, each minus 7). Flagging it so the second one is not accidentally left at its single-PR number (324/334 or 325/335), which would leave the ceiling looser than the actual count.

@dbarker dbarker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marcalff marcalff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcalff
marcalff merged commit 14e0ec8 into open-telemetry:main Jul 2, 2026
71 checks passed
proost added a commit to proost/opentelemetry-cpp that referenced this pull request Jul 18, 2026
ayush-that pushed a commit to ayush-that/opentelemetry-cpp that referenced this pull request Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants