Skip to content

Partly fix #424, compile error with custom prebuilt protobuf - #428

Closed
owent wants to merge 1 commit into
open-telemetry:masterfrom
owent:master
Closed

owent wants to merge 1 commit into
open-telemetry:masterfrom
owent:master

Conversation

@owent

@owent owent commented Dec 8, 2020

Copy link
Copy Markdown
Member

More details, see #424

@owent
owent requested a review from a team December 8, 2020 02:20
@linux-foundation-easycla

linux-foundation-easycla Bot commented Dec 8, 2020

Copy link
Copy Markdown

CLA Signed

The committers are authorized under a signed CLA.

  • ✅ OWenT (64bdbd84e04a4de44729cea9aa21cb724598febe)

@codecov

codecov Bot commented Dec 8, 2020

Copy link
Copy Markdown

Codecov Report

Merging #428 (65da5fd) into master (7e06316) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #428      +/-   ##
==========================================
+ Coverage   94.37%   94.39%   +0.02%     
==========================================
  Files         189      189              
  Lines        8410     8410              
==========================================
+ Hits         7937     7939       +2     
+ Misses        473      471       -2     
Impacted Files Coverage Δ
sdk/test/common/circular_buffer_test.cc 100.00% <0.00%> (+1.02%) ⬆️
sdk/src/logs/batch_log_processor.cc 95.06% <0.00%> (+1.23%) ⬆️

…_ROOT_PATH=<PROTOBUF INSTALL PREFIX DIR>``` with custom prebuilt protobuf. open-telemetry#424
@owent

owent commented Dec 30, 2020

Copy link
Copy Markdown
Member Author

Duplicated with #432

@owent owent closed this Dec 30, 2020
GerHobbelt pushed a commit to GerHobbelt/opentelemetry-cpp that referenced this pull request Aug 31, 2025
…and-patch-dependencies

Update github/codeql-action action to v3.29.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant