Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4430 +/- ##
=======================================
Coverage 82.58% 82.58%
=======================================
Files 511 511
Lines 20039 20039
=======================================
Hits 16548 16548
Misses 3491 3491 🚀 New features to boost your workflow:
|
…atform support by attribute
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to: #3548
Follow up to #4417 (comment)
The spec defines
built-inresource detectors ashost,service,process, andcontaineralong with an experimental EnvEntity detector.The detectors should follow the Entity semantic conventions for attributes:
The implemented resource detectors support a small subset of these attributes and are currently built into a single target (and single test executable).
This PR sets up the documentation and creates individual targets for each detector that will make it easier for contributors to add support for attributes. Individual detector targets will allow users to link only what they use.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes