[SDK] Enforce Span Status transition rules - #4547
Merged
Merged
Conversation
denizariyan
force-pushed
the
fix/status-transition
branch
from
September 9, 2026 16:01
5b480bb to
4c630e7
Compare
denizariyan
commented
Sep 9, 2026
Comment on lines
+651
to
+653
| // The description is not null terminated at its end, so a copy through data() alone overruns it. | ||
| std::string description = "boomX"; | ||
| span->SetStatus(opentelemetry::trace::StatusCode::kError, |
Contributor
Author
There was a problem hiding this comment.
I added this because the prev impl actually had this issue with nullptr or non-null terminated strs, not exactly related to this PR but fixed along the way since it's a single line I am changing around anyways
denizariyan
marked this pull request as ready for review
September 9, 2026 16:06
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4547 +/- ##
==========================================
+ Coverage 86.41% 86.45% +0.05%
==========================================
Files 524 525 +1
Lines 20435 20450 +15
==========================================
+ Hits 17657 17679 +22
+ Misses 2778 2771 -7
🚀 New features to boost your workflow:
|
denizariyan
force-pushed
the
fix/status-transition
branch
from
September 9, 2026 18:21
4c630e7 to
ae40757
Compare
lalitb
reviewed
Sep 12, 2026
lalitb
reviewed
Sep 12, 2026
lalitb
approved these changes
Sep 12, 2026
lalitb
left a comment
Member
There was a problem hiding this comment.
LGTM. With nit comment for header reorg, and changelog. thanks.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4546
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes