Add #include <cctype> to baggage.h - #822
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #822 +/- ##
=======================================
Coverage 96.19% 96.19%
=======================================
Files 153 153
Lines 6444 6444
=======================================
Hits 6198 6198
Misses 246 246
|
maxgolov
approved these changes
Jun 3, 2021
Contributor
|
Thank you for the fix. We'd consider adding some tests / samples. Perhaps it's one of these extended features that we are not compiling in any of the examples. I'll set up the build loop for vs2015 once the Abseil branch changes get merged this week, to continuously validate everything with vs2015. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #808
Changes
Add
#include <cctype>to makeisdigit,isalnum, etc. available inbaggage.h.I also tested against the Abseil-variant branch and confirmed that 1) without this, we still get errors under MSVC2015 and 2) with this, there are no errors.
CHANGELOG.mdupdated for non-trivial changes