Skip to content

Fix issue #834 - #835

Merged
lalitb merged 3 commits into
open-telemetry:mainfrom
owent:fix_issue_834
Jun 9, 2021
Merged

Fix issue #834#835
lalitb merged 3 commits into
open-telemetry:mainfrom
owent:fix_issue_834

Conversation

@owent

@owent owent commented Jun 8, 2021

Copy link
Copy Markdown
Member

Signed-off-by: owent admin@owent.net

Fixes #834

Changes

  • Pass WITH_ABSEIL by cmake config
  • Replace ThrowBadVariantAccess by linking absl::bad_variant_access.
  • Add TSAN_OPTIONS=report_atomic_races=0, which is just the same as grpc.

Shall we add a CI job to build and install opentelemetry-cpp, and then try to import components from cmake config?

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Signed-off-by: owent <admin@owent.net>
@owent
owent requested a review from a team June 8, 2021 14:29
@codecov

codecov Bot commented Jun 8, 2021

Copy link
Copy Markdown

Codecov Report

Merging #835 (1dc0d10) into main (12946c8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #835   +/-   ##
=======================================
  Coverage   95.50%   95.50%           
=======================================
  Files         156      156           
  Lines        6619     6619           
=======================================
  Hits         6321     6321           
  Misses        298      298           
Impacted Files Coverage Δ
api/include/opentelemetry/nostd/variant.h 66.67% <ø> (ø)
...ude/opentelemetry/sdk/trace/multi_span_processor.h 93.34% <100.00%> (ø)

@maxgolov maxgolov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you! Maybe we'd need to add some CI for that (in a separate PR).

@lalitb
lalitb merged commit 1060f88 into open-telemetry:main Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linking error with prebuilt opentelemetry-cpp and gcc 4.8

3 participants