Skip to content

Allow to use local GSL - #915

Merged
lalitb merged 1 commit into
open-telemetry:mainfrom
owent:use_local_gsl
Jul 22, 2021
Merged

Allow to use local GSL#915
lalitb merged 1 commit into
open-telemetry:mainfrom
owent:use_local_gsl

Conversation

@owent

@owent owent commented Jul 21, 2021

Copy link
Copy Markdown
Member

Signed-off-by: owent admin@owent.net

Fixes # 914

Changes

Allow to us elocal GSL.

Maybe need more discussion about using gsl-lite for old compilers?

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent
owent requested a review from a team July 21, 2021 07:24
@codecov

codecov Bot commented Jul 21, 2021

Copy link
Copy Markdown

Codecov Report

Merging #915 (37e5692) into main (950f940) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #915   +/-   ##
=======================================
  Coverage   95.44%   95.44%           
=======================================
  Files         158      158           
  Lines        6749     6749           
=======================================
  Hits         6441     6441           
  Misses        308      308           

@lalitb

lalitb commented Jul 22, 2021

Copy link
Copy Markdown
Member

@owent - will merge it once it's rebased to main.

Signed-off-by: owent <admin@owent.net>
@owent

owent commented Jul 22, 2021

Copy link
Copy Markdown
Member Author

@owent - will merge it once it's rebased to main.

Done.

@lalitb
lalitb merged commit 1f31341 into open-telemetry:main Jul 22, 2021
@lalitb lalitb mentioned this pull request Aug 4, 2021
@owent
owent deleted the use_local_gsl branch September 20, 2021 08:39
@lalitb lalitb mentioned this pull request Mar 22, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants