Remove enum_keys helper in favour of the new enum tools. - #35
Merged
Merged
Conversation
Also eliminated all the redundant length fields, and just store a single length.
samsinsane
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enum_keyswas emitting an array of enum key strings to the binary (in declaration order).The new enum tools emits a SORTED list of enum strings (so it can be binary-searched).
2 lists of strings is redundant; so I kept the sorted list which is more useful, and added another small table of bytes which map from the declaration index into the sorted list of strings so that you can lookup by declaration index.
I also eliminated all the redundant length fields, and just stored a single length.