Skip to content

Remove obsolete error message at p1CalculateUtilization (Fixes #230) - #231

Merged
openBackhaul merged 2 commits into
developfrom
openBackhaul/issue230
Aug 5, 2026
Merged

Remove obsolete error message at p1CalculateUtilization (Fixes #230)#231
openBackhaul merged 2 commits into
developfrom
openBackhaul/issue230

Conversation

@openBackhaul

Copy link
Copy Markdown
Owner

Please, implement accordingly, merge the pull request and delete the openBackhaul/issue230 branch.
Many thanks in advance.

@openBackhaulopenBackhaul added this to the DPMDP v1.0.1_spec milestone Jun 26, 2026
@openBackhaulopenBackhaul added the bug Something isn't working label Jun 26, 2026
@openBackhaulopenBackhaul linked an issue Jun 29, 2026 that may be closed by this pull request
@latta-siae

latta-siae commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Hi @openBackhaul ,

i think you must decouple the PR about files

  • p1IterateAiPmSlices
  • p1CalculateUtilization

Why?
Because p1CalculateUtilization has been change many things:

  • Business logic
  • aggregation-group now is not mandatory
  • uuidOfEthernetContainer new parameter to handle

So then this must be renamed as p2CalculateUtilization related of DPMDP 1.1.0
p2IterateEcPmSlices. If that is stick with p1CalculateUtilization the workflow will not work properly.

See the workflow v1.0.0 and v.1.1.0
image

image

@kmohr-soprasteria

kmohr-soprasteria commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Hi Lorenzo,

to me it looks reasonable to have an own PR for the removal of the unneeded error message in p1IterateAiPmSlices (#228).

As for p2IterateEcPmSlices and p1CalculateUtilization - you correctly pointed out that the required inputs to calculateUtilization have changed.
We could now either have a p1CalculateUtilization 1.1.0 or a p2CalculateUtilization 1.0.0.
The logic inside the function is now a bit different, but not that much. So possibly Thorsten had in mind to implement a 1.1.0 version of it in addition to the 1.0.0 implementation.

I would suggest, you start with implementing the changes and we wait for Thorstens confirmation on what approach he would like to take.

Br
Katharina

@openBackhaul

Copy link
Copy Markdown
OwnerAuthor
image

Changes in p1IterateAiPmSlices occured in this PR, because issue branch 230 has not been properly updated from develop.
After updating issue branch 230, p1IterateAiPmSlices is no longer listed as changed file.

Error message shall be removed as a part of the bug fix in DPMDP v1.0 (milestone v1.0.1).
The correction will be represented in a file that will be created as a part of the rectification of p1CalculateUtilization releases in newly created issue #309.

This pull-request will be merged for avoiding to lose the made changes in a function that will be named p2CalculateUtilization in future.

@openBackhaul
openBackhaul merged commit deae72c into developAug 5, 2026
1 check passed
@openBackhaul
openBackhaul deleted the openBackhaul/issue230 branch August 5, 2026 14:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Obsolete error messages at p1CalculateUtilization

3 participants

@openBackhaul@latta-siae@kmohr-soprasteria