PR for function p1ReadDataStoreDeviceData into siae integration branch - #317
Open
latta-siae wants to merge 2 commits into
Open
PR for function p1ReadDataStoreDeviceData into siae integration branch#317latta-siae wants to merge 2 commits into
latta-siae wants to merge 2 commits into
Conversation
latta-siae
commented
Aug 26, 2026
Collaborator
- To Be implement function p1ReadDataStoreDeviceData #247
latta-siae
requested review from
agamennone-siae, giuliani-siae and spinelli-siaeAugust 26, 2026 22:03
latta-siae
marked this pull request as ready for review
August 26, 2026 22:03
| async function retrieveDevicePmDataFromDs(dataStoreConfig, mountName) { | ||
| const elasticsearchClient = dataStoreConfig.client; | ||
| const index = dataStoreConfig['index-alias'] ? dataStoreConfig['index-alias'] : dataStoreConfig.index || DEFAULT_DATA_STORE_INDEX; | ||
| const documentId = `device=${encodeURIComponent(mountName)}/result-data`; |
Collaborator
There was a problem hiding this comment.
result-data or processing-data ?
agamennone-siae
marked this pull request as draft
August 27, 2026 12:58
agamennone-siae
marked this pull request as ready for review
August 27, 2026 12:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.