Skip to content

feat(php-tests)!: emit text + Clover XML coverage, per-format booleans, drop coverage-command - #18

Open
kojiromike wants to merge 4 commits into
mainfrom
feat/coverage-text-and-clover
Open

feat(php-tests)!: emit text + Clover XML coverage, per-format booleans, drop coverage-command#18
kojiromike wants to merge 4 commits into
mainfrom
feat/coverage-text-and-clover

Conversation

@kojiromike

@kojiromikekojiromike commented May 20, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Default coverage run produces three artifacts under coverage-report/: HTML report, coverage.txt (PHPUnit text report), clover.xml (machine-readable line coverage) for cheap agent / CI consumption.
  • Three new boolean inputs — coverage-html, coverage-text, coverage-clover (all default true) — let callers opt out of any format. At least one must be true.
  • Breaking:coverage-command is removed. The booleans are now the entire API for choosing outputs. Callers who need to customize PHPUnit (config path, suites, listeners, bootstrap, coverage filters, etc.) configure those in phpunit.xml, which PHPUnit auto-discovers.

Pairs with openCoreEMR/github-workflows-internal#33 (surfaces the text Summary in the PR comment and links the artifact).

Why drop coverage-command

The previous design eval'd an arbitrary string input. Even though the input is caller-trusted in GHA's model, the escape hatch invites future foot-shooting (e.g., a caller accidentally interpolating untrusted context). The booleans cover the common cases; phpunit.xml covers the rest.

Test plan

  • Pin this branch via uses: on a real caller; confirm coverage-report/{coverage.txt,clover.xml,index.html} all appear in the uploaded artifact.
  • Set coverage-clover: false and confirm clover.xml is absent.
  • Set all three booleans to false and confirm the step fails fast with a clear error.
  • Confirm a caller with a custom phpunit.xml (suites, exclusions) still picks it up via auto-discovery.

@kojiromike
feat(php-tests): emit text summary and Clover XML coverage outputs
cc9c22c
Default coverage-command now writes coverage.txt and clover.xml into
coverage-report/ alongside the HTML report, so consumers (PR comments,
agents, CI tools) can read coverage without scraping HTML.
Assisted-by: Claude Code
@kojiromike
feat(php-tests): gate coverage outputs behind per-format boolean flags
b6eb90e
Add coverage-html, coverage-text, coverage-clover (all default true) so
callers can opt out of any format. The default coverage-command becomes
empty and is composed from the booleans; setting coverage-command still
overrides everything as an escape hatch.
Assisted-by: Claude Code
@kojiromikekojiromike added the github-actions GitHub Actions ecosystem label May 20, 2026
@kojiromike
feat(php-tests)!: drop coverage-command escape hatch
219b1e9
The booleans (coverage-html, coverage-text, coverage-clover) are now the
entire API for choosing which coverage outputs to emit. Removing the
arbitrary-shell-eval escape hatch eliminates a foot-gun: callers can no
longer accidentally interpolate untrusted GitHub context into a shell
string, and the workflow no longer eval's a free-form input.
Callers that need to customize PHPUnit (config path, suites, listeners,
bootstrap, coverage exclusions, etc.) configure those in phpunit.xml,
which PHPUnit auto-discovers.
BREAKING CHANGE: The coverage-command input has been removed. Callers
that set it must remove the input and move any custom PHPUnit
configuration into phpunit.xml.
Assisted-by: Claude Code
@kojiromike
style(php-tests): use = for bash string comparison
e4d9a5b
POSIX-canonical form in [[ ]] tests; reserve == for arithmetic inside
(( )).
Assisted-by: Claude Code
@kojiromikekojiromike changed the title feat(php-tests): emit text + Clover XML coverage, gated by booleansfeat(php-tests)!: emit text + Clover XML coverage, per-format booleans, drop coverage-commandMay 20, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

github-actionsGitHub Actions ecosystem

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kojiromike
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat(php-tests)!: emit text + Clover XML coverage, per-format booleans, drop coverage-command by kojiromike · Pull Request #18 · openCoreEMR/github-workflows-public · GitHub
Skip to content
feat(php-tests)!: emit text + Clover XML coverage, per-format booleans, drop coverage-command - #18
Open
kojiromike wants to merge 4 commits into
mainfrom 
feat/coverage-text-and-clover
Open
feat(php-tests)!: emit text + Clover XML coverage, per-format booleans, drop coverage-command#18
kojiromike wants to merge 4 commits into
mainfrom 
feat/coverage-text-and-clover
Conversation
@kojiromike
@kojiromikekojiromike
commented
May 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Default coverage run produces three artifacts under coverage-report/: HTML report, coverage.txt (PHPUnit text report), clover.xml (machine-readable line coverage) for cheap agent / CI consumption.
  • Three new boolean inputs — coverage-html, coverage-text, coverage-clover (all default true) — let callers opt out of any format. At least one must be true.
  • Breaking:coverage-command is removed. The booleans are now the entire API for choosing outputs. Callers who need to customize PHPUnit (config path, suites, listeners, bootstrap, coverage filters, etc.) configure those in phpunit.xml, which PHPUnit auto-discovers.
Pairs with openCoreEMR/github-workflows-internal#33 (surfaces the text Summary in the PR comment and links the artifact).
Why drop coverage-command
The previous design eval'd an arbitrary string input. Even though the input is caller-trusted in GHA's model, the escape hatch invites future foot-shooting (e.g., a caller accidentally interpolating untrusted context). The booleans cover the common cases; phpunit.xml covers the rest.
Test plan
  •  Pin this branch via uses: on a real caller; confirm coverage-report/{coverage.txt,clover.xml,index.html} all appear in the uploaded artifact.
  •  Set coverage-clover: false and confirm clover.xml is absent.
  •  Set all three booleans to false and confirm the step fails fast with a clear error.
  •  Confirm a caller with a custom phpunit.xml (suites, exclusions) still picks it up via auto-discovery.
@kojiromike
feat(php-tests): emit text summary and Clover XML coverage outputs
cc9c22c
Default coverage-command now writes coverage.txt and clover.xml into
coverage-report/ alongside the HTML report, so consumers (PR comments,
agents, CI tools) can read coverage without scraping HTML.
Assisted-by: Claude Code
@kojiromike
feat(php-tests): gate coverage outputs behind per-format boolean flags
b6eb90e
Add coverage-html, coverage-text, coverage-clover (all default true) so
callers can opt out of any format. The default coverage-command becomes
empty and is composed from the booleans; setting coverage-command still
overrides everything as an escape hatch.
Assisted-by: Claude Code
@kojiromikekojiromike
added
the 
github-actions
GitHub Actions ecosystem
label
May 20, 2026
@kojiromike
feat(php-tests)!: drop coverage-command escape hatch
219b1e9
The booleans (coverage-html, coverage-text, coverage-clover) are now the
entire API for choosing which coverage outputs to emit. Removing the
arbitrary-shell-eval escape hatch eliminates a foot-gun: callers can no
longer accidentally interpolate untrusted GitHub context into a shell
string, and the workflow no longer eval's a free-form input.
Callers that need to customize PHPUnit (config path, suites, listeners,
bootstrap, coverage exclusions, etc.) configure those in phpunit.xml,
which PHPUnit auto-discovers.
BREAKING CHANGE: The coverage-command input has been removed. Callers
that set it must remove the input and move any custom PHPUnit
configuration into phpunit.xml.
Assisted-by: Claude Code
@kojiromike
style(php-tests): use = for bash string comparison
e4d9a5b
POSIX-canonical form in [[ ]] tests; reserve == for arithmetic inside
(( )).
Assisted-by: Claude Code
@kojiromikekojiromike
changed the title
feat(php-tests): emit text + Clover XML coverage, gated by booleansfeat(php-tests)!: emit text + Clover XML coverage, per-format booleans, drop coverage-commandMay 20, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

github-actionsGitHub Actions ecosystem

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@kojiromike

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(php-tests)!: emit text + Clover XML coverage, per-format booleans, drop coverage-command by kojiromike · Pull Request #18 · openCoreEMR/github-workflows-public · GitHub
Skip to content
feat(php-tests)!: emit text + Clover XML coverage, per-format booleans, drop coverage-command - #18
Open
kojiromike wants to merge 4 commits into
mainfrom 
feat/coverage-text-and-clover
Open
feat(php-tests)!: emit text + Clover XML coverage, per-format booleans, drop coverage-command#18
kojiromike wants to merge 4 commits into
mainfrom 
feat/coverage-text-and-clover
Conversation
@kojiromike
@kojiromikekojiromike
commented
May 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Default coverage run produces three artifacts under coverage-report/: HTML report, coverage.txt (PHPUnit text report), clover.xml (machine-readable line coverage) for cheap agent / CI consumption.
  • Three new boolean inputs — coverage-html, coverage-text, coverage-clover (all default true) — let callers opt out of any format. At least one must be true.
  • Breaking:coverage-command is removed. The booleans are now the entire API for choosing outputs. Callers who need to customize PHPUnit (config path, suites, listeners, bootstrap, coverage filters, etc.) configure those in phpunit.xml, which PHPUnit auto-discovers.
Pairs with openCoreEMR/github-workflows-internal#33 (surfaces the text Summary in the PR comment and links the artifact).
Why drop coverage-command
The previous design eval'd an arbitrary string input. Even though the input is caller-trusted in GHA's model, the escape hatch invites future foot-shooting (e.g., a caller accidentally interpolating untrusted context). The booleans cover the common cases; phpunit.xml covers the rest.
Test plan
  •  Pin this branch via uses: on a real caller; confirm coverage-report/{coverage.txt,clover.xml,index.html} all appear in the uploaded artifact.
  •  Set coverage-clover: false and confirm clover.xml is absent.
  •  Set all three booleans to false and confirm the step fails fast with a clear error.
  •  Confirm a caller with a custom phpunit.xml (suites, exclusions) still picks it up via auto-discovery.
@kojiromike
feat(php-tests): emit text summary and Clover XML coverage outputs
cc9c22c
Default coverage-command now writes coverage.txt and clover.xml into
coverage-report/ alongside the HTML report, so consumers (PR comments,
agents, CI tools) can read coverage without scraping HTML.
Assisted-by: Claude Code
@kojiromike
feat(php-tests): gate coverage outputs behind per-format boolean flags
b6eb90e
Add coverage-html, coverage-text, coverage-clover (all default true) so
callers can opt out of any format. The default coverage-command becomes
empty and is composed from the booleans; setting coverage-command still
overrides everything as an escape hatch.
Assisted-by: Claude Code
@kojiromikekojiromike
added
the 
github-actions
GitHub Actions ecosystem
label
May 20, 2026
@kojiromike
feat(php-tests)!: drop coverage-command escape hatch
219b1e9
The booleans (coverage-html, coverage-text, coverage-clover) are now the
entire API for choosing which coverage outputs to emit. Removing the
arbitrary-shell-eval escape hatch eliminates a foot-gun: callers can no
longer accidentally interpolate untrusted GitHub context into a shell
string, and the workflow no longer eval's a free-form input.
Callers that need to customize PHPUnit (config path, suites, listeners,
bootstrap, coverage exclusions, etc.) configure those in phpunit.xml,
which PHPUnit auto-discovers.
BREAKING CHANGE: The coverage-command input has been removed. Callers
that set it must remove the input and move any custom PHPUnit
configuration into phpunit.xml.
Assisted-by: Claude Code
@kojiromike
style(php-tests): use = for bash string comparison
e4d9a5b
POSIX-canonical form in [[ ]] tests; reserve == for arithmetic inside
(( )).
Assisted-by: Claude Code
@kojiromikekojiromike
changed the title
feat(php-tests): emit text + Clover XML coverage, gated by booleansfeat(php-tests)!: emit text + Clover XML coverage, per-format booleans, drop coverage-commandMay 20, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

github-actionsGitHub Actions ecosystem

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@kojiromike

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(php-tests)!: emit text + Clover XML coverage, per-format booleans, drop coverage-command by kojiromike · Pull Request #18 · openCoreEMR/github-workflows-public · GitHub
Skip to content
feat(php-tests)!: emit text + Clover XML coverage, per-format booleans, drop coverage-command - #18
Open
kojiromike wants to merge 4 commits into
mainfrom 
feat/coverage-text-and-clover
Open
feat(php-tests)!: emit text + Clover XML coverage, per-format booleans, drop coverage-command#18
kojiromike wants to merge 4 commits into
mainfrom 
feat/coverage-text-and-clover
Conversation
@kojiromike
@kojiromikekojiromike
commented
May 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Default coverage run produces three artifacts under coverage-report/: HTML report, coverage.txt (PHPUnit text report), clover.xml (machine-readable line coverage) for cheap agent / CI consumption.
  • Three new boolean inputs — coverage-html, coverage-text, coverage-clover (all default true) — let callers opt out of any format. At least one must be true.
  • Breaking:coverage-command is removed. The booleans are now the entire API for choosing outputs. Callers who need to customize PHPUnit (config path, suites, listeners, bootstrap, coverage filters, etc.) configure those in phpunit.xml, which PHPUnit auto-discovers.
Pairs with openCoreEMR/github-workflows-internal#33 (surfaces the text Summary in the PR comment and links the artifact).
Why drop coverage-command
The previous design eval'd an arbitrary string input. Even though the input is caller-trusted in GHA's model, the escape hatch invites future foot-shooting (e.g., a caller accidentally interpolating untrusted context). The booleans cover the common cases; phpunit.xml covers the rest.
Test plan
  •  Pin this branch via uses: on a real caller; confirm coverage-report/{coverage.txt,clover.xml,index.html} all appear in the uploaded artifact.
  •  Set coverage-clover: false and confirm clover.xml is absent.
  •  Set all three booleans to false and confirm the step fails fast with a clear error.
  •  Confirm a caller with a custom phpunit.xml (suites, exclusions) still picks it up via auto-discovery.
@kojiromike
feat(php-tests): emit text summary and Clover XML coverage outputs
cc9c22c
Default coverage-command now writes coverage.txt and clover.xml into
coverage-report/ alongside the HTML report, so consumers (PR comments,
agents, CI tools) can read coverage without scraping HTML.
Assisted-by: Claude Code
@kojiromike
feat(php-tests): gate coverage outputs behind per-format boolean flags
b6eb90e
Add coverage-html, coverage-text, coverage-clover (all default true) so
callers can opt out of any format. The default coverage-command becomes
empty and is composed from the booleans; setting coverage-command still
overrides everything as an escape hatch.
Assisted-by: Claude Code
@kojiromikekojiromike
added
the 
github-actions
GitHub Actions ecosystem
label
May 20, 2026
@kojiromike
feat(php-tests)!: drop coverage-command escape hatch
219b1e9
The booleans (coverage-html, coverage-text, coverage-clover) are now the
entire API for choosing which coverage outputs to emit. Removing the
arbitrary-shell-eval escape hatch eliminates a foot-gun: callers can no
longer accidentally interpolate untrusted GitHub context into a shell
string, and the workflow no longer eval's a free-form input.
Callers that need to customize PHPUnit (config path, suites, listeners,
bootstrap, coverage exclusions, etc.) configure those in phpunit.xml,
which PHPUnit auto-discovers.
BREAKING CHANGE: The coverage-command input has been removed. Callers
that set it must remove the input and move any custom PHPUnit
configuration into phpunit.xml.
Assisted-by: Claude Code
@kojiromike
style(php-tests): use = for bash string comparison
e4d9a5b
POSIX-canonical form in [[ ]] tests; reserve == for arithmetic inside
(( )).
Assisted-by: Claude Code
@kojiromikekojiromike
changed the title
feat(php-tests): emit text + Clover XML coverage, gated by booleansfeat(php-tests)!: emit text + Clover XML coverage, per-format booleans, drop coverage-commandMay 20, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

github-actionsGitHub Actions ecosystem

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@kojiromike

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
feat(php-tests)!: emit text + Clover XML coverage, per-format booleans, drop coverage-command by kojiromike · Pull Request #18 · openCoreEMR/github-workflows-public · GitHub
Skip to content
feat(php-tests)!: emit text + Clover XML coverage, per-format booleans, drop coverage-command - #18
Open
kojiromike wants to merge 4 commits into
mainfrom 
feat/coverage-text-and-clover
Open
feat(php-tests)!: emit text + Clover XML coverage, per-format booleans, drop coverage-command#18
kojiromike wants to merge 4 commits into
mainfrom 
feat/coverage-text-and-clover
Conversation
@kojiromike
@kojiromikekojiromike
commented
May 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Default coverage run produces three artifacts under coverage-report/: HTML report, coverage.txt (PHPUnit text report), clover.xml (machine-readable line coverage) for cheap agent / CI consumption.
  • Three new boolean inputs — coverage-html, coverage-text, coverage-clover (all default true) — let callers opt out of any format. At least one must be true.
  • Breaking:coverage-command is removed. The booleans are now the entire API for choosing outputs. Callers who need to customize PHPUnit (config path, suites, listeners, bootstrap, coverage filters, etc.) configure those in phpunit.xml, which PHPUnit auto-discovers.
Pairs with openCoreEMR/github-workflows-internal#33 (surfaces the text Summary in the PR comment and links the artifact).
Why drop coverage-command
The previous design eval'd an arbitrary string input. Even though the input is caller-trusted in GHA's model, the escape hatch invites future foot-shooting (e.g., a caller accidentally interpolating untrusted context). The booleans cover the common cases; phpunit.xml covers the rest.
Test plan
  •  Pin this branch via uses: on a real caller; confirm coverage-report/{coverage.txt,clover.xml,index.html} all appear in the uploaded artifact.
  •  Set coverage-clover: false and confirm clover.xml is absent.
  •  Set all three booleans to false and confirm the step fails fast with a clear error.
  •  Confirm a caller with a custom phpunit.xml (suites, exclusions) still picks it up via auto-discovery.
@kojiromike
feat(php-tests): emit text summary and Clover XML coverage outputs
cc9c22c
Default coverage-command now writes coverage.txt and clover.xml into
coverage-report/ alongside the HTML report, so consumers (PR comments,
agents, CI tools) can read coverage without scraping HTML.
Assisted-by: Claude Code
@kojiromike
feat(php-tests): gate coverage outputs behind per-format boolean flags
b6eb90e
Add coverage-html, coverage-text, coverage-clover (all default true) so
callers can opt out of any format. The default coverage-command becomes
empty and is composed from the booleans; setting coverage-command still
overrides everything as an escape hatch.
Assisted-by: Claude Code
@kojiromikekojiromike
added
the 
github-actions
GitHub Actions ecosystem
label
May 20, 2026
@kojiromike
feat(php-tests)!: drop coverage-command escape hatch
219b1e9
The booleans (coverage-html, coverage-text, coverage-clover) are now the
entire API for choosing which coverage outputs to emit. Removing the
arbitrary-shell-eval escape hatch eliminates a foot-gun: callers can no
longer accidentally interpolate untrusted GitHub context into a shell
string, and the workflow no longer eval's a free-form input.
Callers that need to customize PHPUnit (config path, suites, listeners,
bootstrap, coverage exclusions, etc.) configure those in phpunit.xml,
which PHPUnit auto-discovers.
BREAKING CHANGE: The coverage-command input has been removed. Callers
that set it must remove the input and move any custom PHPUnit
configuration into phpunit.xml.
Assisted-by: Claude Code
@kojiromike
style(php-tests): use = for bash string comparison
e4d9a5b
POSIX-canonical form in [[ ]] tests; reserve == for arithmetic inside
(( )).
Assisted-by: Claude Code
@kojiromikekojiromike
changed the title
feat(php-tests): emit text + Clover XML coverage, gated by booleansfeat(php-tests)!: emit text + Clover XML coverage, per-format booleans, drop coverage-commandMay 20, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

github-actionsGitHub Actions ecosystem

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@kojiromike

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(php-tests)!: emit text + Clover XML coverage, per-format booleans, drop coverage-command by kojiromike · Pull Request #18 · openCoreEMR/github-workflows-public · GitHub
Skip to content
feat(php-tests)!: emit text + Clover XML coverage, per-format booleans, drop coverage-command - #18
Open
kojiromike wants to merge 4 commits into
mainfrom 
feat/coverage-text-and-clover
Open
feat(php-tests)!: emit text + Clover XML coverage, per-format booleans, drop coverage-command#18
kojiromike wants to merge 4 commits into
mainfrom 
feat/coverage-text-and-clover
Conversation
@kojiromike
@kojiromikekojiromike
commented
May 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Default coverage run produces three artifacts under coverage-report/: HTML report, coverage.txt (PHPUnit text report), clover.xml (machine-readable line coverage) for cheap agent / CI consumption.
  • Three new boolean inputs — coverage-html, coverage-text, coverage-clover (all default true) — let callers opt out of any format. At least one must be true.
  • Breaking:coverage-command is removed. The booleans are now the entire API for choosing outputs. Callers who need to customize PHPUnit (config path, suites, listeners, bootstrap, coverage filters, etc.) configure those in phpunit.xml, which PHPUnit auto-discovers.
Pairs with openCoreEMR/github-workflows-internal#33 (surfaces the text Summary in the PR comment and links the artifact).
Why drop coverage-command
The previous design eval'd an arbitrary string input. Even though the input is caller-trusted in GHA's model, the escape hatch invites future foot-shooting (e.g., a caller accidentally interpolating untrusted context). The booleans cover the common cases; phpunit.xml covers the rest.
Test plan
  •  Pin this branch via uses: on a real caller; confirm coverage-report/{coverage.txt,clover.xml,index.html} all appear in the uploaded artifact.
  •  Set coverage-clover: false and confirm clover.xml is absent.
  •  Set all three booleans to false and confirm the step fails fast with a clear error.
  •  Confirm a caller with a custom phpunit.xml (suites, exclusions) still picks it up via auto-discovery.
@kojiromike
feat(php-tests): emit text summary and Clover XML coverage outputs
cc9c22c
Default coverage-command now writes coverage.txt and clover.xml into
coverage-report/ alongside the HTML report, so consumers (PR comments,
agents, CI tools) can read coverage without scraping HTML.
Assisted-by: Claude Code
@kojiromike
feat(php-tests): gate coverage outputs behind per-format boolean flags
b6eb90e
Add coverage-html, coverage-text, coverage-clover (all default true) so
callers can opt out of any format. The default coverage-command becomes
empty and is composed from the booleans; setting coverage-command still
overrides everything as an escape hatch.
Assisted-by: Claude Code
@kojiromikekojiromike
added
the 
github-actions
GitHub Actions ecosystem
label
May 20, 2026
@kojiromike
feat(php-tests)!: drop coverage-command escape hatch
219b1e9
The booleans (coverage-html, coverage-text, coverage-clover) are now the
entire API for choosing which coverage outputs to emit. Removing the
arbitrary-shell-eval escape hatch eliminates a foot-gun: callers can no
longer accidentally interpolate untrusted GitHub context into a shell
string, and the workflow no longer eval's a free-form input.
Callers that need to customize PHPUnit (config path, suites, listeners,
bootstrap, coverage exclusions, etc.) configure those in phpunit.xml,
which PHPUnit auto-discovers.
BREAKING CHANGE: The coverage-command input has been removed. Callers
that set it must remove the input and move any custom PHPUnit
configuration into phpunit.xml.
Assisted-by: Claude Code
@kojiromike
style(php-tests): use = for bash string comparison
e4d9a5b
POSIX-canonical form in [[ ]] tests; reserve == for arithmetic inside
(( )).
Assisted-by: Claude Code
@kojiromikekojiromike
changed the title
feat(php-tests): emit text + Clover XML coverage, gated by booleansfeat(php-tests)!: emit text + Clover XML coverage, per-format booleans, drop coverage-commandMay 20, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

github-actionsGitHub Actions ecosystem

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@kojiromike

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(php-tests)!: emit text + Clover XML coverage, per-format booleans, drop coverage-command by kojiromike · Pull Request #18 · openCoreEMR/github-workflows-public · GitHub
Skip to content
feat(php-tests)!: emit text + Clover XML coverage, per-format booleans, drop coverage-command - #18
Open
kojiromike wants to merge 4 commits into
mainfrom 
feat/coverage-text-and-clover
Open
feat(php-tests)!: emit text + Clover XML coverage, per-format booleans, drop coverage-command#18
kojiromike wants to merge 4 commits into
mainfrom 
feat/coverage-text-and-clover
Conversation
@kojiromike
@kojiromikekojiromike
commented
May 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Default coverage run produces three artifacts under coverage-report/: HTML report, coverage.txt (PHPUnit text report), clover.xml (machine-readable line coverage) for cheap agent / CI consumption.
  • Three new boolean inputs — coverage-html, coverage-text, coverage-clover (all default true) — let callers opt out of any format. At least one must be true.
  • Breaking:coverage-command is removed. The booleans are now the entire API for choosing outputs. Callers who need to customize PHPUnit (config path, suites, listeners, bootstrap, coverage filters, etc.) configure those in phpunit.xml, which PHPUnit auto-discovers.
Pairs with openCoreEMR/github-workflows-internal#33 (surfaces the text Summary in the PR comment and links the artifact).
Why drop coverage-command
The previous design eval'd an arbitrary string input. Even though the input is caller-trusted in GHA's model, the escape hatch invites future foot-shooting (e.g., a caller accidentally interpolating untrusted context). The booleans cover the common cases; phpunit.xml covers the rest.
Test plan
  •  Pin this branch via uses: on a real caller; confirm coverage-report/{coverage.txt,clover.xml,index.html} all appear in the uploaded artifact.
  •  Set coverage-clover: false and confirm clover.xml is absent.
  •  Set all three booleans to false and confirm the step fails fast with a clear error.
  •  Confirm a caller with a custom phpunit.xml (suites, exclusions) still picks it up via auto-discovery.
@kojiromike
feat(php-tests): emit text summary and Clover XML coverage outputs
cc9c22c
Default coverage-command now writes coverage.txt and clover.xml into
coverage-report/ alongside the HTML report, so consumers (PR comments,
agents, CI tools) can read coverage without scraping HTML.
Assisted-by: Claude Code
@kojiromike
feat(php-tests): gate coverage outputs behind per-format boolean flags
b6eb90e
Add coverage-html, coverage-text, coverage-clover (all default true) so
callers can opt out of any format. The default coverage-command becomes
empty and is composed from the booleans; setting coverage-command still
overrides everything as an escape hatch.
Assisted-by: Claude Code
@kojiromikekojiromike
added
the 
github-actions
GitHub Actions ecosystem
label
May 20, 2026
@kojiromike
feat(php-tests)!: drop coverage-command escape hatch
219b1e9
The booleans (coverage-html, coverage-text, coverage-clover) are now the
entire API for choosing which coverage outputs to emit. Removing the
arbitrary-shell-eval escape hatch eliminates a foot-gun: callers can no
longer accidentally interpolate untrusted GitHub context into a shell
string, and the workflow no longer eval's a free-form input.
Callers that need to customize PHPUnit (config path, suites, listeners,
bootstrap, coverage exclusions, etc.) configure those in phpunit.xml,
which PHPUnit auto-discovers.
BREAKING CHANGE: The coverage-command input has been removed. Callers
that set it must remove the input and move any custom PHPUnit
configuration into phpunit.xml.
Assisted-by: Claude Code
@kojiromike
style(php-tests): use = for bash string comparison
e4d9a5b
POSIX-canonical form in [[ ]] tests; reserve == for arithmetic inside
(( )).
Assisted-by: Claude Code
@kojiromikekojiromike
changed the title
feat(php-tests): emit text + Clover XML coverage, gated by booleansfeat(php-tests)!: emit text + Clover XML coverage, per-format booleans, drop coverage-commandMay 20, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

github-actionsGitHub Actions ecosystem

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@kojiromike

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
feat(php-tests)!: emit text + Clover XML coverage, per-format booleans, drop coverage-command by kojiromike · Pull Request #18 · openCoreEMR/github-workflows-public · GitHub
Skip to content
feat(php-tests)!: emit text + Clover XML coverage, per-format booleans, drop coverage-command - #18
Open
kojiromike wants to merge 4 commits into
mainfrom 
feat/coverage-text-and-clover
Open
feat(php-tests)!: emit text + Clover XML coverage, per-format booleans, drop coverage-command#18
kojiromike wants to merge 4 commits into
mainfrom 
feat/coverage-text-and-clover
Conversation
@kojiromike
@kojiromikekojiromike
commented
May 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Default coverage run produces three artifacts under coverage-report/: HTML report, coverage.txt (PHPUnit text report), clover.xml (machine-readable line coverage) for cheap agent / CI consumption.
  • Three new boolean inputs — coverage-html, coverage-text, coverage-clover (all default true) — let callers opt out of any format. At least one must be true.
  • Breaking:coverage-command is removed. The booleans are now the entire API for choosing outputs. Callers who need to customize PHPUnit (config path, suites, listeners, bootstrap, coverage filters, etc.) configure those in phpunit.xml, which PHPUnit auto-discovers.
Pairs with openCoreEMR/github-workflows-internal#33 (surfaces the text Summary in the PR comment and links the artifact).
Why drop coverage-command
The previous design eval'd an arbitrary string input. Even though the input is caller-trusted in GHA's model, the escape hatch invites future foot-shooting (e.g., a caller accidentally interpolating untrusted context). The booleans cover the common cases; phpunit.xml covers the rest.
Test plan
  •  Pin this branch via uses: on a real caller; confirm coverage-report/{coverage.txt,clover.xml,index.html} all appear in the uploaded artifact.
  •  Set coverage-clover: false and confirm clover.xml is absent.
  •  Set all three booleans to false and confirm the step fails fast with a clear error.
  •  Confirm a caller with a custom phpunit.xml (suites, exclusions) still picks it up via auto-discovery.
@kojiromike
feat(php-tests): emit text summary and Clover XML coverage outputs
cc9c22c
Default coverage-command now writes coverage.txt and clover.xml into
coverage-report/ alongside the HTML report, so consumers (PR comments,
agents, CI tools) can read coverage without scraping HTML.
Assisted-by: Claude Code
@kojiromike
feat(php-tests): gate coverage outputs behind per-format boolean flags
b6eb90e
Add coverage-html, coverage-text, coverage-clover (all default true) so
callers can opt out of any format. The default coverage-command becomes
empty and is composed from the booleans; setting coverage-command still
overrides everything as an escape hatch.
Assisted-by: Claude Code
@kojiromikekojiromike
added
the 
github-actions
GitHub Actions ecosystem
label
May 20, 2026
@kojiromike
feat(php-tests)!: drop coverage-command escape hatch
219b1e9
The booleans (coverage-html, coverage-text, coverage-clover) are now the
entire API for choosing which coverage outputs to emit. Removing the
arbitrary-shell-eval escape hatch eliminates a foot-gun: callers can no
longer accidentally interpolate untrusted GitHub context into a shell
string, and the workflow no longer eval's a free-form input.
Callers that need to customize PHPUnit (config path, suites, listeners,
bootstrap, coverage exclusions, etc.) configure those in phpunit.xml,
which PHPUnit auto-discovers.
BREAKING CHANGE: The coverage-command input has been removed. Callers
that set it must remove the input and move any custom PHPUnit
configuration into phpunit.xml.
Assisted-by: Claude Code
@kojiromike
style(php-tests): use = for bash string comparison
e4d9a5b
POSIX-canonical form in [[ ]] tests; reserve == for arithmetic inside
(( )).
Assisted-by: Claude Code
@kojiromikekojiromike
changed the title
feat(php-tests): emit text + Clover XML coverage, gated by booleansfeat(php-tests)!: emit text + Clover XML coverage, per-format booleans, drop coverage-commandMay 20, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

github-actionsGitHub Actions ecosystem

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@kojiromike